Re: [PATCH] filter: add support for owner-filter

2014-12-23 Thread Jason A. Donenfeld
Hi Chris, I like this patch, and I intend to merge it. Would you take care of John's nitpicks, and rebase this against the current master, and I'll merge? Sorry for the delay. Thanks, Jason ___ CGit mailing list CGit@lists.zx2c4.com

[PATCH] filter: add support for owner-filter

2014-08-01 Thread Chris Burroughs
Followup and attempt at implementation of an owner filter as described in http://lists.zx2c4.com/pipermail/cgit/2014-July/002163.html. There are two parts I am unsure of: * Is there an advantage (performance?) to passing the owner as an argument instead of using CGIT_REPO_OWNER? * I passed

Re: [PATCH] filter: add support for owner-filter

2014-08-01 Thread Chris Burroughs
On 08/01/2014 02:18 PM, John Keeping wrote: On Fri, Aug 01, 2014 at 01:54:46PM -0400, Chris Burroughs wrote: This isn't really acting as a filter, you're taking the argument from the function call and then just appending something based on that from the default generated by the C code. I think

Re: [PATCH] filter: add support for owner-filter

2014-08-01 Thread John Keeping
On Fri, Aug 01, 2014 at 04:01:53PM -0400, Chris Burroughs wrote: revised patch This type of comment should go below the --- line below, since it's not intended to be part of the commit message in the permanent history. Also filter in the subject doesn't really identify a code area. How about