Re: [PATCH 0/3] Fix some issues found by Coverity

On Mon, Feb 08, 2016 at 03:33:07PM +0100, Jason A. Donenfeld wrote: > Merged, thanks. Did you mean to merge this to master as well as jd/zx2c4-deployment? (I just want to make sure it doesn't get lost in a future rebase, not a problem if this was intentional to test it before applying to master.)

Re: [PATCH 0/3] Fix some issues found by Coverity

http://git.zx2c4.com/cgit/commit/?id=a8b9ef8c1c68fbb9c89db2d8c12dca38c15e2bfd ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 0/3] Fix some issues found by Coverity

On Mon, Feb 08, 2016 at 02:35:10PM +0100, Jason A. Donenfeld wrote: > http://git.zx2c4.com/cgit/commit/?id=a8b9ef8c1c68fbb9c89db2d8c12dca38c15e2bfd I'm not sure that quite goes far enough. Do you want to add this on top? -- >8 -- >From fad329930c9f57e0d75d9094bc70532283bd2b79 Mon Sep 17

Re: [PATCH 0/3] Fix some issues found by Coverity

Merged, thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 0/3] Fix some issues found by Coverity

Whoops. Thanks. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 0/3] Fix some issues found by Coverity

On Sun, 17 Jan, 2016 at 20:25:36 GMT, John Keeping wrote: > We're using "util" as a counter here, not a pointer. But it's declared > as "void*" so Coverity doesn't like this. > > We could try adding in some casts to uintptr_t but that's pretty > hideous. Otherwise we need to allocate an unsigned

Re: [PATCH 0/3] Fix some issues found by Coverity

On Sun, Jan 17, 2016 at 05:19:04PM +0100, Jason A. Donenfeld wrote: > So there is now only 1 issue remaining: 13839. > > static void add_commit(struct string_list *authors, struct commit *commit, > const struct cgit_period *period) > { > struct commitinfo *info; > struct

Re: [PATCH 0/3] Fix some issues found by Coverity

Thanks John! ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 0/3] Fix some issues found by Coverity

So there is now only 1 issue remaining: 13839. static void add_commit(struct string_list *authors, struct commit *commit, const struct cgit_period *period) { struct commitinfo *info; struct string_list_item *author, *item; struct authorstat *authorstat;

[PATCH 0/3] Fix some issues found by Coverity

These fix the three issues found by Coverity that are definitely incorrect. There are seven more issues which mostly look like false positives but I'm not sure if we should simply mark them as such or try to improve the situation with modelling. John Keeping (3): ui-log: handle parse_commit()