Re: [PATCH 1/1] snapshot: strip bit from struct cgit_snapshot_format

2018-06-10 Thread Christian Hesse
John Keeping on Sat, 2018/06/09 12:16: > I think this would be nicer if we introduce a BIT macro like Linux has, > something like: > > #define BIT(x) (1U << (x)) Reasonable. ;) > but even better, can't we have something like: > > static inline unsigned cgit_snapshot_bit( >

Re: [PATCH 1/1] snapshot: strip bit from struct cgit_snapshot_format

2018-06-09 Thread John Keeping
On Sat, Jun 09, 2018 at 12:11:11AM +0200, Christian Hesse wrote: > From: Christian Hesse > > We had a static bit value in struct cgit_snapshot_format. We do not rely > on it and things can be calculated on the fly. So strip it. > > Signed-off-by: Christian Hesse > --- > cgit.c| 3 ++-

[PATCH 1/1] snapshot: strip bit from struct cgit_snapshot_format

2018-06-08 Thread Christian Hesse
From: Christian Hesse We had a static bit value in struct cgit_snapshot_format. We do not rely on it and things can be calculated on the fly. So strip it. Signed-off-by: Christian Hesse --- cgit.c| 3 ++- cgit.h| 1 - shared.c | 5 - ui-shared.c | 3 ++- ui-snaps