Re: [PATCH 1/2] ui-ssdiff: ban strncat()

2019-02-12 Thread Christian Hesse
"Jason A. Donenfeld" on Sat, 2019/02/09 12:31: > Wouldn't strlcat be the more apt replacement? Looks like strlcat requires to link against libbsd. I do not think we want that, no? -- main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH" "CX:;",b;for(a/*Best regards

Re: [PATCH 1/2] ui-ssdiff: ban strncat()

2019-02-10 Thread Christian Hesse
"Jason A. Donenfeld" on Sat, 2019/02/09 12:31: > You sure those statements are the same? Snprintf doesn't append like > strncat. Wouldn't strlcat be the more apt replacement? We have an unconditional result[0] = '\0'; that mad be think it is safe. But we are inside a loop, so probably not... :-

Re: [PATCH 1/2] ui-ssdiff: ban strncat()

2019-02-09 Thread Jason A. Donenfeld
You sure those statements are the same? Snprintf doesn't append like strncat. Wouldn't strlcat be the more apt replacement? -- Sent from my telephone. On Fri, Feb 8, 2019, 22:49 Christian Hesse From: Christian Hesse > > Git version v2.21.0 marks strncat() as banned (commit > ace5707a803eda0f1dd

[PATCH 1/2] ui-ssdiff: ban strncat()

2019-02-08 Thread Christian Hesse
From: Christian Hesse Git version v2.21.0 marks strncat() as banned (commit ace5707a803eda0f1dde3d776dc3729d3bc7759a), so replace it. Signed-off-by: Christian Hesse Reviewed-by: John Keeping --- ui-ssdiff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui-ssdiff.c b/