On Thu, Jan 09, 2014 at 04:13:08PM +0100, Jason A. Donenfeld wrote: > On Thu, Jan 9, 2014 at 8:30 AM, Lukas Fleischer <c...@cryptocrack.de> wrote: > > We depend on Git in the test suite. Maybe this should be changed to use > > the binary from the Git submodule instead? > > I think we discussed the possibility of this a while ago with John. > This would make most sense to me, though we are using git's test > harness, and I'd like to avoid making invasive changes in that, if > possible.
We do already build the Git tools when building the test target (as opposed to just libgit.a when building the cgit binary), but I can't remember why we do this... It's probably simplest just to further tweak $PATH in tests/setup.sh so it also prepends "$(pwd)/../../git/bin-wrappers". That should cause us to use the Git tools from the submodule without needing to do anything else. > In either case, I wouldn't consider the test case a hard dependency, > and so I'm okay with removing git from the dep list. Or changing it to > "Git 1.8.5 (included)" or similar. _______________________________________________ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit
