Re: [PATCH 4/6] filter: add fprintf_filter function

2014-01-12 Thread Jason A. Donenfeld
What's the purpose of this? Why not just keep the original string that was passed to about-filter=... in the cmd variable as we have now? The thing that's variable from filter to filter is argv, the type (commit, about, etc), and the mechanism (lua, stdout, etc). But the variable aspects don't

Re: [PATCH 4/6] filter: add fprintf_filter function

2014-01-12 Thread John Keeping
On Sun, Jan 12, 2014 at 08:23:02PM +0100, Jason A. Donenfeld wrote: What's the purpose of this? Why not just keep the original string that was passed to about-filter=... in the cmd variable as we have now? The thing that's variable from filter to filter is argv, the type (commit, about, etc),

Re: [PATCH 4/6] filter: add fprintf_filter function

2014-01-12 Thread Jason A. Donenfeld
On Sun, Jan 12, 2014 at 8:35 PM, John Keeping j...@keeping.me.uk wrote: I'm looking at splitting up the data so there is a filter object that contains function pointers to implementation functions and then some data that is specific to to given filter type. With that change, cmd moves to the