Re: [PATCH v2] Remove trailing slash after remove-suffix

2014-12-23 Thread Jason A. Donenfeld
This is a good solution. Thanks for taking care of this Lukas. Merged. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH v2] Remove trailing slash after remove-suffix

2014-12-13 Thread Lukas Fleischer
When removing the .git suffix of a non-bare repository, also remove the trailing slash for compatibility with cgit_repobasename(). Signed-off-by: Lukas Fleischer c...@cryptocrack.de --- The previous version had a flaw (bogus pointer if there is no .git suffix). This one is much more readable add

Re: [PATCH v2] Remove trailing slash after remove-suffix

2014-12-13 Thread Charles Dee Rice
Thank you so much for the quick reply! The previous version had a flaw (bogus pointer if there is no .git suffix). This one is much more readable add should be applied on top of the Git 2.2.0 patch (which adds strip_suffix() and strip_suffix_mem()). Version 1 would definitely cause some