Re: [PATCH v7 1/1] ui-shared: allow to split the repository link

2017-03-12 Thread Petr Vorel
Hi John, > > Thanks for your review John. Are we there yet? :-) > I just noticed one more thing... > > + html_link_open(cgit_repourl(name), NULL, NULL); > The value returned by cgit_repourl() should be freed. Thanks for info, fixed in v8. Kind regards, Petr __

Re: [PATCH v7 1/1] ui-shared: allow to split the repository link

2017-03-12 Thread John Keeping
On Tue, Feb 21, 2017 at 12:36:04AM +0100, Petr Vorel wrote: > Teach cgit split the repository link in the top of repository "summary" > view. This emulates the same behaviour as it's in gitweb. > > This behaviour is not implemented for repositories which have > "repo.name" set different than "repo

Re: [PATCH v7 1/1] ui-shared: allow to split the repository link

2017-03-12 Thread John Keeping
On Tue, Feb 21, 2017 at 12:36:04AM +0100, Petr Vorel wrote: > Teach cgit split the repository link in the top of repository "summary" > view. This emulates the same behaviour as it's in gitweb. > > This behaviour is not implemented for repositories which have > "repo.name" set different than "repo

[PATCH v7 1/1] ui-shared: allow to split the repository link

2017-02-20 Thread Petr Vorel
Teach cgit split the repository link in the top of repository "summary" view. This emulates the same behaviour as it's in gitweb. This behaviour is not implemented for repositories which have "repo.name" set different than "repo.url". Signed-off-by: Petr Vorel Cc: "Jason A. Donenfeld" Cc: John