Re: [PATCH 1/1] ui-blog: fix oid handling

2016-10-16 Thread John Keeping
On Tue, Oct 11, 2016 at 08:59:11AM +0200, Christian Hesse wrote: > From: Christian Hesse > > We have to use a pointer for walk_tree_ctx->matched_oid. > > This fixes faulty commit 6e4b7b6776eb994e795fa38b2619db6c55e10ecc > (ui-blob: replace 'unsigned char sha1[20]' with 'struct object_id oid'). >

Re: [PATCH 1/1] ui-log: fix data corruption

2016-10-16 Thread John Keeping
On Wed, Oct 12, 2016 at 01:23:45PM +0200, Jason A. Donenfeld wrote: > So what's the verdict here? Do we have a double free or not? The current code is fine, providing we don't re-order it. The issue is that we free commit blobs while walking the log, so any attempt to use them after that without

Re: Linking cgit with Lua using -Wl,-E

2016-10-16 Thread John Keeping
On Sun, Oct 16, 2016 at 07:30:08AM +0200, Дилян Палаузов wrote: > on my system I wanted to link cgit with lua, so that lua can load the > (lua)crypto.so module. For this to work the symbol lua_gettop has to > be exported by cgit. I managed this by passing "-Wl,-E" to the > linker, when compiling