Re: [RFCv2 PATCH 2/7] ui-blame: create framework

On Fri, Sep 22, 2017 at 10:38:43PM -0500, Jeff Smith wrote: > Create framework for a page that will contain the 'blame' for a file > in the repository. > > Signed-off-by: Jeff Smith > --- > ui-blame.c | 160 > + >

Re: [RFCv2 PATCH 5/7] ui-blame: pull blame info from libgit

On Fri, Sep 22, 2017 at 10:38:46PM -0500, Jeff Smith wrote: > Use the blame interface added in libgit to output the blame information > of a file in the repository. > > Signed-off-by: Jeff Smith > --- > diff --git a/ui-blame.c b/ui-blame.c > index 901ca89..cc4457a 100644 >

Re: [RFCv2 PATCH 4/7] ui-blame: html_ntxt with no ellipsis

On Fri, Sep 22, 2017 at 10:38:45PM -0500, Jeff Smith wrote: > For implementing a ui-blame page, there is need for a function that > outputs a selection from a block of text, transformed for HTML output, > but with no further modifications or additions. > > Signed-off-by: Jeff Smith

Re: [RFCv2 PATCH 0/7] Add ui-blame

I will start re-arranging the patches to follow your suggestion. On Sat, Sep 23, 2017 at 10:53 AM, John Keeping wrote: > On Fri, Sep 22, 2017 at 10:38:41PM -0500, Jeff Smith wrote: >> I split git blame functionality into libgit, and the changes were >> accepted upstream and

Re: [RFCv2 PATCH 2/7] ui-blame: create framework

Yes, it is identical. I will look at extracting to ui-shared.c as you suggest. On Sat, Sep 23, 2017 at 10:47 AM, John Keeping wrote: > On Fri, Sep 22, 2017 at 10:38:43PM -0500, Jeff Smith wrote: >> Create framework for a page that will contain the 'blame' for a file >> in the