Re: [PATCH] Simplify commit and tag parsing

2015-03-05 Thread John Keeping
On Thu, Mar 05, 2015 at 11:46:55AM +0100, Jason A. Donenfeld wrote: > This commit breaks ui-tag. The first few lines of tag messages are cut off. It looks like parse_user() consumes the trailing LF on the user line, so next_header_line() ends up skipping the blank line at the end of the header. I

Re: [PATCH] Simplify commit and tag parsing

2015-03-05 Thread Jason A. Donenfeld
This commit breaks ui-tag. The first few lines of tag messages are cut off. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] Simplify commit and tag parsing

2015-03-03 Thread Jason A. Donenfeld
That's a pretty super dense commit, but it looks good to me after a read through. I'm going to merge this, but if somebody else wants to give it a pair of eyes, that'd be welcomed. ___ CGit mailing list CGit@lists.zx2c4.com http://lists.zx2c4.com/mailman/