Changeset: f732786bbd96 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/f732786bbd96
Modified Files:
gdk/gdk_logger.c
Branch: Jun2023
Log Message:
Do not warn about unknown bat in production code.
If a SQL object (table/column) is dropped, the row is added to
sql_dcatalog and an entry is written to the WAL. It may happen that the
dcatalog bat is written to disk but the WAL has not been rotated yet.
If the server restarts in this window, you get this now disabled
warning when the WAL is processed. After reading the WAL, the bat is
actually deleted in the subcommit phase since that goes through the
catalog, including the deleted rows, and destroys any bats that are
associated with deleted entries.
diffs (13 lines):
diff --git a/gdk/gdk_logger.c b/gdk/gdk_logger.c
--- a/gdk/gdk_logger.c
+++ b/gdk/gdk_logger.c
@@ -757,7 +757,9 @@ la_bat_destroy(logger *lg, logaction *la
if (bid < 0)
return GDK_FAIL;
if (!bid) {
+#ifndef NDEBUG
GDKwarning("failed to find bid for object %d\n", la->cid);
+#endif
return GDK_SUCCEED;
}
if (bid && log_del_bat(lg, bid) != GDK_SUCCEED)
_______________________________________________
checkin-list mailing list -- checkin-list@monetdb.org
To unsubscribe send an email to checkin-list-le...@monetdb.org
