PagingIterable

2010-04-23 Thread Klevenz, Stephan
Hi, One follow up task after F2F was to finish the implementation of the PagingIterable interface. This is finished now. In the client impl module you'll find a unit test testing the default implementation. In FIT module all APIs returning an Iterable are also covered by basic unit tests. I

Re: PagingIterable

2010-04-23 Thread David Caruana
Hi Stephan, I'm currently experimenting with the new PagingIterable in the context of a simple query web page. So, have some thoughts on your discussion points. On 23 Apr 2010, at 13:06, Klevenz, Stephan wrote: Hi, One follow up task after F2F was to finish the implementation of the

Re: PagingIterable

2010-04-23 Thread David Caruana
With the MIX option, I assume you also propose to remove the maxItems parameter from service calls. PagingIterableQueryResult) results = session.query(select ..., false); for (QueryResult result : results) { ... } for (QueryResult result : results.skipTo(100)) { ... } for (QueryResult

Re: PagingIterable

2010-04-23 Thread Florent Guillaume
Hi, I would propose SkippableIterable for the new name. It describes what this does, Item is a bit meaningless. Regarding simplified APIs I like them. Putting a default page size in the OperationContext is good. When using the API, I'd like it to be possible for a client to not care at all about

Re: PagingIterable

2010-04-23 Thread David Caruana
Ok, well I have an implementation of getPage() without an explicit maxItems parameter. I'll finish the tests and then checkin. We can then follow up with the next refactor which: - renames PagingIterable to the chosen name :-) - removes maxItems from the service calls - adds maxItems to

New OpenCMIS server interfaces - please review

2010-04-23 Thread Florian Müller
Hi, My follow up task from the face-to-face meeting was to refactor the server implementation. The new server interfaces are in place and should work now. Please check the service interface: org.apache.chemistry.opencmis.commons.api.server.CmisService [1] and