[Chicken-hackers] [PATCH] Drop unnecessary boxing of constant-table entries

2016-05-29 Thread Evan Hanson
Now that "collapsable-literal?" constants are inserted into the constants table as quoted values, there's no need to box them in a list (which was done to ensure that "#f" isn't treated as a missing entry). --- core.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Chicken-hackers] [PATCH][5] Drop unnecessary boxing of constant-table entries

2016-05-29 Thread Evan Hanson
Hi Peter, Good eye! Applied. We can even go a bit further still and get rid of the boxing of values in the constants table, by the same line of reasoning. Patch attached. Cheers, Evan ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org

Re: [Chicken-hackers] [PATCH] Hash all the record slots

2016-05-29 Thread lemonboy
I actually forgot to attach the patch, so here it is. On 29 May 2016 at 22:27, lemonboy wrote: > Hello, > While investigating the ticket #1293 [1] I noticed that the hashing > procedures would stop hashing all the vectors > at the 4th element and while that's a valuable way

[Chicken-hackers] [PATCH] Hash all the record slots

2016-05-29 Thread lemonboy
Hello, While investigating the ticket #1293 [1] I noticed that the hashing procedures would stop hashing all the vectors at the 4th element and while that's a valuable way to speed up the hashing process it causes some problems in the wild. If you use a record with N > 4 slots as a key and then

Re: [Chicken-hackers] [PATCH] Truncate overlong lines in ##sys#error-handler

2016-05-29 Thread felix . winkelmann
> On Wed, May 25, 2016 at 09:41:52PM +0200, lemonboy wrote: > > Hello, > > this patch makes ##sys#error-handler respect the width limit as it's > > done in the other code paths. > > (Limits have been bumped to 100 to make those uniform throughout the code) > > I hope the merge window is still open

Re: [Chicken-hackers] [PATCH] Truncate overlong lines in ##sys#error-handler

2016-05-29 Thread Peter Bex
On Wed, May 25, 2016 at 09:41:52PM +0200, lemonboy wrote: > Hello, > this patch makes ##sys#error-handler respect the width limit as it's > done in the other code paths. > (Limits have been bumped to 100 to make those uniform throughout the code) > I hope the merge window is still open :) I

[Chicken-hackers] [PATCH][5] Remove unnecessary booleans inline-table-used and constants-used

2016-05-29 Thread Peter Bex
Hi all, While reviewing Evan's patch for the define-constant fix, I noticed that these two booleans are completely redundant. Note that the things inserted into those tables are never #f, so this lookup should work after the other patch has been applied. At first I thought that this would fail

Re: [Chicken-hackers] [PATCH] Make `define-constant` support singly-quoted symbols

2016-05-29 Thread Peter Bex
On Tue, May 24, 2016 at 03:41:09PM +1200, Evan Hanson wrote: > Allows the following program to work correctly: > > (define-constant a 'frizzle) > (print a) > > Previously, the second `a` would be replaced by an *unquoted* `frizzle`, > resulting in an undefined variable reference (or, if the