Re: [Chicken-hackers] [PATCH] Use vertical space more liberally in some scrutinizer messages

2018-11-19 Thread felix . winkelmann
> > Here's the patchset without the first commit. > Thanks, much appreciated. Now we just have to find someone who understands the scrutinizer and can review these patches... :-) felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org

Re: [Chicken-hackers] [PATCH] Use vertical space more liberally in some scrutinizer messages

2018-11-19 Thread Peter Bex
On Mon, Nov 19, 2018 at 08:16:45PM +0100, felix.winkelm...@bevuta.com wrote: > Be that as it may, I don't think such changes have any benefit. We don't > follow a beauty contest, content is more important as the amount of > whitespace, > comment or indentation style and so on. Changes of

Re: [Chicken-hackers] [PATCH] Use vertical space more liberally in some scrutinizer messages

2018-11-19 Thread felix . winkelmann
> > I'm vehemently against patches that merely change whitespace or > > layout (patch 1/9) and make it impossible to track changes properly. > > You can give the -w switch to git blame to see through whitespace > changes. Or (setq vc-git-annotate-switches '("-w")) in emacs if you're > using

Re: [Chicken-hackers] [PATCH] Use vertical space more liberally in some scrutinizer messages

2018-11-19 Thread megane
felix.winkelm...@bevuta.com writes: >> >> Hi, >> >> Here's a reworked patch set. It's not exactly small, but I tried to make >> it pretty easy to follow. Except maybe for the last patch, which >> digs for some extra info from the nodes. >> >> There's small bit of back-and-forth in the

Re: [Chicken-hackers] [PATCH] Use vertical space more liberally in some scrutinizer messages

2018-11-19 Thread felix . winkelmann
> > Hi, > > Here's a reworked patch set. It's not exactly small, but I tried to make > it pretty easy to follow. Except maybe for the last patch, which > digs for some extra info from the nodes. > > There's small bit of back-and-forth in the patches: > - errors? is taken out of let and put

Re: [Chicken-hackers] PATCH Re: slow polling

2018-11-19 Thread Jörg F . Wittenberger
Hi Megane, thanks for looking at my submission. Let me try to answer your questions. On Nov 17 2018, megane wrote: Jörg F. Wittenberger writes: Am 19.02.2016 um 22:39 schrieb Jörg F. Wittenberger: ... I opened ticket 1259 for this. To make the kind reviewers job easier, I'll post