Re: [Chicken-hackers] [PATCH] Fix #1294 by mentioning in the docs that define-record-printer is not a definition

2019-09-14 Thread Evan Hanson
Hi Peter, On 2019-09-14 15:28, Peter Bex wrote: > I made a few small tweaks to the patch, see attachment. The types.db > entry was syntactically invalid so I fixed that, and I've added checks > that the argument to set-record-printer! is a symbol (the original > macro contains that check as

Re: [Chicken-hackers] [PATCH] Fix couple of hangs related to finalizers and (gc #t)

2019-09-14 Thread Peter Bex
On Sat, Aug 10, 2019 at 08:04:31AM +0300, megane wrote: > megane writes: > > Also signal an error if trying to re-enter. This also would cause an > > infinite loop (when calling (gc #t) inside a finalizer). It would > > need special handling if re-entry is to be supported. > > This is too

Re: [Chicken-hackers] [PATCH] Fix #1294 by mentioning in the docs that define-record-printer is not a definition

2019-09-14 Thread Peter Bex
On Tue, Aug 13, 2019 at 10:16:01PM +1200, Evan Hanson wrote: > Sure, here's a patch that adds a procedural interface as proposed above. > This is also the approach Guile uses, although theirs is called > `set-record-type-printer!`. Let me know what you think. I really like that what was a macro

Re: [Chicken-hackers] [PATCH] Disallow exporting external variables

2019-09-14 Thread Peter Bex
On Sun, Aug 25, 2019 at 12:33:50PM +0200, felix.winkelm...@bevuta.com wrote: > See #1346. Thanks, pushed. I'll keep the ticket open for define-constant and define-type. I'm not sure about the latter though, because types should be in a different namespace than identifiers (you can have a type x