Re: [Chicken-hackers] [PATCH] Detect self-reference in "letrec"

2019-09-15 Thread Peter Bex
On Sun, Sep 15, 2019 at 05:12:00PM +0200, felix.winkelm...@bevuta.com wrote: > I moved the variable into c.-e. and also changed the error message > to be slightly more useful. Thanks, pushed! Cheers, Peter signature.asc Description: PGP signature ___

Re: [Chicken-hackers] [PATCH] Detect self-reference in "letrec"

2019-09-15 Thread felix . winkelmann
> On Wed, Aug 28, 2019 at 01:41:22PM +0200, felix.winkelm...@bevuta.com wrote: > > An attempt to fix #1645. See commit message for more details. > > Hi Felix, > > I've taken a look at it and the logic itself looks good, but I find the > usage of fluid-let on a global variable unsettling. Why not

[Chicken-hackers] [PATCH] Fix how chicken-install handles server errors and add redirect support

2019-09-15 Thread Peter Bex
Hi all, We noticed in yesterday's Salmonella run that chicken-install isn't handling HTTP error codes correctly: https://salmonella-freebsd-x86-64.call-cc.org/master/clang/freebsd/x86-64/2019/09/15/yesterday-diff/log2/install/zmq.html As you can see, we get a compiler error on an HTML document

Re: [Chicken-hackers] [PATCH 4/6] * scrutinizer.scm: Infer more exact types after set!

2019-09-15 Thread megane
Peter Bex writes: > On Thu, Aug 22, 2019 at 02:51:26PM +0300, megane wrote: >> Hi, >> >> I'm working on some inference improvements and I noticed the blist keeps >> accumulating some bogus entries. Commit 0003 removes some of those. > > Hi Megane, > > I've pushed your cleanups because I believe

Re: [Chicken-hackers] [PATCH] Fix #1620 by ignoring captured state of replaced variables

2019-09-15 Thread Peter Bex
On Sun, Aug 25, 2019 at 04:34:02PM +0200, Peter Bex wrote: > On Sat, Jul 20, 2019 at 11:51:28AM +0300, megane wrote: > > Here's a new patch that drops the (not captured) check. > > Thanks for making that! Now that my original patch has been pushed, > here's an incremental patch based on yours

Re: [Chicken-hackers] [PATCH] Some simplification rules for nested ##core#inline forms

2019-09-15 Thread Peter Bex
On Wed, Sep 04, 2019 at 11:59:31AM +0200, felix.winkelm...@bevuta.com wrote: > The attached patch adds two optimization rules for certain uses of > ##core#inline. It basically rewrites > > (let (( (##core#inline ...))) > ( ... ...)) > > into > > ( ... (##core##inline ...) ...) > > plus a

Re: [Chicken-hackers] [PATCH] Detect self-reference in "letrec"

2019-09-15 Thread Peter Bex
On Wed, Aug 28, 2019 at 01:41:22PM +0200, felix.winkelm...@bevuta.com wrote: > An attempt to fix #1645. See commit message for more details. Hi Felix, I've taken a look at it and the logic itself looks good, but I find the usage of fluid-let on a global variable unsettling. Why not pass the

Re: [Chicken-hackers] [PATCH 4/6] * scrutinizer.scm: Infer more exact types after set!

2019-09-15 Thread Peter Bex
On Thu, Aug 22, 2019 at 02:51:26PM +0300, megane wrote: > Hi, > > I'm working on some inference improvements and I noticed the blist keeps > accumulating some bogus entries. Commit 0003 removes some of those. Hi Megane, I've pushed your cleanups because I believe they make the code and