Re: [Chicken-hackers] [PATCH] * eval.scm (compile): Remove failing environment lookup in ##core#set!

2018-08-04 Thread felix . winkelmann
Pushed. felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers

Re: [Chicken-hackers] [PATCH] * eval.scm (compile): Remove failing environment lookup in ##core#set!

2018-08-04 Thread Peter Bex
On Fri, Aug 03, 2018 at 09:39:46PM +0300, megane wrote: > > I couldn't come up with a way to test this. You > can test the old one if you add print to the case and run this: > > (let ([l '(##core#set! x 1)]) > (##sys#current-environment (cons `(,l . foo) (##sys#current-environment))) > (eval

Re: [Chicken-hackers] [PATCH] * eval.scm (compile): Remove failing environment lookup in ##core#set!

2018-08-03 Thread megane
I couldn't come up with a way to test this. You can test the old one if you add print to the case and run this: (let ([l '(##core#set! x 1)]) (##sys#current-environment (cons `(,l . foo) (##sys#current-environment))) (eval l)) ___ Chicken-hackers

Re: [Chicken-hackers] [PATCH] * eval.scm (compile): Remove failing environment lookup in ##core#set!

2018-08-03 Thread Peter Bex
On Fri, Aug 03, 2018 at 02:43:29PM +0300, megane wrote: > Hi, > > Here's a small simplification. Could you add a test? The comment already says the lookup is wrong, but I'd like to have a regression test to ensure we keep it correct. Cheers, Peter signature.asc Description: PGP signature

[Chicken-hackers] [PATCH] * eval.scm (compile): Remove failing environment lookup in ##core#set!

2018-08-03 Thread megane
Hi, Here's a small simplification. >From 1b1a40c347789e3aa01ce6b2a8f596cf15f9c7f0 Mon Sep 17 00:00:00 2001 From: megane Date: Fri, 3 Aug 2018 13:54:05 +0300 Subject: [PATCH] * eval.scm (compile): Remove failing environment lookup in ##core#set! The x is the full expression (e.g. '(##core#set!