Re: [Chicken-hackers] [PATCH] Detect self-reference in "letrec"

2019-09-15 Thread Peter Bex
On Sun, Sep 15, 2019 at 05:12:00PM +0200, felix.winkelm...@bevuta.com wrote: > I moved the variable into c.-e. and also changed the error message > to be slightly more useful. Thanks, pushed! Cheers, Peter signature.asc Description: PGP signature ___

Re: [Chicken-hackers] [PATCH] Detect self-reference in "letrec"

2019-09-15 Thread felix . winkelmann
> On Wed, Aug 28, 2019 at 01:41:22PM +0200, felix.winkelm...@bevuta.com wrote: > > An attempt to fix #1645. See commit message for more details. > > Hi Felix, > > I've taken a look at it and the logic itself looks good, but I find the > usage of fluid-let on a global variable unsettling. Why not

Re: [Chicken-hackers] [PATCH] Detect self-reference in "letrec"

2019-09-15 Thread Peter Bex
On Wed, Aug 28, 2019 at 01:41:22PM +0200, felix.winkelm...@bevuta.com wrote: > An attempt to fix #1645. See commit message for more details. Hi Felix, I've taken a look at it and the logic itself looks good, but I find the usage of fluid-let on a global variable unsettling. Why not pass the

[Chicken-hackers] [PATCH] Detect self-reference in "letrec"

2019-08-28 Thread felix . winkelmann
An attempt to fix #1645. See commit message for more details. felix From a0a8eed96e06520c996a8ee3965eae5aa80c655b Mon Sep 17 00:00:00 2001 From: felix Date: Wed, 28 Aug 2019 13:37:16 +0200 Subject: [PATCH] Catch self-referencing variables in `letrec' form "(letrec ((x x)) ...)" results in and