Re: [Chicken-hackers] [PATCH] Fix arguments to scrutiny reporting procedure for `append'

2019-03-31 Thread Peter Bex
On Sun, Mar 31, 2019 at 03:38:30PM +1300, Evan Hanson wrote: > WFM. Signoff attached. Thanks! I've pushed this now. Cheers, Peter signature.asc Description: PGP signature ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org

Re: [Chicken-hackers] [PATCH] Fix arguments to scrutiny reporting procedure for `append'

2019-03-30 Thread Evan Hanson
WFM. Signoff attached. Evan >From 499a97da7830d3a9fba998c0e25821492e8c401e Mon Sep 17 00:00:00 2001 From: megane Date: Sat, 30 Mar 2019 09:26:59 +0200 Subject: [PATCH] Make scrutinizer message format test suite more comprehensive Signed-off-by: Evan Hanson ---

Re: [Chicken-hackers] [PATCH] Fix arguments to scrutiny reporting procedure for `append'

2019-03-30 Thread megane
Evan Hanson writes: > On 2019-03-25 14:23, megane wrote: >> The last patchset contained a more comprehensive message format test >> suite. I guess I just forgot to mention that, sorry :P >> >> Here's a patch that applies on top of this fix. > > Thanks megane, here's a signed-off copy. > > I

Re: [Chicken-hackers] [PATCH] Fix arguments to scrutiny reporting procedure for `append'

2019-03-29 Thread Evan Hanson
Actually attached this time. >From a9d1c0efe1ee5315d16233a016f88617b47f9075 Mon Sep 17 00:00:00 2001 From: megane Date: Mon, 25 Mar 2019 14:15:19 +0200 Subject: [PATCH] Make scrutinizer message format test suite more comprehensive Signed-off-by: Evan Hanson --- tests/runtests.bat

Re: [Chicken-hackers] [PATCH] Fix arguments to scrutiny reporting procedure for `append'

2019-03-29 Thread Evan Hanson
On 2019-03-25 14:23, megane wrote: > The last patchset contained a more comprehensive message format test > suite. I guess I just forgot to mention that, sorry :P > > Here's a patch that applies on top of this fix. Thanks megane, here's a signed-off copy. I changed the new TVs ('foo et al.) to

Re: [Chicken-hackers] [PATCH] Fix arguments to scrutiny reporting procedure for `append'

2019-03-29 Thread Peter Bex
On Mon, Mar 25, 2019 at 09:46:59PM +1300, Evan Hanson wrote: > Hi folks, > > Here's a patch that fixes #1592, which was also discovered by Kooda in > IRC this morning. > > I'm pretty sure I introduced this bug while applying megane's patches, > or at least made the problem worse. In my defense,

Re: [Chicken-hackers] [PATCH] Fix arguments to scrutiny reporting procedure for `append'

2019-03-25 Thread megane
Evan Hanson writes: > Hi folks, > > Here's a patch that fixes #1592, which was also discovered by Kooda in > IRC this morning. > > I'm pretty sure I introduced this bug while applying megane's patches, > or at least made the problem worse. In my defense, the variable names in > this bit of code

[Chicken-hackers] [PATCH] Fix arguments to scrutiny reporting procedure for `append'

2019-03-25 Thread Evan Hanson
Hi folks, Here's a patch that fixes #1592, which was also discovered by Kooda in IRC this morning. I'm pretty sure I introduced this bug while applying megane's patches, or at least made the problem worse. In my defense, the variable names in this bit of code didn't help, so this patch also