Re: [Chicken-hackers] [PATCH] Send C_DEBUGGER_REPLY_GET_BYTES responses as unsigned char values

2016-03-08 Thread Peter Bex
On Sun, Mar 06, 2016 at 10:53:57PM +0100, Peter Bex wrote: > I think the patch is good, I'll apply it soon. Done. Cheers, Peter signature.asc Description: Digital signature ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org

Re: [Chicken-hackers] [PATCH] Send C_DEBUGGER_REPLY_GET_BYTES responses as unsigned char values

2016-03-06 Thread Peter Bex
On Sun, Mar 06, 2016 at 04:01:05PM +1300, Evan Hanson wrote: > On 2016-03-05 14:16, Peter Bex wrote: > > On Fri, Mar 04, 2016 at 02:03:14PM +1300, Evan Hanson wrote: > > > - sprintf(rw_buffer, " %lu", (unsigned long)((char > > > *)C_data_pointer(x))[ n ]); > > > +

Re: [Chicken-hackers] [PATCH] Send C_DEBUGGER_REPLY_GET_BYTES responses as unsigned char values

2016-03-05 Thread Evan Hanson
On 2016-03-05 14:16, Peter Bex wrote: > On Fri, Mar 04, 2016 at 02:03:14PM +1300, Evan Hanson wrote: > > - sprintf(rw_buffer, " %lu", (unsigned long)((char > > *)C_data_pointer(x))[ n ]); > > + sprintf(rw_buffer, " %u", ((unsigned char *)C_data_pointer(x))[ > > n ]); > >

Re: [Chicken-hackers] [PATCH] Send C_DEBUGGER_REPLY_GET_BYTES responses as unsigned char values

2016-03-05 Thread John Cowan
Peter Bex scripsit: > Does this mean an unsigned char argument to a varags function is always > widened to "int"? How else can it know how much to take off the stack? Yes, it does. This pattern is called "the integer promotions" in the C standards: _Bool, short, char, bitfield, and enum types

Re: [Chicken-hackers] [PATCH] Send C_DEBUGGER_REPLY_GET_BYTES responses as unsigned char values

2016-03-05 Thread Peter Bex
On Fri, Mar 04, 2016 at 02:03:14PM +1300, Evan Hanson wrote: > This allows the client to consider the stream as a written u8vector, > without needing to mask off the extra bits of any elements outside the > byte range. > --- > dbg-stub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[Chicken-hackers] [PATCH] Send C_DEBUGGER_REPLY_GET_BYTES responses as unsigned char values

2016-03-03 Thread Evan Hanson
This allows the client to consider the stream as a written u8vector, without needing to mask off the extra bits of any elements outside the byte range. --- dbg-stub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dbg-stub.c b/dbg-stub.c index 96227de..bbfa3c5 100644 ---