Re: [Chicken-hackers] [PATCH] check for exported types, constants, inline procedures (#1346)

2019-10-10 Thread megane
Peter Bex writes: > On Thu, Oct 03, 2019 at 01:11:31PM +0200, felix.winkelm...@bevuta.com wrote: >> This patch extends 21ff0d6affb35f7184a5e78f9d4beccc869b47b2 to >> type-names, inline procedures and constants, giving a warning when >> an identifier naming such an entity is exported. > > Hi

Re: [Chicken-hackers] [PATCH] check for exported types, constants, inline procedures (#1346)

2019-10-09 Thread Peter Bex
On Thu, Oct 03, 2019 at 01:11:31PM +0200, felix.winkelm...@bevuta.com wrote: > This patch extends 21ff0d6affb35f7184a5e78f9d4beccc869b47b2 to > type-names, inline procedures and constants, giving a warning when > an identifier naming such an entity is exported. Hi all, Apparently this commit

Re: [Chicken-hackers] [PATCH] check for exported types, constants, inline procedures (#1346)

2019-10-06 Thread Peter Bex
On Sat, Oct 05, 2019 at 06:45:42PM +0200, felix.winkelm...@bevuta.com wrote: > Right, please just apply your patch, if you are ok with my changes. I agree > about the types. Done! Thanks for pushing forward on this. Cheers, Peter signature.asc Description: PGP signature

Re: [Chicken-hackers] [PATCH] check for exported types, constants, inline procedures (#1346)

2019-10-05 Thread felix . winkelmann
> > So, I'd suggest the attached patch instead. I've also updated NEWS > to mention the other types we check and remove the comment that the > fix is partial. Right, please just apply your patch, if you are ok with my changes. I agree about the types. felix

Re: [Chicken-hackers] [PATCH] check for exported types, constants, inline procedures (#1346)

2019-10-05 Thread Peter Bex
On Thu, Oct 03, 2019 at 01:11:31PM +0200, felix.winkelm...@bevuta.com wrote: > This patch extends 21ff0d6affb35f7184a5e78f9d4beccc869b47b2 to > type-names, inline procedures and constants, giving a warning when > an identifier naming such an entity is exported. I think the types should be

[Chicken-hackers] [PATCH] check for exported types, constants, inline procedures (#1346)

2019-10-03 Thread felix . winkelmann
This patch extends 21ff0d6affb35f7184a5e78f9d4beccc869b47b2 to type-names, inline procedures and constants, giving a warning when an identifier naming such an entity is exported. felix From 069f65ef454be763ac011ec04ff4f1f317eb610a Mon Sep 17 00:00:00 2001 From: felix Date: Thu, 3 Oct 2019