Re: [PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows

2019-11-23 Thread Evan Hanson
On 2019-11-22 19:16, Peter Bex wrote: > On Mon, Nov 11, 2019 at 08:57:11PM +0100, Peter Bex wrote: > > I actually prefer it the "cd /d" way, because then we can't accidentally > > forget to introduce this elsewhere: we can just call cd-command and it > > will work on Windows if it works on UNIX.

Re: [PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows

2019-11-22 Thread Peter Bex
On Mon, Nov 11, 2019 at 08:57:11PM +0100, Peter Bex wrote: > I actually prefer it the "cd /d" way, because then we can't accidentally > forget to introduce this elsewhere: we can just call cd-command and it > will work on Windows if it works on UNIX. The code will be shorter as > well. So let's

Re: [PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows

2019-11-11 Thread Peter Bex
On Tue, Nov 12, 2019 at 08:27:30AM +1300, Evan Hanson wrote: > On 2019-11-11 13:57, Lassi Kortela wrote: > > > > The fix is to first switch drives, then run cd. > > > > `cd /d c:\foo` can be used to switch the drive and the directory both in one > > command. > > Oh, that's good to know, thanks

Re: [PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows

2019-11-11 Thread Evan Hanson
On 2019-11-11 13:57, Lassi Kortela wrote: > > > The fix is to first switch drives, then run cd. > > `cd /d c:\foo` can be used to switch the drive and the directory both in one > command. > Oh, that's good to know, thanks Lassi. Peter, do you think it's worth switching to use this flag

Re: [PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows

2019-11-11 Thread Lassi Kortela
The fix is to first switch drives, then run cd. `cd /d c:\foo` can be used to switch the drive and the directory both in one command.

Re: [PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows

2019-11-11 Thread Evan Hanson
Hi Peter, On 2019-11-09 17:15, Peter Bex wrote: > I had a look at #1647 and the fix seems to me to be pretty > straightforward. The build.bat which chicken-install creates > contains a "cd" command, but on Windows, cd won't change to > the corresponding drive, so when we then try to compile the

[PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows

2019-11-09 Thread Peter Bex
Hi all, I had a look at #1647 and the fix seems to me to be pretty straightforward. The build.bat which chicken-install creates contains a "cd" command, but on Windows, cd won't change to the corresponding drive, so when we then try to compile the source file, we'll get an error because we're