Re: [Chicken-hackers] Some undefined patches

2019-04-01 Thread megane
felix.winkelm...@bevuta.com writes: >> Another change is considering 'undefined' as a truthy value. The >> interpreter considers 'undefined' truthy, too. > > Undefined is undefined, we shouldn't make any assumption here. Hi Felix, When the scrutinizer walks (begin) it knows the returned value

Re: [Chicken-hackers] Some undefined patches

2019-04-01 Thread felix . winkelmann
> Another change is considering 'undefined' as a truthy value. The > interpreter considers 'undefined' truthy, too. Undefined is undefined, we shouldn't make any assumption here. felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org

[Chicken-hackers] [PATCH] * runtime.c (C_delete_symbol_table): Remove dead code

2019-04-01 Thread felix . winkelmann
> Hi! > > Here's a small one. > I think the original code is wrong (as this function is never used it didn't crash so far). We should probably remove this altogether. felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org

[Chicken-hackers] [PATCH] * runtime.c (C_delete_symbol_table): Remove dead code

2019-04-01 Thread megane
Hi! Here's a small one. >From b0bd69d84ca7825a23a878160b65e0fa29c2e18c Mon Sep 17 00:00:00 2001 From: megane Date: Sun, 24 Mar 2019 10:22:08 +0200 Subject: [PATCH] * runtime.c (C_delete_symbol_table): Remove dead code Variable prev is never assigned to. Therefore only the false branch is ever

Re: [Chicken-hackers] [PATCH] Reset port EOF flag when seeking

2019-04-01 Thread kooda
Peter Bex wrote: > I think this isn't entirely correct; your code returns either > # or whatever C_fseek returns. The wrapping "unless" > will thus see # if the when's condition is false. > […] > though I don't really like the nested (and ... (begin ...)). Woops! Indeed! Here’s a new patch. Do

[Chicken-hackers] [PATCH] Always regenerate import libraries in setup-mode

2019-04-01 Thread Evan Hanson
Hi all, Here's a patch that addresses a bad interaction between chicken-do and the code in core.scm that avoids regenerating import libraries when they haven't changed. Basically, by skipping the import library, target files can become stuck as "out of date" and that further invocations of