Re: [PATCH] export/rename

2023-10-03 Thread Evan Hanson
Maybe this already works with the current patch, but can we support: (export (rename foo bar)) As well as the version with the colon (suffix keyword notation) on the end of export? Seems like that would be best for symmetry with the import form. (Sorry, it’s just aesthetics, I know.) Evan

Re: [PATCH] Restore read/source-info in support.scm and export it officially from (chicken syntax)

2023-07-02 Thread Evan Hanson
Hi there, On 2023-06-30 9:11, Peter Bex wrote: > Since these eggs are using it, that TODO above ##sys#read/source-info > is settled - it's useful enough for those eggs, so let's just expose > it publically and document it. I wouldn't read too much into those eggs -- most of those are mine, and

[PATCH] Pass executed filename to execv[pe] unmodified when calling process-execute

2023-06-03 Thread Evan Hanson
to leave that pathname alone. Cheers, Evan >From 82cd4c9a8fe4434f7db9e2eb9599a470a8442b3e Mon Sep 17 00:00:00 2001 From: Evan Hanson Date: Sun, 4 Jun 2023 00:55:02 +0200 Subject: [PATCH] Pass executed filename to execv[pe] unmodified when calling process-execute Programs created via `process-exec

Re: [PATCH] always check servers if version not given

2022-10-27 Thread Evan Hanson
Applied! Lots of tickets closed lately, very cool. Evan On 2022-10-21 12:22, felix.winkelm...@bevuta.com wrote: > Make sure we check for the newest version, if performing an egg install > without an explicitly given version. See also #1802. > > > felix > From

Re: [PATCH] make types-files more deterministic

2022-10-27 Thread Evan Hanson
On 2022-10-21 15:50, felix.winkelm...@bevuta.com wrote: > This patch changes the code in the scrutinizer to output types > file entries in sorted order. Nice change, pushed! Evan

Re: absolute pathname a.k.a. realpath

2022-10-25 Thread Evan Hanson
On 2022-10-25 11:52, felix.winkelm...@bevuta.com wrote: > Does (make-absolute-pathname #f ...) make any sense with the currently > implemented behaviour? It seems to me that this case could handle the > operation as requested by sandra. I think that would be the ideal, yeah, if you could use #f

Re: absolute pathname a.k.a. realpath

2022-10-24 Thread Evan Hanson
On 2022-10-24 14:14, John Cowan wrote: > As designed, the pathname module does not access the filesystem (except > that it knows whether the default is Posix or Windows), and I'd like to > keep it that way. Realpath is available in the Posix module. I'd tend to agree with John. Path resolution

Re: absolute pathname a.k.a. realpath

2022-10-23 Thread Evan Hanson
On 2022-08-18 10:23, Sandra Snan wrote: > Would you please add something like this to the pathname module? > > (define (absolute-pathname name) > (normalize-pathname >(if (absolute-pathname? name) name >(make-absolute-pathname (current-directory) name > > Whatever you wanna call

Re: [PATCH] add fp*+ operator

2022-04-11 Thread Evan Hanson
Cool! I've applied this to master. All the best, Evan

Re: [PATCH] Expose csi toplevel REPL driver

2021-11-21 Thread Evan Hanson
Cool, good idea! That's a really nice addition. Applied. Evan

Re: [PATCH 0/3] Clarify built-in library/SRFI feature behaviour

2021-10-19 Thread Evan Hanson
On 2021-10-19 12:20, felix.winkelm...@bevuta.com wrote: > I wanted to try it, but patch #1 does not apply. Ah, sorry about that. Updated versions attached! Evan >From d7ef79a885d7fc02b2a893e3e000a30db1cac899 Mon Sep 17 00:00:00 2001 From: Evan Hanson Date: Mon, 18 Oct 2021 17:00:20

Re: [PATCH 0/3] Clarify built-in library/SRFI feature behaviour

2021-10-18 Thread Evan Hanson
On 2021-10-18 13:31, felix.winkelm...@bevuta.com wrote: > As far as I can tell builtin-features has simply been dropped. How do you > avoid having 'srfi-9 as a requirement? Yeah, that's what the second patch is all about. Since SRFI-9 is a syntax-only module (defined in modules.scm), we can no-op

[PATCH 0/3] Clarify built-in library/SRFI feature behaviour

2021-10-18 Thread Evan Hanson
of the SRFI-related feature identifiers to make sure they were registered in the right files, and that the documentation was up to date. That's patch number three, have a look and let me know what you think. All the best, Evan >From 5458c9b049aef8e4f22581ca0ed529fac8c49ccc Mon Sep 17 00:00:00 2001

Re: [PATCH] Check argument type for setters in (chicken process-context posix)

2021-09-24 Thread Evan Hanson
Looks good, applied to both prerelease and master. Thanks Peter, and thank you Chris for testing as well. Evan

Re: Release process?

2021-08-11 Thread Evan Hanson
On 2021-08-06 10:59, Peter Bex wrote: > Evan just closed the last ticket in our roadmap for 5.3 > (https://bugs.call-cc.org/roadmap). So I think now is a good > time to start the (pre)release process. Yeah, I think we should go ahead too. ISTM the remaining questions have been answered? But even

Re: [PATCH] Add regression test for #1771

2021-08-05 Thread Evan Hanson
Works for me, applied. Thanks Peter! Evan

Re: A facility for debugging type issues

2021-08-05 Thread Evan Hanson
Hey megane! On 2021-04-10 11:24, megane wrote: > here's a POC tool I've been using for a year. It prints the types known to > scrutinizer in the current scope. Finally having a look at this, and I have to say, it is very cool. It still applies cleanly too! :) What were you thinking ought to be

Re: [PATCH] Fix #1757 by not merging module environment into the syntactic environments of reexported macros

2021-07-30 Thread Evan Hanson
On 2021-07-14 12:45, Peter Bex wrote: > Here's a reasonably straightforward patch (I hope) for #1757. > Commit should speak for itself, even if the stuff itself is > a bit tricky. It really is, this took some time to understand... But it does seem like the right thing, now that you've spelled it

Re: Misc scrutizer annotation fixes for FFI

2021-07-29 Thread Evan Hanson
Nice, thanks megane, these are all nice improvements. I've applied the whole lot. I expanded the commit message for the last patch a bit, since I didn't realise at first that it was fixing both the return type (using forall) and the argument types (changing false to locative). Cheers, Evan

Re: [PATCH] Fix #1727 with patch from ticket

2021-07-29 Thread Evan Hanson
Excellent, applied. Thanks to all involved, this should make some folks' lives easier! Evan

Re: uname -o does not exist on mac

2021-07-29 Thread Evan Hanson
Nice, thanks Lassi and Mario, applied. Evan

Re: [PATCH] Small chicken.h fix to make taglib compile on MinGW

2021-04-28 Thread Evan Hanson
roblem. LGTM, signoff attached. Evan >From 9dc7525a7458a48fd0667689d80027bd8d8eefe1 Mon Sep 17 00:00:00 2001 From: Vasilij Schneidermann Date: Mon, 19 Apr 2021 19:11:20 +0200 Subject: [PATCH] Cast the alloca result to make C++ on MinGW happy Signed-off-by: Evan Hanson --- chicken.h | 2 +- 1

Re: [PATCH] Quit compiling when an invalid import-Library declaration is encountered

2021-04-22 Thread Evan Hanson
Imagine that last email had a nice descriptive subject, like this one. Evan

[no subject]

2021-04-22 Thread Evan Hanson
210dc Mon Sep 17 00:00:00 2001 From: Evan Hanson Date: Fri, 23 Apr 2021 12:06:54 +1200 Subject: [PATCH] Quit compiling when an invalid import-Library declaration is encountered --- core.scm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/core.scm b/core.scm index

[PATCH 1/1] Fix typo'd procedure name in "emit-import-library" declaration handling

2021-04-21 Thread Evan Hanson
This is intended to check for a pair of strings when this declaration is used in its `(MODULENAME FILENAME)' form, but we currently use `string' instead of `string?' to check the second item, which will always trigger an error ("bad argument type"). --- core.scm | 2 +- 1 file changed, 1

[PATCH 0/1] Fix typo'd procedure name in "emit-import-library" declaration handling

2021-04-21 Thread Evan Hanson
Hi there, This is just the fix that was included in the earlier declarations changes, which megane rightly dropped from that patch since it wasn't really related. It makes this form of the "emit-import-library" declaration work again: (declare (emit-import-library (MODULE FILENAME))) Cheers,

[PATCH 2/2] Fall back to null when gathering components for "chicken-status -c" output

2021-04-19 Thread Evan Hanson
--- chicken-status.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chicken-status.scm b/chicken-status.scm index b9dfd759..1b79349f 100644 --- a/chicken-status.scm +++ b/chicken-status.scm @@ -143,7 +143,8 @@ ((c-include) (list (list 'c-include mode (cadr info

[PATCH 1/2] Include `c-object' components in "chicken-status -c" output

2021-04-19 Thread Evan Hanson
--- chicken-status.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chicken-status.scm b/chicken-status.scm index 7e3e73f7..b9dfd759 100644 --- a/chicken-status.scm +++ b/chicken-status.scm @@ -142,7 +142,8 @@ ((generated-source-file) (list (list

[PATCH 0/2] Fix error in "chicken-status -c" when c-object components are installed

2021-04-19 Thread Evan Hanson
Currently, listing components with chicken-status fails when any egg includes a `c-object'. To reproduce, just run: chicken-install tweetnacl chicken-status -c The first patch adds a case for `c-object' in the procedure that gathers installed egg components, and the second patch adds a

Re: FIXED [PATCH] Report more information for unresolved identifiers in modules

2021-04-18 Thread Evan Hanson
ine (foo) (+ bar) (lambda () (mac) (+ baz)) (+ fx+) (lambda () (+ baz) (mac))) (define (quux) (+ fx+)) ) Signed-off-by: Evan Hanson --- core.scm| 13 +++ modules.scm | 108 ++

Re: FIXED [PATCH] Report more information for unresolved identifiers in modules

2021-04-17 Thread Evan Hanson
Hi megane, This is really nice, I like it a lot because it shares a "look and feel" with the scrutiny messages. I'll take a look. Just one question right away, though, rather than "hint" can we say "suggestion"? The word hint to me makes it seem like the compiler knows the answer, but we are

[PATCH] Add `emit-types-file` declaration

2021-04-09 Thread Evan Hanson
--- NEWS| 3 +++ batch-driver.scm| 12 +++- core.scm| 12 ++-- manual/Declarations | 10 ++ 4 files changed, 30 insertions(+), 7 deletions(-) diff --git a/NEWS b/NEWS index 18c225c5..448fc1ac 100644 --- a/NEWS +++ b/NEWS @@ -45,6 +45,9 @@

[PATCH 0/1] Add `emit-types-file` declaration

2021-04-09 Thread Evan Hanson
Hi there, This small patch closes #1644. Thanks to Marco Maggi for suggesting this feature in a chicken-users thread from a while back. Cheers, Evan

[PATCH 1/1] Allow "-cached" flag with chicken-install for local egg file

2021-01-18 Thread Evan Hanson
--- chicken-install.mdoc | 2 +- chicken-install.scm | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/chicken-install.mdoc b/chicken-install.mdoc index 0bc1f788..c540e7e0 100644 --- a/chicken-install.mdoc +++ b/chicken-install.mdoc @@ -98,7 +98,7 @@ which has the same

[PATCH 0/1] Allow "-cached" flag with chicken-install for local egg file

2021-01-18 Thread Evan Hanson
Hi folks, I noticed that "chicken-install -cached" can be used to restrict chicken-install to only installing from the cache when you name eggs on the command line, but not when you it to install from a local egg file (i.e. by just running "chicken-install" without any egg name). But, I don't

Re: [PATCH] Fix #1725 by adding optional argument for scheme#log to types.db

2021-01-13 Thread Evan Hanson
On 2021-01-13 8:48, Peter Bex wrote: > Here's a fix for a small oversight in the types database. Nice, applied. Thanks Peter, I'll close #1725 now. Evan

Re: [PATCH 0/1] Print message while fetching eggs in chicken-install

2021-01-01 Thread Evan Hanson
On 2021-01-02 0:19, Mario Domenech Goulart wrote: > Thanks. I've pushed your patch. Thanks Mario, and happy new year! Evan

Re: [PATCH 0/1] Print message while fetching eggs in chicken-install

2021-01-01 Thread Evan Hanson
Hi folks, does anyone have an opinion on this? It's a small change and shouldn't take long to review. Cheers, Evan

[PATCH] Remove useless peek-char when read-string is called without read length

2020-12-27 Thread Evan Hanson
This call to `peek-char' was introduced by c78cdcd9, but it's useless and was probably only included in that commit by accident. The `read-string!/port` helper that's used just below to handle input already takes care of everything for us, no need to peek as well. --- extras.scm | 3 +-- 1 file

Re: [PATCH] Better error message in csi for unknown single-char options

2020-12-03 Thread Evan Hanson
Applied, thanks Felix! Evan

Re: New egg: SRFI-87: => in case clauses

2020-12-01 Thread Evan Hanson
2001 From: Evan Hanson Date: Sun, 29 Nov 2020 21:13:36 +1300 Subject: [PATCH] Add srfi-87 to list of built-in feature identifiers --- NEWS| 2 ++ eval.scm| 6 +++--- library.scm | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 87587eeb..50d90c

Re: New egg: SRFI-87: => in case clauses

2020-11-29 Thread Evan Hanson
tached change just adds a feature identifier for `srfi-87`, like John says. I think this is all that's needed, please have a look. Evan >From b03623dc6580ddb4465a27c170e2b5fbf67f3a49 Mon Sep 17 00:00:00 2001 From: Evan Hanson Date: Sun, 29 Nov 2020 21:13:36 +1300 Subject: [PATCH] Add srfi-87 to list

Re: [PATCH] Fix crash when accessing block header of immediate values in pretty-printer

2020-10-21 Thread Evan Hanson
On 2020-10-21 18:17, megane wrote: > Interesting.. How do you trigger this bug? Here's a simple way: #;1> (pp (block-ref 'aardvark 0)) Error: segmentation violation Call history: (pp (block-ref (quote aardvark) 0))

[PATCH] Fix crash when accessing block header of immediate values in pretty-printer

2020-10-21 Thread Evan Hanson
This fixes a segmentation fault when pretty-printing C_SCHEME_UNBOUND, since we reach into the value with C_block_header() in C_anypointerp() before checking for C_unboundvaluep(). This crashes, since unbound is an immediate value. In addition to moving the call to C_unboundvaluep() above the

Re: [PATCH] long lambda-info strings + C++ compilers

2020-09-24 Thread Evan Hanson
Makes sense to me, applied. Thanks Felix and Zilti! Evan

Re: [PATCH 1/2] Always treat bare colon as a symbol

2020-09-09 Thread Evan Hanson
On 2020-08-22 11:15, megane wrote: > Here's signed off version of Alice's patch. It all looks good to me. > > The new logic enabled some refactoring, which you might find to make the > logic a bit clearer. Good stuff, applied. Sorry for the slow review. Thank you both! Evan

[PATCH 0/1] Print message while fetching eggs in chicken-install

2020-09-02 Thread Evan Hanson
Hi folks, Here is a very simple one, I have a horrible internet connection so I've often noticed that there is a long pause without any output while chicken-install downloads egg sources, and this also confused someone I was helping to get started with CHICKEN today. So, I thought we should

[PATCH 1/1] Print message while fetching eggs in chicken-install

2020-09-02 Thread Evan Hanson
When running chicken-install there is often a long pause before any output while remote egg sources are downloaded. For new users this may be confusing as it seems like the program isn't doing anything. We currently print informational messages for building and installing eggs, so let's print one

[PATCH 1/1] Add support for `destination' specification in egg files

2020-08-26 Thread Evan Hanson
--- chicken-install.scm | 1 + egg-compile.scm | 25 +++-- egg-environment.scm | 1 + manual/Egg specification format | 13 +++-- 4 files changed, 28 insertions(+), 12 deletions(-) diff --git a/chicken-install.scm

[PATCH 0/1] Add support for `destination' specification in egg files

2020-08-26 Thread Evan Hanson
Hi folks, Someone noted on IRC that the `destination' specification for egg files is currently documented but not actually implemented. I also noticed this when trying to install a man page into /share a few weeks ago, and prepared the attached patch, but I never got around to sending it. So,

[PATCH] Avoid re-fetching bootstrapping tarball by using `wget --continue`

2020-07-30 Thread Evan Hanson
This just avoids downloading multiple (useless) copies of the snapshot archive when there is already a local copy by telling wget to "--continue" i.e. reuse the existing archive. --- scripts/bootstrap.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/bootstrap.sh

Re: [PATCH] read-lines: small refactoring and some tests

2020-07-29 Thread Evan Hanson
Hi Mario, LGTM, applied! I also added the new test file to distribution/manifest. All the best, Evan

[PATCH] Use 0666 as default mode for `file-open' (ticket #1698)

2020-05-31 Thread Evan Hanson
On 2020-05-13 17:58, Evan Hanson wrote: > I have created a change request and patch for this here: > > https://bugs.call-cc.org/ticket/1698 Does anyone have any objections to the above CR? If not, here's a patch that includes a NEWS entry for the change. Cheers, E

Re: Default file creation mode for core/scsh-process sets executable bit

2020-05-12 Thread Evan Hanson
Hello everyone, On 2020-05-09 8:42, Evan Hanson wrote: > On 2020-05-07 16:43, Vasilij Schneidermann wrote: > > Which of the following options would you prefer? > > > > 1. Patching scsh-process to pass the correct file mask when using > > `file-open`. > > 2. Pa

Re: [Chicken-hackers] [PATCH] Rework library loading to support conditional unit entry

2020-05-11 Thread Evan Hanson
Hi there, On 2018-11-12 9:08, Evan Hanson wrote: > On 2018-11-11 21:03, Peter Bex wrote: > > I think now's a good time to revisit this patch. Of course it no longer > > applies. Would you care to rebase it? > > Yeah, I will do so, thanks. You can just ignore it until

Re: Default file creation mode for core/scsh-process sets executable bit

2020-05-08 Thread Evan Hanson
On 2020-05-07 16:43, Vasilij Schneidermann wrote: > Which of the following options would you prefer? > > 1. Patching scsh-process to pass the correct file mask when using `file-open`. > 2. Patching posixunix.scm to calculate a better default. Option 2 seems preferable to me; it should at least

Re: [PATCH] Fix potential invalid argument error in `##sys#decompose-import'

2020-05-03 Thread Evan Hanson
On 2020-05-03 11:44, felix.winkelm...@bevuta.com wrote: > I'd love to apply your patches, but can you remove the "noprefix=true" option > from your .git/config, please? Apparently git am doesn't recognize this patch. Yes, apologies, I'll fix it for future patches. I didn't consider that Git might

[PATCH] Mark identifiers used to collect profiling info as `bound-to-procedure'

2020-05-02 Thread Evan Hanson
Calls to `##sys#register-profile-info' and `set-profile-info-vector!` are inserted into the program when profiling is enabled, so they should be marked as procedures so the resulting call nodes are marked as safe, just like we do for the `##sys#profile-entry' and `exit' procedures. ---

[PATCH] Fix potential invalid argument error in `##sys#decompose-import'

2020-05-02 Thread Evan Hanson
This fixes a small bug in `##sys#decompose-import' where "spec" (which is a list) is passed to the `warn' procedure rather than "name" (which is a symbol, as expected). This leads to an invalid argument error arising from `symbol->string', e.g. $ echo '(import (only (rename scheme (car first))

Re: [PATCH] force finalizers only if finalizers exist

2020-04-29 Thread Evan Hanson
On 2020-04-07 14:51, felix.winkelm...@bevuta.com wrote: > > > This patch disables the final GC for finalizer forcing at normal program > > > termination > > > if no finalizers are live as the GC is unnecessary in such cases. > > > > How about possible pending finalizers? > > You mean pending

Re: Exposing subsecond precision in current-seconds

2020-04-29 Thread Evan Hanson
On 2020-04-27 21:26, felix.winkelm...@bevuta.com wrote: > > - Add a new procedure in `(chicken time)` or `(chicken time posix)` that > > gives > > you both seconds and nanoseconds, be it as values, list, vector, ... Same > > Windows considerations as previously apply. > > Probably the best

Re: [PATCH] Fix the definition of srfi-6

2020-04-29 Thread Evan Hanson
Hi Phil, On 2020-04-23 15:53, Phil Hofer wrote: > There is a typo in the definition of SRFI 6: open-output-string is > erroneously defined as open-input-string. See the trivial attached > patch. There is indeed, thank you for the patch! > (First time submitting a patch to this mailing list; let

Re: [PATCH 0/1] Prevent excessive major gcs by preserving a decent amount of unused heap

2020-04-12 Thread Evan Hanson
On 2020-04-12 19:11, Peter Bex wrote: > What's the deal with the FAIL for knucleotide in both patched versions? Oh, that's because knucleotide needs srfi-69 and I didn't install it for the testing builds. Here's the comparison for that benchmark with srfi-69 installed. It's pretty similar to the

Re: [PATCH 0/1] Prevent excessive major gcs by preserving a decent amount of unused heap

2020-03-28 Thread Evan Hanson
Uh, sorry, this is in reference to megane's email from January 8. Forgot to fill in the "In-Reply-To"! Evan On 2020-03-29 10:10, Evan Hanson wrote: > Hi there, > > I've played around with this first patch a bit, and I think I've found a > way to apply the same techniqu

[PATCH 1/1] Prevent excessive major gcs by preserving a decent amount of unused heap

2020-03-28 Thread Evan Hanson
From: megane Signed-off-by: Evan Hanson --- manual/Using the compiler | 2 ++ runtime.c | 11 +-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git manual/Using the compiler manual/Using the compiler index fd656362..7a96920a 100644 --- manual/Using

[PATCH 0/1] Prevent excessive major gcs by preserving a decent amount of unused heap

2020-03-28 Thread Evan Hanson
Hi there, I've played around with this first patch a bit, and I think I've found a way to apply the same technique without complicating the logic in C_reclaim(). Attached is a sign-off of megane's patch that introduces the same min-free requirement, but only at the point where reallocations are

Re: [PATCH] remove use of "and" in types.db

2020-03-27 Thread Evan Hanson
Ooh, good find. Applied! Evan

Re: [PATCH] use correct defaults file when updating module db during installation

2020-03-25 Thread Evan Hanson
Makes sense, applied. Thanks Felix! Evan

Re: [PATCH] Add missing build dependencies to targets in makefile

2020-03-24 Thread Evan Hanson
This has been applied to master. Thanks again Jani!

[PATCH] Implement platform autodetection when possible

2020-03-09 Thread Evan Hanson
you want to, but the README examples no longer mention it. Signed-off-by: Evan Hanson --- GNUmakefile | 4 ++- Makefile.detect | 84 +++ NEWS | 5 +++ README| 38 +--- distribution/manif

Re: [PATCH] Use intermediate variable for exit status in posixunix.scm

2020-03-01 Thread Evan Hanson
On 2020-03-01 16:28, felix.winkelm...@bevuta.com wrote: > This is needed on TCC and newer versions of GCC, it seems. Applied.

Re: [PATCH] Add missing build dependencies to targets in makefile

2020-02-29 Thread Evan Hanson
:21:58 +0200 Subject: [PATCH] Add missing build dependencies to targets in makefile Add dependencies between * scheme source files, * chicken shared library and module import libraries, * chicken-do and C headers. Signed-off-by: Evan Hanson --- rules.make |

Re: [PATCH] Fix compilation issue in 5.2.0rc1

2020-01-18 Thread Evan Hanson
On 2020-01-17 11:35, Peter Bex wrote: > Sven confirmed that this patch fixes the issue. His code now compiles > and also works as expected. > > I think the solution is a bit hacky, but I don't know of a better way > to do this. Suggestions welcome! Hmmm, we could modify the procedures in

Re: Time to make a 5.2.0 release candidate?

2019-12-28 Thread Evan Hanson
Hi Peter, On 12/28/19 4:42 PM, Peter Bex wrote: I think we're about ready to start the process for a 5.2.0 release. What do you think? Should we wait for the eggs from #1655 to be fixed? What about the plaform auto-detection patch? IMO we should try to fix the eggs but wait until after a

Re: [PATCH 3/3] Let scrutinizer infer types for foreign types with retconv/argconv given

2019-12-27 Thread Evan Hanson
On 2019-12-26 15:51, megane wrote: > It would be ideal if we could add some bits of type information and let > the scrutinizer infer the rest. I think that would need some thought, > and/or experimentation. > > In these patches I dropped the annotations that added no information the > scrutinizer

Re: [PATCH 3/3] Let scrutinizer infer types for foreign types with retconv/argconv given

2019-12-25 Thread Evan Hanson
Hi megane, happy holidays! A quick question about this -- ought the scrutinizer try to improve the specificity of the ##core#the annotation, rather than having annotate-foreign-procedure skip emitting it entirely? ISTR it doesn't even look at the types in ##core#the nodes, but maybe it should?

[PATCH] Add redact-gensyms and output files to testclean target

2019-12-11 Thread Evan Hanson
Previously, the "testclean" target would leave a few files lying around: the redact-gensyms executable that's used to iron out unique identifiers in the tests, and the output files it produces. This commit just makes sure those files are removed when `make testclean' is run. --- rules.make | 4

Re: [PATCH] Fix #1649 by using '* as return value type if foreign type has a retconv procedure

2019-11-30 Thread Evan Hanson
Hi Peter, that makes sense, this is a good fix for now. Thanks, and thank you megane for finding this issue. Evan signature.asc Description: PGP signature

Re: [PATCH] Fix too small memory allocations

2019-11-26 Thread Evan Hanson
ultimately call C_bignum1, which needs 5 words. Signed-off-by: Evan Hanson --- c-platform.scm | 8 ++-- library.scm| 4 ++-- srfi-4.scm | 4 ++-- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/c-platform.scm b/c-platform.scm index 61a4ac87..27fdb65d 100644 --- a/c

Re: [PATCH] Also optimize case-lambda using rest-cdr mechanism (#1623)

2019-11-23 Thread Evan Hanson
Hi Peter, On 2019-11-21 17:16, Peter Bex wrote: > The attached patch simply adds another core form ##core#rest-length which > is optimized away to check the "c" argument in the C code which indicates > the length of the argvector instead of taking the length of the rest list > variable. I had a

Re: [PATCH] csc: -c and multiple input files

2019-11-23 Thread Evan Hanson
On 2019-11-19 11:54, felix.winkelm...@bevuta.com wrote: > Attached is a patch for handling the case given in #1655 in a less > confusing way (by signalling an error). Makes sense to me, thanks Felix. Evan signature.asc Description: PGP signature

Re: [PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows

2019-11-23 Thread Evan Hanson
On 2019-11-22 19:16, Peter Bex wrote: > On Mon, Nov 11, 2019 at 08:57:11PM +0100, Peter Bex wrote: > > I actually prefer it the "cd /d" way, because then we can't accidentally > > forget to introduce this elsewhere: we can just call cd-command and it > > will work on Windows if it works on UNIX.

Re: [PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows

2019-11-11 Thread Evan Hanson
On 2019-11-11 13:57, Lassi Kortela wrote: > > > The fix is to first switch drives, then run cd. > > `cd /d c:\foo` can be used to switch the drive and the directory both in one > command. > Oh, that's good to know, thanks Lassi. Peter, do you think it's worth switching to use this flag

Re: [PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows

2019-11-11 Thread Evan Hanson
Hi Peter, On 2019-11-09 17:15, Peter Bex wrote: > I had a look at #1647 and the fix seems to me to be pretty > straightforward. The build.bat which chicken-install creates > contains a "cd" command, but on Windows, cd won't change to > the corresponding drive, so when we then try to compile the

Re: [Chicken-hackers] [PATCH] Print more information about why an identifier cannot be exported

2019-10-19 Thread Evan Hanson
On 2019-10-19 10:23, megane wrote: > This doesn't say why the abbreviation cannot be exported. As a beginner > I'm left wondering that maybe there's some strange reason, but the > compiler is not telling it to me. Good point, thanks for the better suggestions. > - Warning: Cannot export

Re: [Chicken-hackers] [PATCH] Print more information about why an identifier cannot be exported

2019-10-18 Thread Evan Hanson
Hi megane, That's a nice improvement, good idea. What do you think of these wordings for the warning messages? I think they read a bit more clearly. Warning: In module `mod', type abbreviation `a-type-alias' cannot be exported. Warning: In module `mod', inlined function

Re: [Chicken-hackers] [PATCH] Fix how chicken-install handles server errors and add redirect support

2019-09-28 Thread Evan Hanson
Seems to work, thanks Peter. I've applied both. Cheers, Evan signature.asc Description: PGP signature ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers

Re: [Chicken-hackers] [PATCH] Fix #1294 by mentioning in the docs that define-record-printer is not a definition

2019-09-14 Thread Evan Hanson
Hi Peter, On 2019-09-14 15:28, Peter Bex wrote: > I made a few small tweaks to the patch, see attachment. The types.db > entry was syntactically invalid so I fixed that, and I've added checks > that the argument to set-record-printer! is a symbol (the original > macro contains that check as

Re: [Chicken-hackers] [PATCH] Replace C_u_i_zerop with inline version

2019-09-11 Thread Evan Hanson
On 2019-09-04 12:38, felix.winkelm...@bevuta.com wrote: > This patch replaces the use of C_u_i_zerop with an inline variant. > The new version has been renamed for binary compatibility, the > old version is deprecated. Looks good to me, pushed! Evan

Re: [Chicken-hackers] R7RS .sld library imports

2019-09-01 Thread Evan Hanson
Hi Lassi, On 2019-08-29 15:51, Lassi Kortela wrote: > How much work would it be to support R7RS .sld imports, such that > > (import (foo bar baz)) > > loads a (define-library ...) form from "{root}/foo/bar/baz.sld" for the > first matching {root} in the load path? This appears to be the

Re: [Chicken-hackers] [PATCH] Fix #1470 and unignore clean/pure declarations

2019-08-26 Thread Evan Hanson
Makes sense to me, applied. This should improve scrutiny when running csc with the default options, too. Cheers, Evan ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers

Re: [Chicken-hackers] [PATCH] Fix #1294 by mentioning in the docs that define-record-printer is not a definition

2019-08-14 Thread Evan Hanson
On 2019-08-13 22:16, Evan Hanson wrote: > On 2019-07-12 10:45, Peter Bex wrote: > > On Fri, Jul 12, 2019 at 08:29:58PM +1200, Evan Hanson wrote: > > > As a sidenote, this issue also applies to `define-reader-ctor', and > > > perhaps others; I didn't review the lot.

Re: [Chicken-hackers] [PATCH] Fix #1294 by mentioning in the docs that define-record-printer is not a definition

2019-08-13 Thread Evan Hanson
On 2019-07-12 10:45, Peter Bex wrote: > On Fri, Jul 12, 2019 at 08:29:58PM +1200, Evan Hanson wrote: > > In any case, I think we should try to address the issue one way or the > > other rather than keep a potential pitfall around. If we don't make it a > > "real" (

Re: [Chicken-hackers] [PATCH 1/1] Fix csi's "report" feature and add guard for `keyword-style' parameter

2019-07-27 Thread Evan Hanson
On 2019-06-29 12:06, Peter Bex wrote: > We could extend this check to ensure it's one of the three recognised > styles, but maybe that's overkill? It looks like if you put any other keyword in there it falls back to the portable style, so I personally think it's OK to leave it alone. Cheers,

[Chicken-hackers] [PATCH] Handle import libraries with static linkage egg property

2019-07-27 Thread Evan Hanson
Hi there, On 2019-05-29 11:39, ko...@upyum.com wrote: > felix.winkelm...@bevuta.com wrote: > > > On 2019-05-07 7:45, Evan Hanson wrote: > > > > On 2019-05-06 13:04, ko...@upyum.com wrote: > > > > > I don't think that patch is r

Re: [Chicken-hackers] [PATCH] Fix #1422 by always stopping on the first list that's exhausted

2019-07-24 Thread Evan Hanson
LGTM, applied. Thanks Peter. Evan ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers

Re: [Chicken-hackers] [PATCH] Fix #1294 by mentioning in the docs that define-record-printer is not a definition

2019-07-12 Thread Evan Hanson
On 2019-07-12 10:45, Peter Bex wrote: > > In any case, I think we should try to address the issue one way or the > > other rather than keep a potential pitfall around. If we don't make it a > > "real" (i.e. fake) definition, could we at least introduce a new name > > and encourage its use? Perhaps

Re: [Chicken-hackers] [PATCH] Fix #1625 and add srfi-88 module plus feature identifier

2019-07-12 Thread Evan Hanson
Hi Peter, Very nice work, I've pushed these. Thanks for the detailed explanation. On 2019-06-29 17:10, Peter Bex wrote: > The second patch completes SRFI-88 support by registering a module > for it and adding the feature identifier (which I think was just an > oversight). Strictly speaking, we

Re: [Chicken-hackers] [PATCH] Fix #1294 by mentioning in the docs that define-record-printer is not a definition

2019-07-12 Thread Evan Hanson
On 2019-06-30 19:25, Peter Bex wrote: > I had another look at #1294 and decided that, while we *could* fake the > record type printer as a definition by wrapping it in a (define) call > with a gensym, I think it doesn't make much sense. This actually makes good sense to me. Why don't you like

Re: [Chicken-hackers] [PATCH] Fix memory-statistics

2019-07-03 Thread Evan Hanson
Applied, thanks megane! Evan ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers

  1   2   3   4   5   6   7   8   >