Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-18 Thread Felix
From: Florian Zumbiehl fl...@florz.de Subject: Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts Date: Mon, 18 Mar 2013 11:50:46 +0100 Hi, On Mar 17, 2013, at 1:58 AM, Florian Zumbiehl wrote: If you cannot be sufficiently sure that your approach is correct to be willing

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-17 Thread Jörg F . Wittenberger
On Mar 17 2013, Florian Zumbiehl wrote: Somehow, this feels to me like you are applying test driven development techniques to concurrency correctness. Are you sure that your reasoning is correct and reliable and future-proof? Are the assumptions you make about the compiler true now for sure and

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-17 Thread Jim Ursetto
On Mar 17, 2013, at 1:58 AM, Florian Zumbiehl wrote: If you cannot be sufficiently sure that your approach is correct to be willing to build a full fix on it without testing first, I would consider that a sign that the approach is too fragile to rely on, at least without a good reason. I

[Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-16 Thread Florian Zumbiehl
Add (declare (disable-interrupts)) to tcp so that errno doesn't get changed at inappropriate points during execution. --- I don't really have a clue whether this is the correct way to do it, but the code that was breaking before is not breaking anymore with this patch applied ... tcp.scm |1

Re: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts

2013-03-16 Thread Felix
From: Florian Zumbiehl fl...@florz.de Subject: [Chicken-hackers] [PATCH 1/2] tcp: disable interrupts Date: Sat, 16 Mar 2013 17:56:41 +0100 Add (declare (disable-interrupts)) to tcp so that errno doesn't get changed at inappropriate points during execution. --- I don't really have a clue