Re: [PATCH] make chicken-install cache depend on PROGRAM_PREFIX/SUFFIX

[Peter Bex]

On Thu, Apr 15, 2021 at 11:05:36AM +0200, felix.winkelm...@bevuta.com wrote:
> A patch by alicemaz, see #1713.

Thanks, pushed.

Cheers,
Peter


signature.asc
Description: PGP signature

Re: [PATCH] make chicken-install cache depend on PROGRAM_PREFIX/SUFFIX

[Peter Bex]

On Thu, Apr 15, 2021 at 01:47:07PM +, Diego wrote:
> I wonder if it makes more sense to cache by (chicken-version) instead. For 
> example, is there a reason that two chicken installs with different 
> prefix/suffix shouldn't share the cache if their version were the same?

They may have different compiler options specified, so one might for
example be an efficient version and the other might have DEBUGBUILD=1.

Or one might be configured to build with a cross-compiler and the other
for the current platform.

Cheers,
Peter


signature.asc
Description: PGP signature

Re: [PATCH] make chicken-install cache depend on PROGRAM_PREFIX/SUFFIX

[Diego]

I wonder if it makes more sense to cache by (chicken-version) instead. For 
example, is there a reason that two chicken installs with different 
prefix/suffix shouldn't share the cache if their version were the same?

On the other hand, I see the point that different installs explicitly 
(pre|suf)fixed differently by the user were meant to be separated.

- Diego

[PATCH] make chicken-install cache depend on PROGRAM_PREFIX/SUFFIX

[felix . winkelmann]

A patch by alicemaz, see #1713.


felix


From b6b56495a686b6d774d94232d29cfdb56176cec1 Mon Sep 17 00:00:00 2001
From: felix 
Date: Thu, 15 Apr 2021 11:02:16 +0200
Subject: [PATCH] Use program name if chicken-install as cache directory name.
 This patch weas proposed by alicemaz (see #1713).

Signed-off-by: felix 
---
 egg-environment.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/egg-environment.scm b/egg-environment.scm
index 2256e696..0ece937c 100644
--- a/egg-environment.scm
+++ b/egg-environment.scm
@@ -43,6 +43,7 @@ EOF
 (define cross-chicken (feature? #:cross-chicken))
 (define binary-version (foreign-value "C_BINARY_VERSION" int))
 (define major-version (foreign-value "C_MAJOR_VERSION" int))
+(define chicken-install-program (foreign-value "C_CHICKEN_INSTALL_PROGRAM" c-string))
 
 (define default-cc (foreign-value "C_TARGET_CC" c-string))
 (define default-cxx (foreign-value "C_TARGET_CXX" c-string))
@@ -121,4 +122,4 @@ EOF
   (or (get-environment-variable "CHICKEN_EGG_CACHE")
   (make-pathname (or (system-cache-directory)
  (current-directory))
- "chicken-install")))
+ chicken-install-program)))
-- 
2.24.2