Re: [Chicken-hackers] [PATCH] Improve hygiene of FFI macros

2019-05-06 Thread kooda
Peter Bex wrote: > Attached is an updated version of my initial patch but without that one > patch hunk that broke canonicalize-expression. This looks good, I’ve applied it. ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org

Re: [Chicken-hackers] [PATCH] Improve hygiene of FFI macros

2019-04-09 Thread Peter Bex
On Tue, Apr 09, 2019 at 12:48:16PM +0200, Peter Bex wrote: > The patch is somewhat large but straightforward. It replaces all uses of > just "quote" (via the single quote character) to "##core#quote" Hi all, This patch contains one bug; in canonicalize-expression, I replaced a quote by

[Chicken-hackers] [PATCH] Improve hygiene of FFI macros

2019-04-09 Thread Peter Bex
Hi all, I had a quick look at #1346 (which I haven't fixed yet) but then quickly noticed that define-external expands into "define" in an unhygienic way. You can notice this if you have a module with an import of ONLY (chicken foreign) but not scheme. Of course this is not a very common thing to