Re: uname -o does not exist on mac
Nice, thanks Lassi and Mario, applied. Evan
Re: uname -o does not exist on mac
On Sun, 18 Jul 2021 12:01:54 +0300 Lassi Kortela wrote: > Here's a small patch to silence a warning in `make` output on systems > where the `uname` command does not have the `-o` flag. > > diff --git a/Makefile.detect b/Makefile.detect > index 10d36545..9694b125 100644 > --- a/Makefile.detect > +++ b/Makefile.detect > @@ -19,7 +19,7 @@ else > > # Now we can use uname tests > uname_s:=$(shell uname) > -uname_o:=$(shell uname -o) > +uname_o:=$(shell uname -o 2>/dev/null) > > # Check for specific platforms > ifeq ($(uname_o),Msys) Thanks, Lassi. Attached is a git-formatted signed-off patch. All the best. Mario -- http://parenteses.org/mario >From d9ab2a823c1176f036818b76f0d38b7fffae4e6b Mon Sep 17 00:00:00 2001 From: Mario Domenech Goulart Date: Wed, 28 Jul 2021 21:51:54 +0200 Subject: [PATCH] Makefile.detect: uname -o does not exist on mac Silence a warning in `make` output on systems where the `uname` command does not have the `-o` flag. This patch was submitted by Lassi Kortela: https://lists.nongnu.org/archive/html/chicken-hackers/2021-07/msg00011.html Signed-off-by: Mario Domenech Goulart --- Makefile.detect | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.detect b/Makefile.detect index 10d36545..9694b125 100644 --- a/Makefile.detect +++ b/Makefile.detect @@ -19,7 +19,7 @@ else # Now we can use uname tests uname_s:=$(shell uname) -uname_o:=$(shell uname -o) +uname_o:=$(shell uname -o 2>/dev/null) # Check for specific platforms ifeq ($(uname_o),Msys) -- 2.20.1
Re: uname -o does not exist on mac
You should see if Chibi has the same problem, since it uses a very similar Makefile.detect. Chibi seems to avoid the problem by checking for the OSes without `uname -o` support before the OSes that require it. All the checks are chained together using "else if" so the first passing check causes the remaining ones to be skipped. https://github.com/ashinn/chibi-scheme/blob/f48312fad3bca50db2f66c7050a2c3bd27dafd82/Makefile.detect
Re: uname -o does not exist on mac
Thanks! You should see if Chibi has the same problem, since it uses a very similar Makefile.detect. On Sun, Jul 18, 2021 at 5:02 AM Lassi Kortela wrote: > Here's a small patch to silence a warning in `make` output on systems > where the `uname` command does not have the `-o` flag. > > diff --git a/Makefile.detect b/Makefile.detect > index 10d36545..9694b125 100644 > --- a/Makefile.detect > +++ b/Makefile.detect > @@ -19,7 +19,7 @@ else > > # Now we can use uname tests > uname_s:=$(shell uname) > -uname_o:=$(shell uname -o) > +uname_o:=$(shell uname -o 2>/dev/null) > > # Check for specific platforms > ifeq ($(uname_o),Msys) > >
uname -o does not exist on mac
Here's a small patch to silence a warning in `make` output on systems where the `uname` command does not have the `-o` flag. diff --git a/Makefile.detect b/Makefile.detect index 10d36545..9694b125 100644 --- a/Makefile.detect +++ b/Makefile.detect @@ -19,7 +19,7 @@ else # Now we can use uname tests uname_s:=$(shell uname) -uname_o:=$(shell uname -o) +uname_o:=$(shell uname -o 2>/dev/null) # Check for specific platforms ifeq ($(uname_o),Msys)
