Re: [Chicken-users] LevelDB bindings
Hi Caolan, and welcome :) Thanks for making this egg -- based on the README it looks very nice to use/well thought-out. One note: chicken-install expects the tests directory to be named tests, but your project has it under test instead. If that's not intentional you may want to rename it so your egg will run its tests when asked and benefit from salmonella's regular test runs. Let us know if you'd like to fix this before it's added to the coop. Otherwise, it installs/tests OK here. Cheers, Evan ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] LevelDB bindings
Thanks Evan, I've renamed the directory to 'tests'. Salmonella still complains about missing docs, not sure how to fix that. Caolan On 20 April 2014 14:23, Evan Hanson ev...@foldling.org wrote: Hi Caolan, and welcome :) Thanks for making this egg -- based on the README it looks very nice to use/well thought-out. One note: chicken-install expects the tests directory to be named tests, but your project has it under test instead. If that's not intentional you may want to rename it so your egg will run its tests when asked and benefit from salmonella's regular test runs. Let us know if you'd like to fix this before it's added to the coop. Otherwise, it installs/tests OK here. Cheers, Evan ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] LevelDB bindings
On 2014-04-20 14:33, Caolan McMahon wrote: Thanks Evan, I've renamed the directory to 'tests'. Salmonella still complains about missing docs, not sure how to fix that. salmonella checks the wiki for documentation, so that'll be fixed by creating http://wiki.call-cc.org/egg/leveldb. Anyway, I've added leveldb.release-info to the list and your egg should be available shortly. Cheers, Evan ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] LevelDB bindings
caolan.mcma...@gmail.com writes: Thanks Evan, I've renamed the directory to 'tests'. Salmonella still complains about missing docs, not sure how to fix that. Hi Caolan, As Evan’s already said, you’ll need to create the wiki page for leveldb (http://wiki.call-cc.org/eghttp://wiki.call-cc.org/eggs%20tutorial#documentationgref/4/leveldb). Since your readme is written in Markdown, check out my markdown-svnwiki egg. It shouldn’t have any problem converting your readme to the format that the wiki expects. If you have any problems, though, let me know. It’s a very new egg, and as far as I know I’m the only one who has used it, so having some feedback from another user would be appreciated :) https://wiki.call-cc.org/eggref/4/markdown-svnwiki -- Alex ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] LevelDB bindings
Thanks, I've updated the wiki. Alex: the output from the conversion seemed a little broken so I ended up converting by hand. Perhaps try running it on the README.md file yourself to see what went wrong? On 20 April 2014 15:25, Alex Charlton alex.n.charl...@gmail.com wrote: caolan.mcma...@gmail.com writes: Thanks Evan, I've renamed the directory to 'tests'. Salmonella still complains about missing docs, not sure how to fix that. Hi Caolan, As Evan’s already said, you’ll need to create the wiki page for leveldb (http://wiki.call-cc.org/eghttp://wiki.call-cc.org/eggs%20tutorial#documentationgref/4/leveldb). Since your readme is written in Markdown, check out my markdown-svnwiki egg. It shouldn’t have any problem converting your readme to the format that the wiki expects. If you have any problems, though, let me know. It’s a very new egg, and as far as I know I’m the only one who has used it, so having some feedback from another user would be appreciated :) https://wiki.call-cc.org/eggref/4/markdown-svnwiki -- Alex ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] LevelDB bindings
Thanks for testing it out, Caolan. I’m sorry that it wasn’t working better. I clearly could have pre-tested your readme for you. Version 0.1.2 of markdown-svnwiki fixes the bugs you were running into. caolan.mcma...@gmail.com writes: Thanks, I've updated the wiki. Alex: the output from the conversion seemed a little broken so I ended up converting by hand. Perhaps try running it on the README.md file yourself to see what went wrong? On 20 April 2014 15:25, Alex Charlton alex.n.charl...@gmail.com wrote: caolan.mcma...@gmail.com writes: Thanks Evan, I've renamed the directory to 'tests'. Salmonella still complains about missing docs, not sure how to fix that. Hi Caolan, As Evan’s already said, you’ll need to create the wiki page for leveldb (http://wiki.call-cc.org/eghttp://wiki.call-cc.org/eggs%20tutorial#documentationgref/4/leveldb). Since your readme is written in Markdown, check out my markdown-svnwiki egg. It shouldn’t have any problem converting your readme to the format that the wiki expects. If you have any problems, though, let me know. It’s a very new egg, and as far as I know I’m the only one who has used it, so having some feedback from another user would be appreciated :) https://wiki.call-cc.org/eggref/4/markdown-svnwiki -- Alex -- Alex ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] LevelDB bindings
Hey Caolan, And welcome to the Chicken community! Your leveldb eggs seems pretty well written, nice work! Not much to comment on, but I'll put down what I noted as I quickly browsed through the code. Have you looked at the bind egg? It may help you out with basic C++ bindings for things like class instantiation, methods and fields. In your leveldb.setup file, you can use capital -j and leave out the module name. In you call-with-db definition, you could probably do the same with less code using dynamic-wind. And a quick note on naming conventions. I noted you've got things like strings-slice, where the return value needs to be freed with delete-slice. Since that's just private api, I'm sure you'll get away with it. I wonder though, if there's a a way to indicate you need to be careful. Perhaps a % prefix or * postfix might be suitable. Or perhaps a call-with-slice convention that always deletes with dynamic-wind might be suitable? I don't know its performance properties, though. Same for check-status, which deletes its argument with delete-status. Perhaps a ! postfix, ie check-status!? I hope I can get to play around with leveldb and thus egg at some point! Thanks for your contribution! K. On Apr 20, 2014 3:00 PM, Caolan McMahon caolan.mcma...@gmail.com wrote: Hi all, I'm new to the list (and CHICKEN) *waves* I thought I'd have a go at writing an egg and put together some bindings to Google's LevelDB embedded key/value store. I've published it at https://github.com/caolan/chicken-leveldb Can someone please help me with getting it onto the egg index? I'd also appreciate any advice people have on coding style / egg layout etc. since I'm still getting the hang of this. Thanks, Caolan ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] LevelDB bindings
set-finalizer! Is with considering for memory management as well. On 20 Apr 2014 16:54, Kristian Lein-Mathisen kristianl...@gmail.com wrote: Hey Caolan, And welcome to the Chicken community! Your leveldb eggs seems pretty well written, nice work! Not much to comment on, but I'll put down what I noted as I quickly browsed through the code. Have you looked at the bind egg? It may help you out with basic C++ bindings for things like class instantiation, methods and fields. In your leveldb.setup file, you can use capital -j and leave out the module name. In you call-with-db definition, you could probably do the same with less code using dynamic-wind. And a quick note on naming conventions. I noted you've got things like strings-slice, where the return value needs to be freed with delete-slice. Since that's just private api, I'm sure you'll get away with it. I wonder though, if there's a a way to indicate you need to be careful. Perhaps a % prefix or * postfix might be suitable. Or perhaps a call-with-slice convention that always deletes with dynamic-wind might be suitable? I don't know its performance properties, though. Same for check-status, which deletes its argument with delete-status. Perhaps a ! postfix, ie check-status!? I hope I can get to play around with leveldb and thus egg at some point! Thanks for your contribution! K. On Apr 20, 2014 3:00 PM, Caolan McMahon caolan.mcma...@gmail.com wrote: Hi all, I'm new to the list (and CHICKEN) *waves* I thought I'd have a go at writing an egg and put together some bindings to Google's LevelDB embedded key/value store. I've published it at https://github.com/caolan/chicken-leveldb Can someone please help me with getting it onto the egg index? I'd also appreciate any advice people have on coding style / egg layout etc. since I'm still getting the hang of this. Thanks, Caolan ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
