[chromium-dev] Re: Sandbox Interception Design

2009-03-27 Thread Book'em Dano
I'd like to better understand how the interception mechanism works. Is it using IAT rewriting? On Mar 27, 2:18 pm, Ricardo Vargas wrote: > I guess we'll have to update the documentation with a few things that were > left behind. > In the mean time, do you have something specific in mind? > > On

[chromium-dev] Re: external DNS queries in tests

2009-03-27 Thread Darin Fisher
Great, thanks for doing this! (By the way, I had once upon a time filed http://code.google.com/p/chromium/issues/detail?id=2635 to track this issue.) -Darin On Fri, Mar 27, 2009 at 12:08 PM, Paweł Hajdan Jr. wrote: > I recently checked in a change after which making external DNS lookup > (direc

[chromium-dev] Re: Sandbox Interception Design

2009-03-27 Thread Evan Martin
Who wants to rubber-stamp http://codereview.chromium.org/55043 for me? :) On Fri, Mar 27, 2009 at 2:18 PM, Ricardo Vargas wrote: > I guess we'll have to update the documentation with a few things that were > left behind. > In the mean time, do you have something specific in mind? > > On Fri, Ma

Re: IMPORTANT: Re: [chromium-dev] Re: layout tests and bug triaging

2009-03-27 Thread Ojan Vafai
I would take this a step further actually. We just generally won't be able to compute useful statistics from the test runner. We'll only be able to give the total, raw numbers of fail/skip/pass/timeout/crash and we can subtract out the WONTFIX tests that we never intend to fix. But we won't have an

[chromium-dev] Re: Sandbox Interception Design

2009-03-27 Thread Ricardo Vargas
I guess we'll have to update the documentation with a few things that were left behind. In the mean time, do you have something specific in mind? On Fri, Mar 27, 2009 at 1:59 PM, Brett Wilson wrote: > > On Fri, Mar 27, 2009 at 1:50 PM, Book'em Dano > wrote: > > > > At the top of sandbox\src\int

[chromium-dev] Re: Views and Linux

2009-03-27 Thread Ben Goodger (Google)
After further discussion, the Linux team feels strongly that the best approach for building Google Chrome on Linux is to stay the course with a solution using gtk for layout, so that's what they'll do. As a refinement to this, there will not be any attempts to refactor views code to share with th

[chromium-dev] Re: Sandbox Interception Design

2009-03-27 Thread Brett Wilson
On Fri, Mar 27, 2009 at 1:50 PM, Book'em Dano wrote: > > At the top of sandbox\src\interception.h, it refers the reader to: > http://wiki/Main/ChromeSandboxInterceptionDesign. Does anyone know > where this document can be found? > > The sandbox info on > http://dev.chromium.org/developers/design

[chromium-dev] Sandbox Interception Design

2009-03-27 Thread Book'em Dano
At the top of sandbox\src\interception.h, it refers the reader to: http://wiki/Main/ChromeSandboxInterceptionDesign. Does anyone know where this document can be found? The sandbox info on http://dev.chromium.org/developers/design-documents/sandbox is too high level...I want to find out more detai

[chromium-dev] external DNS queries in tests

2009-03-27 Thread Paweł Hajdan Jr .
I recently checked in a change after which making external DNS lookup (directly or indirectly) will make the test fail (so it's really hard to ignore). By external I mean everything except 127.0.0.1 and localhost. I added that check to chrome_test_suite.h, so unit_tests are affected, as well as ui

[chromium-dev] Need to attach to chrome super early?

2009-03-27 Thread Dean McNamee
I was about to add a --browser-startup-dialog, because I wanted a chance to stop chrome as early as possible. This would have required changing chrome.exe, adding a flag, etc. Instead I peaked a bit at what currently happens, and I came up with this trick (Windows only). bash$ CHROME_CRASHED=1

[chromium-dev] buildbot to Linux: no gyp for you!

2009-03-27 Thread Steven Knight
Linux gyp conversion isn't happening tonight--stymied by an execution problem preventing building libwebcore.a on the buildbot slaves (but not on desktop systems). I've reverted the initial buildbot changes and will re-open the tree shortly once things have cycled green. As you were, --S

[chromium-dev] Re: [chromium-reviews] A quick fix for Issue 2215....

2009-03-27 Thread 坊野 博典
Hi Elliot, Thank you for your response and analysis. My UI test just calls the SimulateOSKeyPress() function to send a keyboard event to a test page which contains a onkeydown event handler, and GetActiveTabTitle() to retrieve the tab name. Anyway, I'm going to divide this change into a code chan