[chromium-dev] Re: new hunspell has tons of valgrind warnings... revert?

2009-08-03 Thread Dean McNamee
I've never seen valgrind have problems with memory mapped files. On Mon, Aug 3, 2009 at 1:14 AM, Brett Wilsonbre...@chromium.org wrote: On Sat, Aug 1, 2009 at 4:34 PM, Dan Kegeld...@kegel.com wrote: I suppose you could try running the hunspell test suite itself under valgrind.  Their README

[chromium-dev] Re: browser/sync is moving in

2009-08-03 Thread Maxim Katsev
That's awesome. The dev build you are talking about, it will be a fully functional version, right? Do you have any predictions for getting sync in beta channel? -- Max On Aug 1, 12:07 am, Tim Steele t...@chromium.org wrote: Hi! A bunch of us have been working on a feature to sync user data

[chromium-dev] Linking Failed by Conflict Class IDs in jumplist.cc

2009-08-03 Thread mht
Hi all, I have a link error when building Chromium source code, error message as below: uuid.lib(shguids2.obj) : error LNK2005: _CLSID_DestinationList already defined in browser.lib(jumplist.obj) uuid.lib(shguids2.obj) : error LNK2005: _CLSID_EnumerableObjectCollection already defined in

[chromium-dev] Re: Can someone compile this patch for me?

2009-08-03 Thread Yuzo Fujishima
Would try server help? http://dev.chromium.org/developers/try-server-usage Yuzo On Mon, Aug 3, 2009 at 11:05 AM, Anand Mistry akmis...@gmail.com wrote: Hi all, I don't have the resources (disk space + tools) to compile my patch under Windows and OSX, so can someone on this list quickly try

[chromium-dev] Chromium buildbot for unrelated projects

2009-08-03 Thread Felix Geisendörfer
Hey there, I just talked with m0 in #chromium and he said the chromium fork of buildbot might be usable for unrelated projects as well. I'm asking here because he said he's not a buildbot guru and some of you here would be better at answering that question. Thanks, -- Felix Geisendörfer aka

[chromium-dev] Re: gcc -fvisibility=hidden

2009-08-03 Thread asac
Not sure why my previous post didn't show up (so sorry if this is a double post): I had done something similar to this, using GCC pragma visibility for v8 instead of -fvisibility=hidden ... http://code.google.com/p/v8/issues/detail?id=411 --~--~-~--~~~---~--~~

[chromium-dev] The program 'chrome' received an X Window System error

2009-08-03 Thread Albert Bachand
Hello, I'm working on supporting multiple X displays (http://crbug.com/15781). I've modified process_singleton_posix.cc to forward the display name back to the host which then pushes it all the way to browser_window_gtk.cc and assigns the browser window to that display. That part seems to work,

[chromium-dev] Error building chromium revision 22144.

2009-08-03 Thread James Su
Hi, After sync to revision 22144, following error occurs when executing hammer: scons: Reading SConscript files ... KeyError: 'Default': File /usr/local/google/home/suzhe/chrome/src/build/SConstruct, line 2: SConscript('all_main.scons') File

[chromium-dev] Manager system in Cloud - Chromium based project

2009-08-03 Thread Wallace.Jvm
I would get support of the team's development chromium google for a opensource project based on it. I look forward questions about it. ^ ^ P.S.: use google tradutor. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View

[chromium-dev] Re: browser/sync is moving in

2009-08-03 Thread Caleb Eggensperger
The doc says: - Provide a web interface to access stored / synced bookmarks, likely via the docs.google.com doclist. What about google.com/bookmarks? Shouldn't be difficult -- toolbar syncs to there currently. On Fri, Jul 31, 2009 at 14:07, Tim Steele t...@chromium.org wrote: Hi! A

[chromium-dev] Re: browser/sync is moving in

2009-08-03 Thread Idan Avraham
[Resending from my @chromium.com address] Peter, Many thanks for the feedback. We are planning to use HTTPS for the sync traffic so that any sensitive information stored in bookmarks is protected when sent over the wire. Bookmarks are not going to be encrypted on the client before they are sent

[chromium-dev] I'm setting up my chromium account.

2009-08-03 Thread James Su
Hi, I'm so happy that I just got my chromium account, and going to rebuild my local source tree with writable svn repository. But I have some pending CLs in my old readonly source tree, so I'm wondering is it possible to migrate those CLs to a new source tree? Regards James Su

[chromium-dev] Re: V8 bindings are now fully upstreamed!

2009-08-03 Thread Evan R. Murphy
Thanks to all who worked on this, and congratulations on the success. Can somebody with the permissions please update How Chromium Displays Web Pages [1] to reflect these changes? From that doc: 'At the lowest level we have our WebKit port. This is our implementation of required

[chromium-dev] Re: Design Doc: out of process (v8) proxy resolving

2009-08-03 Thread Robert Shield
Really nice doc! An attempt at potentially helpful comments follows: Regarding the class naming in the Out of process design, the convention I've seen most often is to have FooHost classes run in the browser with Foo classes in child processes. Proxy resolver process / crashes - the document

[chromium-dev] Re: [linux, maybe mac] gcc -fvisibility=hidden

2009-08-03 Thread asac
fwiw, I had posted a all hidden discussion patch using GCC pragma visibility for v8 here: http://code.google.com/p/v8/issues/detail?id=411 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options,

[chromium-dev] Re: browser/sync is moving in

2009-08-03 Thread Idan Avraham
[Resending from my @chromium.com address] When we fully land the sync code (hopefully in the coming few weeks), developers will certainly be able to pass in an alternate sync server address via a command line flag and use that to develop their own sync server. The initial UI doesn't include an

[chromium-dev] src.chromium.org down?

2009-08-03 Thread Julian Harris
Hi guys I can't access src.chromium.org from the web or from svn -- let me know if there's anything I can do to help. Julian / Google UK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or

[chromium-dev] code coverage and browser_tests

2009-08-03 Thread Paweł Hajdan Jr .
Does code coverage run browser_tests? It seems that not. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

[chromium-dev] Re: Error building chromium revision 22144.

2009-08-03 Thread Paweł Hajdan Jr .
This should be fixed by now. If not, pass explicit --mode=Debug parameter to hammer. On Thu, Jul 30, 2009 at 23:18, James Su su...@chromium.org wrote: Hi, After sync to revision 22144, following error occurs when executing hammer: scons: Reading SConscript files ... KeyError: 'Default':

[chromium-dev] Re: I'm setting up my chromium account.

2009-08-03 Thread Paweł Hajdan Jr .
If you are using gcl, look into .svn/gcl_info directory. If you are using git cl, use git cl patch rietveld issue number. On Wed, Jul 29, 2009 at 21:56, James Su su...@chromium.org wrote: Hi, I'm so happy that I just got my chromium account, and going to rebuild my local source tree with

[chromium-dev] Re: The program 'chrome' received an X Window System error

2009-08-03 Thread Evan Martin
On Thu, Jul 30, 2009 at 4:36 PM, Albert Bachandalbe...@google.com wrote: I'm working on supporting multiple X displays (http://crbug.com/15781). I've modified process_singleton_posix.cc to forward the display name back to the host which then pushes it all the way to browser_window_gtk.cc and

[chromium-dev] Re: Manager system in Cloud - Chromium based project

2009-08-03 Thread Evan Martin
I cannot understand your message. On Thu, Jul 30, 2009 at 10:38 AM, Wallace.Jvmwallace@gmail.com wrote: I would get support of the team's development chromium google for a opensource project based on it. I look forward questions about it. ^ ^ P.S.: use google tradutor.

[chromium-dev] Re: src.chromium.org down?

2009-08-03 Thread Evan Martin
http://downforeveryoneorjustme.com/src.chromium.org On Fri, Jul 31, 2009 at 7:23 AM, Julian Harrisk...@google.com wrote: Hi guys I can't access src.chromium.org from the web or from svn -- let me know if there's anything I can do to help. Julian / Google UK

[chromium-dev] Re: Can someone compile this patch for me?

2009-08-03 Thread Jeremy Orlow
Only committers can access try servers. Luckily, as was mentioned in the thread, committers can send a change to a try server on your behalf when it's on codereview.chromium.org. On Sun, Aug 2, 2009 at 7:15 PM, Yuzo Fujishima y...@chromium.org wrote: Would try server help?

[chromium-dev] Re: I'm setting up my chromium account.

2009-08-03 Thread Mohamed Mansour
Hi, If your source contents don't change, you can just copy the gcl_info directory (chrome\src\.svn\gcl_info) and it will keep the change lists intact. If the source contents change after your new source tree, just upload them to code review and fetch them back in when you got your clean tree.

[chromium-dev] Re: I'm setting up my chromium account.

2009-08-03 Thread Jeremy Orlow
If I'm not on Windows, I use diff and patch. When on Windows, because I've never been able to get any version of patch to work reliably, I sometimes just sync the 2 repos to the same version and then simply copy the files across. Note that I've never tried the other suggestions, so they could

[chromium-dev] Re: The program 'chrome' received an X Window System error

2009-08-03 Thread Adam Langley
On Mon, Aug 3, 2009 at 9:38 AM, Evan Martine...@chromium.org wrote: If I had to guess I'd say it's probably coming from when we first start poking at X to display content we got from the renderer.  If you post which IPC messages happen around the time you crash, maybe we can guess more.

[chromium-dev] Re: new hunspell has tons of valgrind warnings... revert?

2009-08-03 Thread Wan-Teh Chang
On Sat, Aug 1, 2009 at 2:54 PM, Dan Kegeld...@kegel.com wrote: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/1671/steps/valgrind%20test:%20unit/logs/stdio introduces 26 new unintialized memory references and two leaks. That's a big enough batch

[chromium-dev] Re: I'm setting up my chromium account.

2009-08-03 Thread Paweł Hajdan Jr .
Your suggestions are good. They tell how to transfer file contents, and I also do it in similar way (when I don't have git available). The other suggestions tell how to transfer Rietveld CL metadata, so you can update same CL while working in the new working copy. On Mon, Aug 3, 2009 at 09:55,

[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-08-03 Thread Brett Wilson
On Fri, Jul 31, 2009 at 5:44 PM, Rahul Kuchhalkuch...@chromium.org wrote: I thought to:user and -cc:user would work in this case? Have you tried using that in Has the words on Filter edit screen? One problem with this is that it doesn't fix the case where people respond to the review mail via

[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

2009-08-03 Thread Jeremy Orlow
On Mon, Aug 3, 2009 at 10:11 AM, Brett Wilson bre...@chromium.org wrote: On Fri, Jul 31, 2009 at 5:44 PM, Rahul Kuchhalkuch...@chromium.org wrote: I thought to:user and -cc:user would work in this case? Have you tried using that in Has the words on Filter edit screen? One problem with

[chromium-dev] Re: V8 bindings are now fully upstreamed!

2009-08-03 Thread Dimitri Glazkov
Thanks for checking on this! I made the changes. :DG On Wed, Jul 29, 2009 at 3:30 PM, Evan R. Murphyevanrmur...@gmail.com wrote: Thanks to all who worked on this, and congratulations on the success. Can somebody with the permissions please update How Chromium Displays Web Pages [1] to

[chromium-dev] Pinned tabs and activity notification

2009-08-03 Thread Caleb Eggensperger
I'm not sure what the future/intent of the pin tab feature is, but I've been using it to pin some of my application-ey tabs (gmail, google reader, igoogle, etc) and one problem I've noticed is that it's impossible to tell if I've received an IM or new email in Gmail without checking. Normally I

[chromium-dev] Re: Temporarily disable tcmalloc in build

2009-08-03 Thread cpu
We need a better way to talk about this perf gain. I agree is 12% ops/ second in that particular set of benchmarks. My recollection is that we removed LFH because it was using too much memory. We need some form of normalized score based on memory usage. In other words 12% with 25% more memory

[chromium-dev] Re: Pinned tabs and activity notification

2009-08-03 Thread Evan Martin
On Mon, Aug 3, 2009 at 11:13 AM, Caleb Eggenspergercaleb...@gmail.com wrote: I'm not sure what the future/intent of the pin tab feature is, but I've been using it to pin some of my application-ey tabs (gmail, google reader, igoogle, etc) and one problem I've noticed is that it's impossible to

[chromium-dev] Re: browser/sync is moving in

2009-08-03 Thread Jeremy Orlow
That didn't take long: http://arstechnica.com/open-source/news/2009/08/google-reveals-plans-for-chrome-cloud-synchronization.ars :-) J On Sat, Aug 1, 2009 at 6:04 PM, Idan Avraham id...@chromium.org wrote: [Resending from my @chromium.com address] When we fully land the sync code (hopefully

[chromium-dev] automatic clobber of grit-generated headers on Windows

2009-08-03 Thread Paweł Hajdan Jr .
In http://src.chromium.org/viewvc/chrome?view=revrevision=22325 I added a hook (running only on Windows), which clobbers headers generated by grit when grd files are modified. It should workaround an issue with IncrediBuild, and reduce flakiness on the buildbots. Please notify me in case of any

[chromium-dev] Re: V8 bindings are now fully upstreamed!

2009-08-03 Thread Evan R. Murphy
You're welcome! Sorry for forgetting my footnote: [1] http://sites.google.com/a/chromium.org/dev/developers/design-documents/displaying-a-web-page-in-chrome Cheers, Evan On Aug 3, 12:24 pm, Dimitri Glazkov dglaz...@chromium.org wrote: Thanks for checking on this! I made the changes. :DG

[chromium-dev] Re: Manager system in Cloud - Chromium based project

2009-08-03 Thread Wallace Araujo
I have a opensource project in the Mozdev and I've problem with gecko and related. I'll change my project for google labs and implement this using others google-projects how the Chromium and GWT,if possible... I need help for Configuration browser. Awaiting response... thx! Wallace Araujo

[chromium-dev] Re: I'm setting up my chromium account.

2009-08-03 Thread James Su
Thanks for your suggestion. I just followed the second approach. Regards James Su 2009/8/4 Mohamed Mansour m0.interact...@gmail.com Hi, If your source contents don't change, you can just copy the gcl_info directory (chrome\src\.svn\gcl_info) and it will keep the change lists intact. If

[chromium-dev] Testing HTML5 Video tag in chromium

2009-08-03 Thread 王重傑
This has come up a bunch, so I think it warrants a post. If you're playing with the HTML5 video tag in a chromium build (ie. Daily builds, or your own builds from source), the only video codec enabled is Ogg/Vorbis. Thus, http://www.youtube.com/html5 isn't going to work. Please try a ogg/vorbis

[chromium-dev] Reviewer needed for OS X spelling panel CL

2009-08-03 Thread Paul Wicks
I've got a decent size CL to add support for the os x spellchecker's spelling panel to chromium and I need to get it reviewed. I would have pinkerton review it, but he's out this week. Anybody want to give it a shot (maybe somebody else from the mac team) and let me know what stupid thing's i've

[chromium-dev] Re: Linking Failed by Conflict Class IDs in jumplist.cc

2009-08-03 Thread 坊野 博典
Thank you for your report and sorry for your inconvenience. I'm going to rename the symbol names to avoid conflicts with VS2008. Regards, Hironori Bono E-mail: hb...@chromium.org. On Sat, Aug 1, 2009 at 12:57 PM, mhtmhsien.t...@gmail.com wrote: Hi all, I have a link error when building

[chromium-dev] Re: Make PostTask virtual?

2009-08-03 Thread Antoine Labour
On Mon, Aug 3, 2009 at 8:23 PM, Albert J. Wong (王重傑)ajw...@chromium.org wrote: I've noticed that most public functions on MessageLoop are non-virtual.  How bad would it be to make PostTask, and its variants, virtual?  Are the perf implications or similar that would be bad? I'd like to be able