Re: [chromium-dev] "make all" doesn't work.

"make chrome" works as expected, it builds out the chrome binary. But "make" or "make all" doesn't work at all. - James Su 2009/12/4 Craig Schlenter > Hi > > One known problem with the make build is that you sometimes have to > run it twice to rebuild the chrome target as the strings sometimes

Re: [chromium-dev] "make all" doesn't work.

Hi One known problem with the make build is that you sometimes have to run it twice to rebuild the chrome target as the strings sometimes don't get rebuilt properly but if make chrome does something, then in theory make/make all should have built that too. What does make chrome build that make al

Re: [chromium-dev] "make all" doesn't work.

Unfortunately, it doesn't work. Actually, "make" == "make all". - James Su 2009/12/4 Craig Schlenter > I think you don't need to specify a target to build everything i.e. > just type make and it should work. > > --Craig > > On Fri, Dec 4, 2009 at 7:44 AM, James Su wrote: > > Hi, > > I just s

Re: [chromium-dev] "make all" doesn't work.

I think you don't need to specify a target to build everything i.e. just type make and it should work. --Craig On Fri, Dec 4, 2009 at 7:44 AM, James Su wrote: > Hi, >   I just switched to use make to build chromium linux, but I found that > "make all" didn't work at all. It only told me: make: N

[chromium-dev] "make all" doesn't work.

Hi, I just switched to use make to build chromium linux, but I found that "make all" didn't work at all. It only told me: make: Nothing to be done for `all'. Though it works if I specify the target name explicitly, such as "make chrome". Is it a known issue of gyp? Or I missed something? - James

Re: [chromium-dev] Core Text

It looks like this had some negative perf issues: http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Perf%281%29/builds/6289/steps/page_cycler_intl2/logs/stdio http://build.chromium.org/buildbot/perf/mac-release-10.5/intl2/report.html?history=150 (my DEPS roll was 33776) I'm going

[chromium-dev] Re: [chromium-extensions] Extensions gallery open for uploads

Hi Anders, That's a pain, sorry about that. I've filed a bug and asked our gallery team to take a look at it, I'll let you know what they find. -Nick On Thu, Dec 3, 2009 at 12:37 PM, Anders Bergh wrote: > At least more than 24h. > > On Thu, Dec 3, 2009 at 16:06, Erik Kay wrote: > > There's u

[chromium-dev] buildbot failure in Chromium on Linux Builder (Views dbg), revision 33776

Automatically closing tree for "compile" on "Linux Builder (Views dbg)" http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28Views%20dbg%29/builds/5398 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Builder%20%28Views%20dbg%29 --=> Automatically clo

[chromium-dev] buildbot failure in Chromium on Linux Builder (ChromiumOS), revision 33775

Automatically closing tree for "compile" on "Linux Builder (ChromiumOS)" http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/931 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Builder%20%28ChromiumOS%29 --=> Automatically closi

[chromium-dev] buildbot failure in Chromium on Chromium XP, revision 33766

Automatically closing tree for "check deps" on "Chromium XP" http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/9003 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20XP --=> Automatically closing tree for "check deps" on "Chromium XP" <=-- Revi

[chromium-dev] buildbot failure in Chromium on Mac10.5 Tests, revision 33758

Automatically closing tree for "unit_tests" on "Mac10.5 Tests" http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/9314 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Mac10.5%20Tests --=> Automatically closing tree for "unit_tests" on "Mac10.5 Tests" <=

[chromium-dev] buildbot failure in Chromium on Webkit Linux, revision 33756

Automatically closing tree for "test_shell_tests" on "Webkit Linux" http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux/builds/14929 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Webkit%20Linux --=> Automatically closing tree for "test_shell_tests" on "Webkit L

[chromium-dev] buildbot failure in Chromium on Modules XP (dbg), revision 33750

Automatically closing tree for "net_unittests" on "Modules XP (dbg)" http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP%20%28dbg%29/builds/20036 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20XP%20%28dbg%29 --=> Automatically closing tree for "net_unitt

Re: [chromium-dev] gcl commit throwing SVN server error

If you're a committer, you should have recieved instructions on how to set up your client (it will have an svn rather than an http url) when you got your commit password. On Thu, Dec 3, 2009 at 3:51 PM, Zelidrag Hornung wrote: > How do I know if the repo is read-only? This is how my .gclient look

Re: [chromium-dev] gcl commit throwing SVN server error

Sounds like you're trying to commit to the read-only repo? On Thu, Dec 3, 2009 at 3:31 PM, Zelidrag Hornung wrote: > When I try to commit my change, I am getting following error there - any > ideas what might be causing this? >>gcl commit my_change > Presubmit checks took 1.7s to calculate. > Loa

[chromium-dev] gcl commit throwing SVN server error

When I try to commit my change, I am getting following error there - any ideas what might be causing this? >gcl commit my_change Presubmit checks took 1.7s to calculate. Loaded authentication cookies from C:\Users\zelidrag/.codereview_upload_cookies svn: Commit failed (details follow): svn: Serve

Re: [chromium-dev] Need a linux-views build buddy.

I filed http://crbug.com/29364 On Thu, Dec 3, 2009 at 2:45 PM, Mike Pinkerton wrote: > Yes, except it's down and hasn't worked in days. > > On Thu, Dec 3, 2009 at 5:44 PM, Jeremy Orlow wrote: >> Isn't "gcl try -b linux_view" what you want? >> >> On Thu, Dec 3, 2009 at 1:46 PM, Mike Pinkerton >

[chromium-dev] buildbot failure in Chromium on Modules XP (dbg), revision 33744

Automatically closing tree for "net_unittests" on "Modules XP (dbg)" http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP%20%28dbg%29/builds/20032 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20XP%20%28dbg%29 --=> Automatically closing tree for "net_unitt

[chromium-dev] buildbot failure in Chromium on Modules XP (dbg), revision 33741

Automatically closing tree for "net_unittests" on "Modules XP (dbg)" http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP%20%28dbg%29/builds/20030 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20XP%20%28dbg%29 --=> Automatically closing tree for "net_unitt

Re: [chromium-dev] Need a linux-views build buddy.

Yes, except it's down and hasn't worked in days. On Thu, Dec 3, 2009 at 5:44 PM, Jeremy Orlow wrote: > Isn't "gcl try -b linux_view" what you want? > > On Thu, Dec 3, 2009 at 1:46 PM, Mike Pinkerton > wrote: >> >> I've got a cl that builds fine on win/mac/linux but I'm afraid I could >> impact

Re: [chromium-dev] Need a linux-views build buddy.

The same is true of view_chromeos, FWIW. On Thu, Dec 3, 2009 at 5:45 PM, Mike Pinkerton wrote: > Yes, except it's down and hasn't worked in days. > > On Thu, Dec 3, 2009 at 5:44 PM, Jeremy Orlow wrote: >> Isn't "gcl try -b linux_view" what you want? >> >> On Thu, Dec 3, 2009 at 1:46 PM, Mike Pi

Re: [chromium-dev] Need a linux-views build buddy.

Isn't "gcl try -b linux_view" what you want? On Thu, Dec 3, 2009 at 1:46 PM, Mike Pinkerton wrote: > I've got a cl that builds fine on win/mac/linux but I'm afraid I could > impact views_linux. And, since there's no trybot, I have no way of > knowing until I actually check in and break it. > > T

[chromium-dev] Need a linux-views build buddy.

I've got a cl that builds fine on win/mac/linux but I'm afraid I could impact views_linux. And, since there's no trybot, I have no way of knowing until I actually check in and break it. That's where you come in! Would someone mind trying http://codereview.chromium.org/465005/show for me with l

Re: [chromium-dev] Re: Something smells weird on the buildbot

On Thu, Dec 3, 2009 at 7:33 PM, Nicolas Sylvain wrote: > > > On Thu, Dec 3, 2009 at 10:25 AM, Ojan Vafai wrote: >> >> On Thu, Dec 3, 2009 at 10:21 AM, Dimitri >> Glazkov  wrote: >>> >>> How about we turn red for unexpected crashiness? >> >> Makes sense to me. We can just not retry tests that unex

[chromium-dev] Download Manager and double notification on download complete

I'm working on some UI related to downloads, and I need a clean indication that a download is finished. Not just finished but Finished. And I've found we're getting two notifications: one before auto-opening happens, and one after it happens. If we look at DownloadManager::ContinueDownloadFinished

Re: [chromium-dev] Core Text

Hi Jeremy, My next roll will be to 51642 (in progress). I'll ping you when it lands so you can keep an eye on it too. -atw 2009/12/3 Jeremy Moskovich > Hi Drew & Albert, > > I picked your names off the WebKit sheriff calendar. > > I've landed a change to switch the Mac port over from ATSUI->Co

[chromium-dev] Interested in HTML5 audio and video?

I've written a document describing our current implementation of the and tags: http://sites.google.com/a/chromium.org/dev/developers/design-documents/video If you're interested in helping out, feel free to reply to me privately or take a look at our HelpWanted

[chromium-dev] buildbot failure in Chromium on Modules XP (dbg), revision 33707

Automatically closing tree for "net_unittests" on "Modules XP (dbg)" http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP%20%28dbg%29/builds/20009 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20XP%20%28dbg%29 --=> Automatically closing tree for "net_unitt

Re: [chromium-dev] webcore_bindings target builds slowly

I filed a bug on this, including a proposal for how to improve build times by breaking DerivedSourcesAllInOne into four pieces (with a workaround to keep it building all-in-one for configurations that require that.) https://bugs.webkit.org/show_bug.cgi?id=32128 I'll do it, if people think i

[chromium-dev] Re: Something smells weird on the buildbot

On Thu, Dec 3, 2009 at 10:25 AM, Ojan Vafai wrote: > On Thu, Dec 3, 2009 at 10:21 AM, Dimitri > Glazkov  wrote: >> >> How about we turn red for unexpected crashiness? > > Makes sense to me. We can just not retry tests that unexpectedly crash. I'll make this change if we have a consensus. Do we?

[chromium-dev] Re: Something smells weird on the buildbot

On Thu, Dec 3, 2009 at 10:25 AM, Ojan Vafai wrote: > On Thu, Dec 3, 2009 at 10:21 AM, Dimitri Glazkov > wrote: > > How about we turn red for unexpected crashiness? >> > > Makes sense to me. We can just not retry tests that unexpectedly crash. > > On Thu, Dec 3, 2009 at 10:09 AM, Dirk Pranke wr

[chromium-dev] Re: Something smells weird on the buildbot

On Thu, Dec 3, 2009 at 10:21 AM, Dimitri Glazkov wrote: > How about we turn red for unexpected crashiness? > Makes sense to me. We can just not retry tests that unexpectedly crash. On Thu, Dec 3, 2009 at 10:09 AM, Dirk Pranke wrote: > On Thu, Dec 3, 2009 at 10:07 AM, Ojan Vafai wrote: > > T

[chromium-dev] Re: Something smells weird on the buildbot

On Thu, Dec 3, 2009 at 10:17 AM, Nicolas Sylvain wrote: >> >> Should unexpected flakiness turn the bot red? > > If it turns the bot red, then it defeats the purpose of that code. Might as > well not retry and mark it as FAIL. (which turns the tree red). Duh :) Makes sense. How about we turn red

[chromium-dev] Re: Something smells weird on the buildbot

On Thu, Dec 3, 2009 at 10:09 AM, Dimitri Glazkov wrote: > On Thu, Dec 3, 2009 at 10:07 AM, Ojan Vafai wrote: > > +chromium-dev as others who look at the waterfall might also be confused. > > On Thu, Dec 3, 2009 at 8:50 AM, Dimitri Glazkov > wrote: > >> > >> Sending out random people, because it'

[chromium-dev] Re: Something smells weird on the buildbot

On Thu, Dec 3, 2009 at 10:07 AM, Ojan Vafai wrote: > +chromium-dev as others who look at the waterfall might also be confused. > On Thu, Dec 3, 2009 at 8:50 AM, Dimitri Glazkov wrote: >> >> Sending out random people, because it's early :) >> >> There's a couple of things I see on the bot this mor

[chromium-dev] Re: Something smells weird on the buildbot

Our messages crossed in the ether ... On Thu, Dec 3, 2009 at 10:07 AM, Ojan Vafai wrote: > +chromium-dev as others who look at the waterfall might also be confused. > On Thu, Dec 3, 2009 at 8:50 AM, Dimitri Glazkov wrote: >> >> Sending out random people, because it's early :) >> >> There's a cou

[chromium-dev] Re: [chromium-extensions] Extensions gallery open for uploads

There's usually a few minutes of lag before the new version actually becomes available. How long did you wait? Erik On Thu, Dec 3, 2009 at 12:37 AM, Anders Bergh wrote: > On Mon, Nov 23, 2009 at 23:48, Aaron Boodman wrote: > > Hello all, > > > > I'm happy to announce that the developer area o

Re: [chromium-dev] Core Text

Hi Drew & Albert, I picked your names off the WebKit sheriff calendar. I've landed a change to switch the Mac port over from ATSUI->Core Text APIs on the WebKit tree at http://trac.webkit.org/changeset/51633 . If you see stability or performance issues on the next WebKit roll then feel free to r

[chromium-dev] Re: [chromium-extensions] Extensions gallery open for uploads

Did you try to unpublish and then publish the extension again and download? ☆PhistucK On Thu, Dec 3, 2009 at 10:37, Anders Bergh wrote: > On Mon, Nov 23, 2009 at 23:48, Aaron Boodman wrote: > > Hello all, > > > > I'm happy to announce that the developer area of our extensions > > gallery is n