Re: [chromium-dev] License implications on Chromium's design

2010-01-18 Thread Finnur Thorarinsson
Furthermore, the people on this list are developers who are not qualified to hand out legal advice. On Mon, Jan 18, 2010 at 15:13, Nico Weber tha...@chromium.org wrote: http://lmgtfy.com/?q=chromium+license First hit. On Mon, Jan 18, 2010 at 3:07 PM, Jerome Leclanche adys...@gmail.com

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

2009-12-10 Thread Finnur Thorarinsson
I wonder... should we show an infobar on startup when the sandbox is disabled? On Thu, Dec 10, 2009 at 21:38, John Abd-El-Malek j...@chromium.org wrote: We disable --single-process and --in-process-plugins on release Google Chrome builds to avoid the support headache that it causes. I think

[chromium-dev] Re: refactoring and git

2009-11-03 Thread Finnur Thorarinsson
Another option is to do one TBR commit where you just fork the file with no changes, then work again as normal. May I suggest using gcl instead for this changelist... Would that be possible? I don't like the idea of losing all the commit history of the file he's working on, just because git

[chromium-dev] Re: Fwd: Switching vs2008 to be preferred when present.

2009-10-29 Thread Finnur Thorarinsson
I was just about to reply and say the same thing (on Win 7). It would take me 2-3 seconds each time I step over a line. I couldn't use it anymore and switched back to VS 2005. Isn't the stepping speed affected by things like what you have in your Watch window and what conditional breakpoints

[chromium-dev] Re: Is that unimpossible to add a progress bar of page loading with webkit?

2009-10-09 Thread Finnur Thorarinsson
As I understand it, you are talking about adding an overall progress bar for page loading and showing the progress bar somewhere in the Chrome UI. If that is the case, then bear in mind that you need buy-in from the UX team before you add the UI element to the Chromium codebase. I know we left out

[chromium-dev] Re: Chrome Keyboard Access, opinions?

2009-10-08 Thread Finnur Thorarinsson
Maybe it's just me, but I don't see the point in making a toolbar as a whole focusable. The keyboard shortcut should put focus on the first element in the toolbar and tab should cycle focus from there. and when we press ALT+T+TAB ... I hope you mean ALT+T and then TAB because ALT+T+TAB is a

[chromium-dev] Re: detecting tabs using a lot of CPU?

2009-10-07 Thread Finnur Thorarinsson
Umm... shouldn't we be looking into why the tab is taking so much CPU? :) For example, back in April I saw a similar thing happen on Facebook and with WinDbg found that WebKit was simply running in an infinite loop. The WebKit team jumped on this and submitted a fix just 2 days after I reported

[chromium-dev] Re: Chrome Compile errors - Visual Studio 2005

2009-10-01 Thread Finnur Thorarinsson
The first thing I thought of when I read this was that you might not have all the prerequisites for building... Have you gone through this document and verified that? http://dev.chromium.org/developers/how-tos/build-instructions-windows As a data point I can tell you that most of the code

[chromium-dev] Re: Chrome Compile errors - Visual Studio 2005

2009-10-01 Thread Finnur Thorarinsson
Specifically, double-check that you have the right Platform SDK installed. On Thu, Oct 1, 2009 at 19:43, Finnur Thorarinsson fin...@chromium.orgwrote: The first thing I thought of when I read this was that you might not have all the prerequisites for building... Have you gone through

[chromium-dev] SVN hangs updating third_party/WebKit

2009-09-25 Thread Finnur Thorarinsson
At first I thought it was a fluke but now it just happened again. Is anyone else seeing this? I do a gclient sync and it takes forever, showing this output and looks hung: running 'svn update E:\code\src\third_party\WebKit --revision 27219' in 'E:\code' I wait and wait and wait and

[chromium-dev] Re: SVN hangs updating third_party/WebKit

2009-09-25 Thread Finnur Thorarinsson
that removing that folder once is enough, though I didn't try it more than once yet. On Fri, Sep 25, 2009 at 5:18 PM, Finnur Thorarinsson fin...@chromium.org wrote: At first I thought it was a fluke but now it just happened again. Is anyone else seeing this? I do a gclient sync and it takes forever

[chromium-dev] Re: [chromium-checkins] r25367 - in trunk/src: chrome/browser chrome/browser/chromeos chrome/browser/gtk chrome/browser/views chrome/browser/views/extensions chrome/browser/views/fram

2009-09-03 Thread Finnur Thorarinsson
Ah, ok. I'll clean this up in a followup CL. I'll get on it right away. Thanks for the tip! On Thu, Sep 3, 2009 at 14:24, James Hawkins jhawk...@chromium.org wrote: On Thu, Sep 3, 2009 at 1:58 PM, fin...@chromium.org wrote: Author: fin...@chromium.org Date: Thu Sep 3 13:58:01 2009 New

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-27 Thread Finnur Thorarinsson
It is only incredibly painful if you mix in the link in with other words in the middle of a sentence, like I had to do with the About box. If you, instead, have a link below the main text (like the mock shows) it is dead simple and easy. I don't see why you should avoid using Link in that case.

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-27 Thread Finnur Thorarinsson
Oh, I see. I thought you meant the link since Brett said I had done this for the About box (Now Aaron's code snippet makes more sense) :). I didn't have to do any bolding of text in the About box, but I can see you running into exactly the same problems I did with the link. There be dragons. I

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-26 Thread Finnur Thorarinsson
Yes, the views class Link is a specialization of the class Label, and it is responsible for handling hyperlinks. On Wed, Aug 26, 2009 at 15:32, Brett Wilson bre...@chromium.org wrote: +finnur who did this for the about box. Brett On Wed, Aug 26, 2009 at 2:15 PM, Aaron

[chromium-dev] Re: F5 Debug process

2009-07-03 Thread Finnur Thorarinsson
I had a similar problem on VS 2005, maybe it is the same as yours. Turned out VS was set to build everything as opposed to just building what the project depended on. Not sure how to do it in VS2008, but in VS 2005, under Tools \ Options, go to: Projects and Solutions \ Build and Run Make sure

[chromium-dev] Re: F5 Debug process

2009-07-03 Thread Finnur Thorarinsson
. Thanks for your hint, it was exactly what I was looking for to avoid the compilation of project tests(that are not necessary for me to debug chromium). On Jul 3, 2:04 pm, Finnur Thorarinsson fin...@chromium.org wrote: I had a similar problem on VS 2005, maybe it is the same as yours. Turned

[chromium-dev] Re: question about helpwanted items (how it works)

2009-06-25 Thread Finnur Thorarinsson
I wasn't suggesting we should add a UI in addition/instead of a keyboard modifier. Since there is no standard modifier you should do as Evan suggested an just pick one. We can always change it. On Thu, Jun 25, 2009 at 08:14, nakro yoav.zilberb...@gmail.com wrote: I agree, but no browser has a

[chromium-dev] Re: Using custom builds of chromium in a commercial setting

2009-06-24 Thread Finnur Thorarinsson
which is pretty much locked into a particular url (or set of urls) Thanks folks I'll take a closer look :) -cj. On Sat, Jun 20, 2009 at 5:22 PM, Finnur Thorarinsson fin...@chromium.org wrote: There might be a wiki page somewhere, but to start with, the Page menu has a Create application

[chromium-dev] Re: Using custom builds of chromium in a commercial setting

2009-06-20 Thread Finnur Thorarinsson
There might be a wiki page somewhere, but to start with, the Page menu has a Create application shortcuts menu item, which helps you create shortcuts for running web sites as applications. You can also use a command line flag, such as chrome.exe --app=http://your_url/ You can use that as a

[chromium-dev] Re: Any way to compile webkit faster

2009-06-10 Thread Finnur Thorarinsson
FWIW - There also is a setting in Developer Studio that specifies how many projects Visual Studio can build simultaneously. Maybe it is unrelated but I wonder if that is set to 1 or something for you? Tools \ Options \ Projects and Solutions \ Build and Run. I have a Quad Core and have this set

[chromium-dev] Collapsed view of our waterfall

2009-06-05 Thread Finnur Thorarinsson
It seems that every week I get around 2-3 people walking past my monitors asking Whoa! How did you get this cool view of the build tree waterfall?! What they are referring to is the *merged* view of Nicolas' awesome waterfall console view (the one that doesn't contain all the changelist

[chromium-dev] Re: how can i make sure i have the Exact copy as the trunk ?

2009-05-17 Thread Finnur Thorarinsson
I thought it was important to spell this out clearly to make sure there are no mistakes: The svn revert file command will revert any changes you have made to the file(s) you run it against. That may or may not be what you intended. If, on the other hand, you want to update the tree while

[chromium-dev] Request for comments: Feed preview work

2009-05-06 Thread Finnur Thorarinsson
I just wanted to give you heads up that soon it will be time for me to devote most of my time on the second part of the Feed handling support in Chrome, namely: Feed Previews ( http://dev.chromium.org/user-experience/feed-subscriptions). Consider this a request for your feedback, especially if

[chromium-dev] Re: Unpacking Extensions and the Sandbox

2009-05-01 Thread Finnur Thorarinsson
The issue with images is with themes, since they're displayed by the browser process. The issue with images is also an issue with PageActions, where we want to display icons (handed to us by an extension) inside the Omnibox. --~--~-~--~~~---~--~~ Chromium

[chromium-dev] Re: Problems with codereview website?

2009-04-25 Thread Finnur Thorarinsson
I saw some internal thread about a problem with the codereview site -- It indicated that it is actively being looked at. I don't know anything more than that, unfortunately, but hopefully it will be resolved soon. Sorry about the interruption. -F On Sat, Apr 25, 2009 at 20:16, Mohamed Mansour

[chromium-dev] Re: Not showing build number

2009-04-23 Thread Finnur Thorarinsson
I haven't checked the trunk build, but this looks like a bug to me. Looking at your about:version output, it seems the build number is missing there too -- see the space before close parenthesis after Developer Build. Can you file a bug? On Thu, Apr 23, 2009 at 07:48, Robert Dailey

[chromium-dev] Re: Compiling browser without compiling unit tests?

2009-03-31 Thread Finnur Thorarinsson
It worked for me in the past too - until I switched to my new machine and sync-ed to latest. :( On Tue, Mar 31, 2009 at 12:52, Adam Barth aba...@chromium.org wrote: On Tue, Mar 31, 2009 at 12:42 PM, Finnur Thorarinsson fin...@chromium.org wrote: It's not that simple. I think something

[chromium-dev] Re: Compiling browser without compiling unit tests?

2009-03-31 Thread Finnur Thorarinsson
in Visual Studio. (shrugs) No idea on your problem with the unit_tests. Maybe you should be doing a 'gclient sync' from the Chrome directory and deleting the subdirectory Debug (and rebuilding). On Tue, Mar 31, 2009 at 13:00, Finnur Thorarinsson fin...@chromium.orgwrote: It worked for me

[chromium-dev] Re: Chromium App Executables Disk Layout

2009-03-29 Thread Finnur Thorarinsson
It would be nice to be able to leverage our multi-process architecture and at least start using the new binaries for any new tabs that are created. But, that's a different can of worms, I guess. On Sun, Mar 29, 2009 at 14:31, Jim Roskind j...@chromium.org wrote: Perhaps we need to think about

[chromium-dev] Re: Profile Corruption, cause?

2009-03-05 Thread Finnur Thorarinsson
I suspect this is like crashes due to memory corruption: It won't do much good to stare at the call stack at the time corruption was detected; we need to know the stack at the time corruption occurred (assuming this is Chrome that is corrupting the profile). For memory corruptions we have gflags;

[chromium-dev] Re: VS solution takes forever to load

2009-02-19 Thread Finnur Thorarinsson
Dang. Erik beat me to it. I just found another person stating the same fix. :) Instead, I'll point out that what Paul is seeing is not unusual, it takes up to 2 and a half minute on my machine to shut down Visual Studio completely and it appears to hang most of that time. I never shoot it down

[chromium-dev] Re: Issues Assigned To Me show fixed bugs?

2008-12-04 Thread Finnur Thorarinsson
You have bugs in your code? ;) But no - In all seriousness, I second that. I think that query should filter out bugs marked as fixed, duplicate, and wont-fix so people don't have to do it manually. On Thu, Dec 4, 2008 at 07:15, Mike Pinkerton [EMAIL PROTECTED] wrote: Unlike any other bug

[chromium-dev] Re: Chromium auto-updating feature

2008-12-03 Thread Finnur Thorarinsson
We don't support auto-updates for Chromium, only Google Chrome. 2008/12/3 Matías [EMAIL PROTECTED] Hi, I've noticed that since yesterday, Chromium builds have a working checking for updates in the about window. I'm wondering how is this supposed to work, since It doesn't seems to correctly

[chromium-dev] Re: Chromium auto-updating feature

2008-12-03 Thread Finnur Thorarinsson
The About box calls out to a COM server hosted by GoogleUpdate. I'm guessing that this code is alive and well in Chromium, and will 'just work' if Google Chrome is installed (so GoogleUpdate is running) I don't think that's the case here. The About box in Chromium will show error 1 before

[chromium-dev] Re: Accessibility design doc

2008-12-02 Thread Finnur Thorarinsson
Just a couple of comments after skimming through the document... Find In Page * - *Issue* - Edit box reported as role client. - *Issue* - Label to the edit box? I don't understand. You mentions these kinds of issues in various places but don't describe what the issues are. What is the

[chromium-dev] Re: Steps to opening the tree post merge landing

2008-11-03 Thread Finnur Thorarinsson
I'll assign that bug to me, although I won't get to it until next week. If someone needs it earlier, you are welcome to pick it off of my plate and see what the problem is. On Mon, Nov 3, 2008 at 10:24, Ojan Vafai [EMAIL PROTECTED] wrote: Sigh. Apparently I've been emailing myself here.

[chromium-dev] Re: rearranged DEPS may require some repository coaxing

2008-09-10 Thread Finnur Thorarinsson
I was bitten by this. Before, we had a warning after gclient sync about directories having been removed and that we should manually remove them. Now, it seems that we just get an error on update. :( On Wed, Sep 10, 2008 at 16:29, Evan Martin [EMAIL PROTECTED] wrote: I expect most people have