Re: [chromium-dev] Embedding chrome.pak in the chrome binary for Linux?

2009-12-14 Thread Tony Chang
On Mon, Dec 14, 2009 at 12:02 PM, Tony Chang wrote: > I have considered the possibility of moving the resources on Windows out of > chrome.dll. I made a change a few weeks back that moved theme resources > into chrome.dll and there was no noticeable change on the bots. I imagine > moving them ba

Re: [chromium-dev] Embedding chrome.pak in the chrome binary for Linux?

2009-12-13 Thread Satoru Takabayashi
Evan, Thank you for the detailed feedback. It looks there won't be a much difference so I'll just forget about the idea. Thanks, Satoru On Sun, Dec 13, 2009 at 12:36 PM, Evan Martin wrote: > On Sat, Dec 12, 2009 at 4:52 AM, Satoru Takabayashi > wrote: >> The chrome binary for Linux seems to lo

Re: [chromium-dev] Embedding chrome.pak in the chrome binary for Linux?

2009-12-12 Thread Evan Martin
On Sat, Dec 12, 2009 at 4:52 AM, Satoru Takabayashi wrote: > The chrome binary for Linux seems to load resource bundles from a file named > "chrome.pak", while the resource booundles are embedded in the chrome DLL in > other platforms (correct me if I'm wrong). This makes me wonder if it's a > goo

Re: [chromium-dev] Embedding chrome.pak in the chrome binary for Linux?

2009-12-12 Thread Satoru Takabayashi
Thank you for the feedback. I was thinking about embedding only "chrome.pak", not language pak files, just like Windows has a DLL for each language. Satoru On Sun, Dec 13, 2009 at 8:56 AM, Rahul Kuchhal wrote: > There are not embedded even on Windows (see 52 dlls under > Google\Chrome\Applicat

Re: [chromium-dev] Embedding chrome.pak in the chrome binary for Linux?

2009-12-12 Thread Rahul Kuchhal
There are not embedded even on Windows (see 52 dlls under Google\Chrome\Application\\Locales folder). On Sat, Dec 12, 2009 at 4:52 AM, Satoru Takabayashi wrote: > The chrome binary for Linux seems to load resource bundles from a file > named "chrome.pak", while the resource booundles are embedded

Re: [chromium-dev] Embedding chrome.pak in the chrome binary for Linux?

2009-12-12 Thread Thomas Van Lenten
[From the right address this time] There is a pak file for each language, so you'd have in include all language pak files in the binary, and only one would be used at any given time, so there would be some overhead as far a memory, etc. TVL On Sat, Dec 12, 2009 at 7:52 AM, Satoru Takabayashi wro

[chromium-dev] Embedding chrome.pak in the chrome binary for Linux?

2009-12-12 Thread Satoru Takabayashi
The chrome binary for Linux seems to load resource bundles from a file named "chrome.pak", while the resource booundles are embedded in the chrome DLL in other platforms (correct me if I'm wrong). This makes me wonder if it's a good idea to embed chrome.pak in the chrome binary for Linux. This woul