Re: [chromium-dev] How to deal with flaky unit tests

2009-12-18 Thread Marc-Antoine Ruel
http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/scripts/master/log_parser/gtest_command.py?revision=28463&view=markup has some logic for that but doesn't seem to work anymore. Nicolas is on vacation, I'll take a look soon: http://crbug.com/30599 M-A On Fri, Dec 18, 2009 at 1:47 AM, Paw

Re: [chromium-dev] How to deal with flaky unit tests

2009-12-17 Thread Paweł Hajdan , Jr .
Looks like the browser_tests launcher needs to be updated, because its exit code was 1 (that's why the bot went red). On Fri, Dec 18, 2009 at 04:33, Lei Zhang wrote: > Does FLAKY_ work on all tests? The test run [1] for my most recent > check-in turned a bot red, even though the only test that fa

Re: [chromium-dev] How to deal with flaky unit tests

2009-12-17 Thread Lei Zhang
Does FLAKY_ work on all tests? The test run [1] for my most recent check-in turned a bot red, even though the only test that failed is one marked FLAKY_. [red] browser_tests [browser_tests 896 flaky did not complete crashed or hung] [197 seconds] [/red] and in the log; [2] ... Note: Google Test

[chromium-dev] How to deal with flaky unit tests

2009-10-06 Thread Nicolas Sylvain
Hello, We currently have more than 50 unit tests that are disabled. Most of them because they were flaky. Disabling tests is bad because we lose complete coverage on them, so I implemented a way to mark tests as "flaky". The same way you disable a test with DISABLED_ at the beginning of its name,