[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Dan Kegel
On Sat, Oct 3, 2009 at 10:19 AM, Peter Kasting pkast...@google.com wrote: I checked in a commit this morning (27949) which caused linking errors for Linux.  I got undefined reference to BlockedPopupContainer::kImpossibleNumberOfPopups in a function which had already been using that constant

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Dan Kegel
On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel d...@kegel.com wrote: undefined reference to BlockedPopupContainer::kImpossibleNumberOfPopups Aha. It's a bug in our code. chrome/browser/blocked_popup_container.cc needs to follow through and actually declare storage for that variable.

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Antoine Labour
On Sat, Oct 3, 2009 at 11:09 AM, Dan Kegel d...@kegel.com wrote: On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel d...@kegel.com wrote: undefined reference to BlockedPopupContainer::kImpossibleNumberOfPopups Aha. It's a bug in our code. chrome/browser/blocked_popup_container.cc needs to

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Peter Kasting
On Sat, Oct 3, 2009 at 11:59 AM, Antoine Labour pi...@google.com wrote: On Sat, Oct 3, 2009 at 11:09 AM, Dan Kegel d...@kegel.com wrote: On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel d...@kegel.com wrote: undefined reference to BlockedPopupContainer::kImpossibleNumberOfPopups Aha. It's a

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Jacob Mandelson
On Sat, Oct 03, 2009 at 04:25:08PM -0700, Peter Kasting wrote: On Sat, Oct 3, 2009 at 11:59 AM, Antoine Labour pi...@google.com wrote: On Sat, Oct 3, 2009 at 11:09 AM, Dan Kegel d...@kegel.com wrote: On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel d...@kegel.com wrote: undefined reference to

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Antoine Labour
On Sat, Oct 3, 2009 at 4:25 PM, Peter Kasting pkast...@google.com wrote: On Sat, Oct 3, 2009 at 11:59 AM, Antoine Labour pi...@google.com wrote: On Sat, Oct 3, 2009 at 11:09 AM, Dan Kegel d...@kegel.com wrote: On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel d...@kegel.com wrote: undefined

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Peter Kasting
On Sat, Oct 3, 2009 at 8:49 PM, Antoine Labour pi...@google.com wrote: On Sat, Oct 3, 2009 at 4:25 PM, Peter Kasting pkast...@google.com wrote: You're missing the point. I don't think I am. I'm just trying to help... I've encountered this situation many times, with the same exact