On Mon, Aug 10, 2009 at 10:45 PM, Aaron Boodman a...@chromium.org wrote:
Such a system does not help when people sync your change. We should
invest the effort we would expend building this system fixing the
dependency issues.
gclient could be made to obey it as well. But I agree, it's a
We currently have a hack of sorts in mind (well an issue filed on gyp) that
would cover a larger class of settings changes (the worst handled by vstudio
directly). The idea is to have gyp generate a text file full of settings
garp which would be an additional dependency of each project.
There are
They were both WebKit deps rolls. The latter one was caused by an .idl file
that changed.
The former, I don't know off the top of my head. Here's the chromium
review: http://codereview.chromium.org/165278 Here are the files that
changed:
I agree. Every clobber means we have a dependency bug. I would prefer that
we track and fix those bugs than get desensitized to them.
--Amanda
On Tue, Aug 11, 2009 at 1:45 AM, Aaron Boodman a...@chromium.org wrote:
Such a system does not help when people sync your change. We should
invest
Knowing MS, it could be the forward slash (/) that is breaking the
dependency scanner.
M-A
On Tue, Aug 11, 2009 at 2:24 AM, Jeremy Orlowjor...@chromium.org wrote:
They were both WebKit deps rolls. The latter one was caused by an .idl file
that changed.
The former, I don't know off the top
The culprit here was the change to the CodeGeneratorV8.pm. It looks
like we should somehow trigger clobber of of rule_binding.py when that
happens.
:DG
On Mon, Aug 10, 2009 at 11:24 PM, Jeremy Orlowjor...@chromium.org wrote:
They were both WebKit deps rolls. The latter one was caused by an
Never mind, that line is already complete!
GENERATE_BINDINGS_SCRIPTS = \
bindings/scripts/CodeGenerator.pm \
bindings/scripts/IDLParser.pm \
bindings/scripts/IDLStructure.pm \
bindings/scripts/generate-bindings.pl \
On Tue, Aug 11, 2009 at 7:51 AM, Eric Seidel
Dimitri Glazkov wrote:
The culprit here was the change to the CodeGeneratorV8.pm. It looks
like we should somehow trigger clobber of of rule_binding.py when that
happens.
We already do. In the .idl rule in webkit.gyp, we have:
'inputs': [
Ok I think I've found it.It looks like a bug in the rule - makefile emitter
which is only used for webcore.
(Most gyp rules turn into custom build rules, but we added a makefile
emitter option for this one because the native rules were too slow).
It appears that the custom build step for the
Nice!!!
On Tue, Aug 11, 2009 at 3:57 PM, Bradley Nelson bradnel...@google.comwrote:
Ok I think I've found it.It looks like a bug in the rule - makefile
emitter which is only used for webcore.
(Most gyp rules turn into custom build rules, but we added a makefile
emitter option for this one
10 matches
Mail list logo
