[chromium-dev] Re: Flakiness. Please help.

2009-08-07 Thread Thomas Van Lenten
On Fri, Aug 7, 2009 at 6:46 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: On Thu, Aug 6, 2009 at 5:05 PM, Jeremy Orlowjor...@chromium.org wrote: On Thu, Aug 6, 2009 at 2:02 PM, Nicolas Sylvain nsylv...@chromium.org wrote: On Thu, Aug 6, 2009 at 1:05 PM, Scott Violet

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Paul Wicks
Maybe this is a stupid question, but where can I find test-expectations.txt? I looked in the tree and didn't see it. -Paul Wicks On Wed, Aug 5, 2009 at 11:12 PM, Peter Kastingpkast...@google.com wrote: On Wed, Aug 5, 2009 at 10:10 PM, Eric Seidel esei...@chromium.org wrote: Do we have a

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Jeremy Orlow
src/webkit/tools/data/layout_tests btw, run_layout_tests.* can be used to run stuff (and lint the exceptions file) On Wed, Aug 5, 2009 at 11:26 PM, Paul Wicks pwick...@gmail.com wrote: Maybe this is a stupid question, but where can I find test-expectations.txt? I looked in the tree and didn't

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Jeremy Orlow
Oops...I failedit's actually src/webkit/tools/layout_tests Also the file uses an underscore, not a dash...it's test_expectations.txt J On Wed, Aug 5, 2009 at 11:28 PM, Jeremy Orlow jor...@chromium.org wrote: src/webkit/tools/data/layout_tests btw, run_layout_tests.* can be used to run

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Dan Kegel
On Wed, Aug 5, 2009 at 9:44 PM, Peter Kastingpkast...@google.com wrote: * Yes, even purify, valgrind, and reliability bot redness.  If you can't figure out what to do with these, try pinging erikkay for purify issues and huanr for reliability issues.  (Not sure who a good general valgrind

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Scott Violet
One easy suggestion in helping catch bugs is to run Chrome with --enable-dcheck . This'll prompt if you hit a DCHECK in release builds and hopefully help isolate crashes before the fact. -Scott On Wed, Aug 5, 2009 at 9:44 PM, Peter Kastingpkast...@google.com wrote: THIS MAIL APPLIES TO YOU

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Antony Sargent
To clarify, doesn't --enable-dcheck only work on chromium release builds you built yourself and not official builds of Google Chrome? On Thu, Aug 6, 2009 at 10:15 AM, Scott Violet s...@chromium.org wrote: One easy suggestion in helping catch bugs is to run Chrome with --enable-dcheck .

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Scott Violet
Not sure, perhaps Huan could answer that. That said, --enable-dcheck certainly works on the Chromium release builds from the buildbot: http://build.chromium.org/buildbot/continuous/LATEST/ . -Scott On Thu, Aug 6, 2009 at 12:59 PM, Antony Sargentasarg...@google.com wrote: To clarify, doesn't

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Nicolas Sylvain
On Thu, Aug 6, 2009 at 1:05 PM, Scott Violet s...@chromium.org wrote: Not sure, perhaps Huan could answer that. That said, --enable-dcheck certainly works on the Chromium release builds from the buildbot: http://build.chromium.org/buildbot/continuous/LATEST/ . Yes, --enable-dcheck is

[chromium-dev] Re: Flakiness. Please help.

2009-08-05 Thread Eric Seidel
Do we have a list of flakey tests? I feel like we used to have one... On Wed, Aug 5, 2009 at 9:44 PM, Peter Kasting pkast...@google.com wrote: THIS MAIL APPLIES TO YOU Flakiness is growing. Smash it before it gets bigger, and keep it smashed. *** The MOST IMPORTANT section in this

[chromium-dev] Re: Flakiness. Please help.

2009-08-05 Thread Peter Kasting
On Wed, Aug 5, 2009 at 10:10 PM, Eric Seidel esei...@chromium.org wrote: Do we have a list of flakey tests? I feel like we used to have one... Every test in test-expectations.txt marked PASS FAIL or PASS FAIL CRASH or some similar set of multiple expectations is flaky, or at least thought to

[chromium-dev] Re: Flakiness. Please help.

2009-08-05 Thread Dimitri Glazkov
Ojan is working on the tool for the layout tests. First bits are already checked in. :DG On Wed, Aug 5, 2009 at 10:10 PM, Eric Seidelesei...@chromium.org wrote: Do we have a list of flakey tests?  I feel like we used to have one... On Wed, Aug 5, 2009 at 9:44 PM, Peter Kasting