[chromium-dev] Re: Fwd: Chromium code coverage dashboard is up

2009-06-04 Thread Randall Spangler
The rules which Croc uses on linux are a combination of those in src/build/common.croc and src/build/linux/chrome_linux.croc. We can add exclusions to those rules as needed to fix cases like these. For example, the following rule will exclude .../wmi_util.* { 'regexp' :

[chromium-dev] Re: Fwd: Chromium code coverage dashboard is up

2009-06-03 Thread Dean McNamee
Seems there are some bugs relating to which files count. For example: http://build.chromium.org/buildbot/coverage/linux-debug/17471/CHROMIUM/base/index.html It counts files like wmi_util, which is Windows specific and not compiled on Linux. On Wed, Jun 3, 2009 at 9:12 PM, Paweł Hajdan

[chromium-dev] Re: Fwd: Chromium code coverage dashboard is up

2009-06-03 Thread Randall Spangler
Hi Pawel, - Green = executable line of code which was actually run by the tests. - Yellow = executable line of code which was compiled into a test (and thus seen by the coverage instrumentation tools), but not run by the test. For example, a function not called as part of the test, or

[chromium-dev] Re: Fwd: Chromium code coverage dashboard is up

2009-06-03 Thread Antoine Labour
2009/6/3 Randall Spangler rspang...@google.com: Hi Dean, Croc (the coverage utility) currently takes an expansive view of which files need to be covered.  That's to catch cases where a new source file is added, but not compiled into any tests. The rules which Croc uses on linux are a