[chromium-dev] Re: Shouldn't the Mac ignore the platform/win tests?

2009-10-01 Thread Ojan Vafai
They are marked WONTFIX. We run them to ensure they don't crash. This looks like a bug in run_webkit_tests to me. For tests that are WONTFIX, we shouldn't care if the expected results are missing. Seems a bit silly to me that we run them at all though. I would be a fan of just skipping the

[chromium-dev] Re: Shouldn't the Mac ignore the platform/win tests?

2009-10-01 Thread Avi Drissman
Right now I want to land so I'll file a bug... Avi On Thu, Oct 1, 2009 at 2:34 PM, Ojan Vafai o...@chromium.org wrote: They are marked WONTFIX. We run them to ensure they don't crash. This looks like a bug in run_webkit_tests to me. For tests that are WONTFIX, we shouldn't care if the

[chromium-dev] Re: Shouldn't the Mac ignore the platform/win tests?

2009-10-01 Thread Dirk Pranke
Ojan, As you know, run_webkit_tests doesn't have the concept of it's okay that there are no expected results. Several other people have also mentioned to me that it would be nice if it did, but I don't feel strongly about it one way or another. I don't know that I would consider tests marked