Ah! That did the trick; thanks.
On Jun 19, 10:24 am, Dimitri Glazkov dglaz...@google.com wrote:
Since Audio object will be instantiated via JS, we need to add extra 2
lines to that huge switch statement in V8Proxy::GetTemplate:
case V8ClassIndex::HTMLIMAGEELEMENT:
Ok, so. So far I've created a new file
V8HTMLAudioElementConstructor.cpp and modeled it off
V8HTMLImageElementConstructor.cpp (changing all images to audios,
plus modified V8CustomBinding.h and webkit.gyp. Change is here:
http://codereview.chromium.org/132036
But I'm still getting TypeError:
My only quick suggestion would be: did you try a clobber build? My
experience with bindings is they never seem to incrementally build or link
very well :(
On Thu, Jun 18, 2009 at 4:05 PM, kylep ky...@chromium.org wrote:
Ok, so. So far I've created a new file
V8HTMLAudioElementConstructor.cpp
Ok, that didn't work.
On Jun 18, 4:11 pm, Andrew Scherkus scher...@chromium.org wrote:
My only quick suggestion would be: did you try a clobber build? My
experience with bindings is they never seem to incrementally build or link
very well :(
On Thu, Jun 18, 2009 at 4:05 PM, kylep
You're almost there. You also need to make sure to register it in
v8_proxy.cpp (look for Image as a pattern to follow).
BTW, with gyp, dependencies in bindings are pretty robust. No need to
clobber anymore.
:DG
On Thu, Jun 18, 2009 at 4:05 PM, kylepky...@chromium.org wrote:
Ok, so. So far
A good place to start would be to look at existing *Constructor.cpp
files in WebCore/bindings/v8 and see how they are hooked in (like
Image constructor). Also, you have dimich and levin in close proximity
you who have added a V8 constructor or two in the past (I think).
;DG
On Mon, Jun 15, 2009
