On Tue, Sep 22, 2009 at 8:40 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:
Oh, and, if your change turned the tree red for 3 hours, don't be mad at
the sheriff when he pings
you repeatedly about the status of the fix. His job is to keep the tree
green and running. He does
not care about
WebKit gardening occurs more often than sheriff duties.
afaik all WebKit gardeners also have sheriff duties.
This implies there are people on the team who don't have gardening
duties. We need to fix that ASAP. Nobody should get special
dispensation.
--
Mike Pinkerton
Mac Weenie
On Wed, Sep 23, 2009 at 6:52 AM, Amanda Walker ama...@chromium.org wrote:
... I agree that the real solution is to keep pedaling hard to finish the
webkit API.
If anyone has cycles to help with the WebKit API, please let me know! :-)
-Darin
It is hard to be a WebKit gardener if you do not have WebKit commit access.
Sometimes the gardener has to commit a quick bustage fix upstream or roll
back a fellow Chromium committers change to WebKit.
-Darin
Correct, it is hard, but many/most of us who are webkit
sheriffs/gardeners are not
I find that being a WebKit gardener is always dancing on a minefield
regardless of my familiarity with the WebKit code base. Look at yesterday
for an example.
In addition, we have several gardeners who are not actively working on
WebKit (amanda@ has 0 WebKit commits, pinkerton@ has a few all in
I'll take the action item to remove anyone in the rotation who is not
actively working on Webkit / is not a committer.
In the past, I've floated the idea in the past of having a Webkit deputy
who helps the gardener keep the canary green. I'm not sure if that would
help, though.
Regards,
Glenn
I think it would be a good idea to ensure that there is at least someone on
call to help new gardeners if they have questions or find themselves in a
mess. I know I just asked dglazkov whenever I wasn't sure what to do, but
he'd probably appreciate not being the only designated knowledgeable
On Wed, Sep 23, 2009 at 8:53 AM, Glenn Wilson gwil...@chromium.org wrote:
I'll take the action item to remove anyone in the rotation who is not
actively working on Webkit / is not a committer.
Oh no... now it will happen even more often :)
Should there also be the reverse adding WebKit
On Tue, Sep 22, 2009 at 10:47 PM, David Levin le...@chromium.org wrote:
Actionable items for keeping the tree green (in addition to blaming the
WebKit gardener for [insert action here]):
- *Get people putting in chromium patches upstream to run their changes
through trybots, etc*. imo,
On Tue, Sep 22, 2009 at 5:40 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:
If this is an issue, I am proposing that Webkit merges be done outside peak
hours (11am-5pm pacific).
If we implement this, it can cause problems for cases where we need to do a
merge/land/merge pattern to coordinate
On Tue, Sep 22, 2009 at 17:40, Nicolas Sylvain nsylv...@chromium.orgwrote:
3 PM : two failing ui tests are disabled by the webkit sheriff
I was looking at the UI tests and it wasn't immediately obvious that a
webkit update might break them. Can we run all the UI tests on the webkit
canary bot?
On Tue, Sep 22, 2009 at 5:40 PM, Nicolas Sylvain nsylv...@chromium.org wrote:
If this is an issue, I am proposing that Webkit merges be done outside peak
hours (11am-5pm pacific).
This seems backwards. Don't we want to integrate more often so we can
catch and fix these issue faster? Ideally,
There are 2 major issues here (besides leaving things for the Sheriff to
clean up):
1) a lot of the gardeners are inexperienced and drop the ball. This has
bitten us many times. The last time we had a big string of problems related
to this, I meant to send out an email giving people advice on
On Tue, Sep 22, 2009 at 6:08 PM, Adam Barth aba...@chromium.org wrote:
On Tue, Sep 22, 2009 at 5:40 PM, Nicolas Sylvain nsylv...@chromium.org
wrote:
If this is an issue, I am proposing that Webkit merges be done outside
peak
hours (11am-5pm pacific).
This seems backwards. Don't we want
On Tue, Sep 22, 2009 at 6:08 PM, Adam Barth aba...@chromium.org wrote:
On Tue, Sep 22, 2009 at 5:40 PM, Nicolas Sylvain nsylv...@chromium.org
wrote:
If this is an issue, I am proposing that Webkit merges be done outside peak
hours (11am-5pm pacific).
This seems backwards. Don't we want
On Tue, Sep 22, 2009 at 6:16 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:
On Tue, Sep 22, 2009 at 6:10 PM, Jeremy Orlow jor...@chromium.org wrote:
There are 2 major issues here (besides leaving things for the Sheriff to
clean up):
1) a lot of the gardeners are inexperienced and drop the
Actionable items for keeping the tree green (in addition to blaming the
WebKit gardener for [insert action here]):
- *Get people putting in chromium patches upstream to run their changes
through trybots, etc*. imo, patches from @chromium folks cause well over
50% of the grief with WebKit
17 matches
Mail list logo
