[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Brett Wilson
On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote: WebCore::String has the interesting property of differentiating between an empty string and a null string. In string16, however, there is no such thing as null. The LocalStorage implementation I'm working on proxies data

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org wrote: On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote: WebCore::String has the interesting property of differentiating between an empty string and a null string. In string16, however, there is no such

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Jeremy Orlow
On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org wrote: On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote: WebCore::String has the interesting property of differentiating between an

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Brett Wilson
On Mon, Jul 13, 2009 at 10:05 AM, Jeremy Orlowjor...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org wrote: On Fri, Jul 10, 2009 at 5:04 PM, Jeremy Orlowjor...@chromium.org wrote:

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Jeremy Orlow
On Mon, Jul 13, 2009 at 10:08 AM, Brett Wilson bre...@chromium.org wrote: On Mon, Jul 13, 2009 at 10:05 AM, Jeremy Orlowjor...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org wrote: On Mon, Jul 13, 2009 at 8:20 AM, Brett Wilson bre...@chromium.org

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Scott Hess
On Mon, Jul 13, 2009 at 10:10 AM, Jeremy Orlowjor...@chromium.org wrote: On Mon, Jul 13, 2009 at 10:08 AM, Brett Wilson bre...@chromium.org wrote: Yes, I think NullableString16 is better than passing a separate bool. Can anyone think of a better name for it? What's wrong with

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Jeremy Orlow
All right. NullableString16 it is. :-) And, in case it's not clear, this will only be for strings that have a valid null state. The common case should still be using string16. J On Mon, Jul 13, 2009 at 10:23 AM, Scott Hess sh...@chromium.org wrote: On Mon, Jul 13, 2009 at 10:10 AM, Jeremy

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 12:29 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Jul 13, 2009 at 12:20 PM, David Levin le...@google.com wrote: On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.org wrote: WebString exists (has for many moons now). It is just a wrapper for

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Jeremy Orlow
On Mon, Jul 13, 2009 at 12:54 PM, Darin Fisher da...@chromium.org wrote: On Mon, Jul 13, 2009 at 12:29 PM, Jeremy Orlow jor...@chromium.orgwrote: On Mon, Jul 13, 2009 at 12:20 PM, David Levin le...@google.com wrote: On Mon, Jul 13, 2009 at 8:59 AM, Darin Fisher da...@chromium.orgwrote:

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Darin Fisher
On Mon, Jul 13, 2009 at 12:59 PM, Jeremy Orlow jor...@chromium.org wrote: On Mon, Jul 13, 2009 at 12:54 PM, Darin Fisher da...@chromium.org wrote: On Mon, Jul 13, 2009 at 12:29 PM, Jeremy Orlow jor...@chromium.orgwrote: On Mon, Jul 13, 2009 at 12:20 PM, David Levin le...@google.com wrote: