On Wed, Aug 5, 2009 at 5:32 PM, Jeremy Orlow jor...@google.com wrote:
Which kind soul ended up working on this? Big thanks are in order, but I
wanted to let you know that at least one case slipped through the cracks:
http://src.chromium.org/viewvc/chrome?view=revrevision=22556 required a
I'm working on gclient to pass the matching file list to the hook, or some
equivalent.
I discovered another issue, which I highly suspect is caused by a build
issue (I'm not sure if it's the same issue).
waiting_animation_frames = rb.GetBitmapNamed(IDR_THROBBER_WAITING);
This happens semi-frequently. It's related to the grit resources
rebuilding. Something like: not remapping IDR_THROBBER_WAITING to the
right place, or remapping it to the right place but not rebuilding
this file, or something like that.
On Tue, Jul 28, 2009 at 4:18 PM, Paweł Hajdan
On Tue, Jul 28, 2009 at 4:35 PM, Paweł Hajdan
Jr.phajdan...@chromium.org wrote:
On Tue, Jul 28, 2009 at 16:30, Evan Martin e...@chromium.org wrote:
This happens semi-frequently. It's related to the grit resources
rebuilding. Something like: not remapping IDR_THROBBER_WAITING to the
right
On Tue, Jul 28, 2009 at 4:37 PM, Evan Martin e...@chromium.org wrote:
On Tue, Jul 28, 2009 at 4:35 PM, Paweł Hajdan
Jr.phajdan...@chromium.org wrote:
On Tue, Jul 28, 2009 at 16:30, Evan Martin e...@chromium.org wrote:
This happens semi-frequently. It's related to the grit resources
I'm going to try writing the hook, but I would first ask for advice.
The hook syntax takes a filename pattern and a command. So I would have to
create a new command (probably in src/tools), like clobber_generated_headers
or something similar.
And the tool itself does not get the list of changed
Tony, just to make sure, are you certain that this is a IB only issue?
I used to be convinced that it was happening with visual studio too.
If this is a IB only problem, we should create a repro case and send it to
them, they
are usually really responsive.
[For some reasons, I thought it was
On Thu, Jul 23, 2009 at 4:31 PM, Paweł Hajdan Jr.
phajdan...@chromium.orgwrote:
Some of the flaky failures are caused by resource bundle issues. If you are
familiar with the build process, or the resource bundle, please take a look.
It looks like something needed a manual clobber and didn't
To elaborate on Peter's comment. IncrediBuild (which the buildbots
use) get confused by changes to our grd files. Our grd files generate
headers, which should then cause lots of cc files to get rebuilt.
Visual Studio seems to always get this right, but IncrediBuild gets
this wrong and cc files
Is it possible to force it to rebuild some files, or... I don't know, do you
see some real way to fix this problem?
On Thu, Jul 23, 2009 at 16:41, Tony Chang t...@chromium.org wrote:
To elaborate on Peter's comment. IncrediBuild (which the buildbots
use) get confused by changes to our grd
Look at how the current gyp hook works. It looks for changes to .gyp
files and only runs if a .gyp (and maybe gypi?) file has changed.
You can find what header it generates by opening the grd file and
parsing the XML (the XML lists the output files). You'll need to
build the base directory
I think that this workaround may be worth it. I'm not familiar with the
IncrediBuild, but I can help making the hook (and we can run it only on
Windows).
How do I make a hook know which grd files changed? And also know which
headers it generates? Alternatively, maybe this Windows-only hook would
Here's a crappy work around:
Add a gclient hook that checks for grd file changes. When a grd file
changes, force delete the header it would generate. I'm pretty sure
this would prevent bad builds from IncrediBuild.
Alternately, maybe we can make a reduced test case and file a bug
against
13 matches
Mail list logo
