Re: [chromium-dev] WebKit Gardeners <3 rebaseline.py -w

2010-01-11 Thread Victor Wang
I started working on upstreaming the rebaseline tool, which is part of the plan for upstreaming layout tests in Q1. On Sat, Jan 9, 2010 at 2:53 PM, Eric Seidel wrote: > Once we have this sort of tool for webkit.org then those of us who > work on webkit.org could just add the new baselines when w

Re: [chromium-dev] WebKit Gardeners <3 rebaseline.py -w

2010-01-09 Thread Eric Seidel
Once we have this sort of tool for webkit.org then those of us who work on webkit.org could just add the new baselines when we commit the patches in the first place. :) On Fri, Jan 8, 2010 at 5:38 PM, Julie Parent wrote: > Yeah, me too. > This is what tends to lead to me spending the day after my

Re: [chromium-dev] WebKit Gardeners <3 rebaseline.py -w

2010-01-08 Thread Julie Parent
Yeah, me too. This is what tends to lead to me spending the day after my gardening rotation doing clean up. Maybe if we had 2 people gardening at the same time they could do this real time, but on a normal day, I think it is too much for one person. This tool is awesome though! Julie On Fri, J

Re: [chromium-dev] WebKit Gardeners <3 rebaseline.py -w

2010-01-08 Thread Jeremy Orlow
Same here. On Fri, Jan 8, 2010 at 4:51 PM, Drew Wilson wrote: > Do you find that you have time to figure out if rebaselining a test is the > right thing to do while you're actively gardening? Maybe I just work too > slowly, but I often find that if I'm trying to rebaseline on the fly, it > requi

Re: [chromium-dev] WebKit Gardeners <3 rebaseline.py -w

2010-01-08 Thread Drew Wilson
Do you find that you have time to figure out if rebaselining a test is the right thing to do while you're actively gardening? Maybe I just work too slowly, but I often find that if I'm trying to rebaseline on the fly, it requires that I do at least *some* investigation of the test failure to make s

[chromium-dev] WebKit Gardeners <3 rebaseline.py -w

2010-01-08 Thread Dimitri Glazkov
Before heading out for the weekend, I just want to mention this: rebaseline tool really, really rocks. And yesterday I discovered an option that I, to my shame, hadn't seen before: -w. This option pulls baselines from the canary. It's like getting test expectations from the future! In other words,