Re: [chromium-dev] displaying unparseable ftp directory listings as-is

2010-01-13 Thread Adam Barth
On Mon, Jan 11, 2010 at 12:21 PM, Paweł Hajdan, Jr. phajdan...@chromium.org wrote: Is there any security risks with passing raw ftp listings to the renderer in case we can't parse them? We already have a check in the code so that we will only make a data connection to the server we have the

Re: [chromium-dev] displaying unparseable ftp directory listings as-is

2010-01-13 Thread Darin Fisher
If an error is detected mid-stream, how about inserting some JS that will modify the DOM to insert a warning block at the top (or bottom) of the view port. You could include a link that when clicked would load the raw stream. Maybe we could achieve that by supporting a query parameter syntax,

[chromium-dev] displaying unparseable ftp directory listings as-is

2010-01-11 Thread Paweł Hajdan , Jr .
Is there any security risks with passing raw ftp listings to the renderer in case we can't parse them? We already have a check in the code so that we will only make a data connection to the server we have the control connection with. If it's ok to do so, I'd also like to include some message

Re: [chromium-dev] displaying unparseable ftp directory listings as-is

2010-01-11 Thread Pierre-Antoine LaFayette
I am looking into an issue involving adding icons for to the ftp directory listing page, can you point me to where this code is handled? I know that the HTML template is generated in ftp_directory_listing_response_delegate.cc. I'm trying to see if its okay to request icon data from the Browser