Automatically closing tree for update on Modules XP (dbg)
http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP%20%28dbg%29/builds/16315
http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20XP%20%28dbg%29
--= Automatically closing tree for update on Modules XP
Guys, just to summarize the discussion.
There are several ways we can tweak tcmalloc:
1) decommit everything what is free;
2) keep spans with a mixed state (some pages committed, some not,
coalescing nor commit, not decommits)---that should solve main Jim's
argument;
3) commit on coalescing,
On Thu, Oct 1, 2009 at 4:44 PM, Anton Muhin ant...@chromium.org wrote:
Guys, just to summarize the discussion.
There are several ways we can tweak tcmalloc:
1) decommit everything what is free;
2) keep spans with a mixed state (some pages committed, some not,
coalescing nor commit, not
And we pay when allocating---blocks need to be committed first.
yours,
anton.
On Thu, Oct 1, 2009 at 5:14 PM, Vitaly Repeshko vita...@chromium.org wrote:
On Thu, Oct 1, 2009 at 4:44 PM, Anton Muhin ant...@chromium.org wrote:
Guys, just to summarize the discussion.
There are several ways we
[uninformed question]
From a quick search, when you're talking about decommit, you seem to
always use MEM_DECOMMIT instead of MEM_RELEASE; I see no MEM_RELEASE
in tcmalloc.
You do leak the reserved pages or are they first reused? What I am
referring to is to a potential virtual address space
Thanks a lot for pointing that out.
yours,
anton.
On Thu, Oct 1, 2009 at 6:20 PM, Marc-Antoine Ruel mar...@chromium.org wrote:
If you add this functionality, you should add this to SystemMonitor in
src/base/system_monitor.h
On Thu, Oct 1, 2009 at 9:17 AM, Anton Muhin ant...@chromium.org
Note: my change was reverted for other reasons.-Darin
On Thu, Oct 1, 2009 at 7:58 AM, Chase Phillips ch...@chromium.org wrote:
Hey everyone,
A performance regression has appeared on the XP Perf bot in the morejs page
cycler. Along with turning XP Perf red, the perf regression system notified
Probably caused by jemalloc. Jim was experimenting with the idea of getting
some dev-channel data from using jemalloc as opposed to tcmalloc. I'm not
surprised there was a perf delta, but I am surprised by how much. The DOM
benchmark in this test dropped by 8%. Several other benchmarks took
see about:tcmalloc (credit to sgk) - which dumps the *browser* stats. We
need to plumb other processes.
Mike
On Thu, Oct 1, 2009 at 8:42 AM, Erik Kay erik...@chromium.org wrote:
On Wed, Sep 30, 2009 at 11:22 AM, James Robinson jam...@google.com
wrote:
I agree completely that this seems
I think we have a new constraint which we previously were ignoring.
Spikes in memory usage of 500MB (which could be released) are no longer
tolerable, ever. (I'd like to get agreement on how to define this - some
amount of cached memory is okay, of course, but 500MB is not).
Some of the
Sounds good to me - does windows have a good low-memory notification api?
On Thu, Oct 1, 2009 at 7:22 AM, Anton Muhin ant...@chromium.org wrote:
Thanks a lot for pointing that out.
yours,
anton.
On Thu, Oct 1, 2009 at 6:20 PM, Marc-Antoine Ruel mar...@chromium.org
wrote:
If you add
On Thu, Oct 1, 2009 at 9:06 AM, Mike Belshe mbel...@google.com wrote:
Sounds good to me - does windows have a good low-memory notification api?
http://msdn.microsoft.com/en-us/library/aa366541(VS.85,loband).aspx
AGL
--~--~-~--~~~---~--~~
Chromium Developers
On Thu, Oct 1, 2009 at 8:49 AM, Mike Belshe mbel...@google.com wrote:
see about:tcmalloc (credit to sgk) - which dumps the *browser* stats. We
need to plumb other processes.
This is really cool. My question of cost to compute was whether it
makes sense to get this into end-user histograms,
Thanks, this works for me too!
Is there a change needed so that either (1) native_client is not
required, or (2) the tarball doesn't exclude native client?
- Dominic
On Tue, Sep 29, 2009 at 12:45 PM, Nicolas Sylvain nsylv...@chromium.org wrote:
you need to edit your .gclient and remove the
I'm trying to cross compile chromium to ARM, but I'm getting errors in
the native client code.
./native_client/src/include/elf.h:68:3: error: #error
NACL_TARGET_SUBARCH must be defined to be 32 or 64
It looks like I have to have the same build and target architectures
in order to work properly.
Hello everyone, if you haven't set up your own Chromium Buildbot before or
don't plan to, you can stop reading now.
I've added a Buildbot tips page to the Chromium dev site:
http://sites.google.com/a/chromium.org/dev/developers/testing/chromium-build-infrastructure/tips
The first tip describes
Dominic and I starting running into this today also. We both don't have the
src/native_client directory. And I don't see it listed in the directory list
at http://src.chromium.org/svn/trunk/src/.
On Tue, Sep 29, 2009 at 10:53 AM, Mark Mentovai m...@chromium.org wrote:
gclient may have gotten
Is there a good, and less painful, way to extract test_shell into its
own project? I'm going to be tweaking the Webkit rendering engine and
a stripped down browser is exactly what I need for testing.
Thanks.
Pierre.
--~--~-~--~~~---~--~~
Chromium Developers
I got the same error. The solution is to edit the .gclient file and
comment out the line containing the native_client module:
#src/native_client: None,
On Sep 29, 9:56 am, Thomas Van Lenten thoma...@chromium.org wrote:
Did you get any errors in the gclient sync? There is an entry for that
On Wed, Sep 30, 2009 at 4:06 AM, plafayette pierre.lafaye...@gmail.comwrote:
Is there a good, and less painful, way to extract test_shell into its
own project?
I don't understand. test_shell already is its own project (.vcproj).
PK
--~--~-~--~~~---~--~~
I can't seem to even do a gclient config with getting the error:
svn: Can't find a temporary directory: Internal error
Googling around seems to indicate that the server disk space is full.
Is there an issue on the server? Or is there something I can do on my
end?
Daniel
I'm quite sure it is jemalloc. I failed miserably by not over-communicating
this checkin. My apologies to all that I have inconvenience.
We have just this week identified a number of misteps in our use of
TCMalloc. I think that we can eventually reach an excellent result with
TCMalloc... and we
On Tue, Sep 29, 2009 at 11:37 AM, Chris Guillory ctg...@google.com wrote:
Dominic and I starting running into this today also. We both don't have the
src/native_client directory. And I don't see it listed in the directory list
at http://src.chromium.org/svn/trunk/src/.
gclient update will
On Thu, Oct 1, 2009 at 6:17 AM, Anton Muhin ant...@chromium.org wrote:
Dear chromers!
Do we have some notification mechanism for low memory event?
If not, are you fine if I add it? It would be completely optional and
I would only implement it for tcmalloc (most probably invoking before
Hey everyone,
A performance regression has appeared on the XP Perf bot in the morejs page
cycler. Along with turning XP Perf red, the perf regression system notified
me via email (forwarded below). The page load regression is about 30ms.
There's a similar regression in the moz page cycler.
In preparation for a re-organization, I added a second mapping for the
google sites page that dev.chromium.org points to. Somehow, this seems
to have broken the first mapping of dev.chromium.org. I am reaching
out to the team, in the meantime if dev.chromium.org gives you errors,
all of the
Did somebody answer Marc-Antoine question?
I don't see us ever releasing pages. I can fathom that we are not
doing that so I must be reading the code wrong.
On Oct 1, 10:11 am, Erik Kay erik...@chromium.org wrote:
On Thu, Oct 1, 2009 at 8:49 AM, Mike Belshe mbel...@google.com wrote:
see
On Thu, Oct 1, 2009 at 10:18 PM, cpu c...@chromium.org wrote:
Did somebody answer Marc-Antoine question?
I don't see us ever releasing pages. I can fathom that we are not
doing that so I must be reading the code wrong.
What to you mean by release? decommitting or releasing reserved pages?
I think we should be willing to take a temporary performance hit on the dev
channel in the interests of generating data which will eventually improve
stability.
Could we set jemalloc on selected renderer processes? I realize that
wouldn't necessarily only impact the target domains, but it might
On Thu, Oct 1, 2009 at 11:27 AM, Scott Hess sh...@chromium.org wrote:
I think we should be willing to take a temporary performance hit on the dev
channel in the interests of generating data which will eventually improve
stability.
Could we set jemalloc on selected renderer processes? I
They are marked WONTFIX. We run them to ensure they don't crash. This looks
like a bug in run_webkit_tests to me. For tests that are WONTFIX, we
shouldn't care if the expected results are missing.
Seems a bit silly to me that we run them at all though. I would be a fan of
just skipping the
We've been talking about this; Jim is actively researching.
tcmalloc doesn't fully release yet, but it will. This is second priority to
getting the decommit strategy correct.
Mike
On Thu, Oct 1, 2009 at 11:24 AM, Marc-Antoine Ruel mar...@chromium.orgwrote:
On Thu, Oct 1, 2009 at 2:22 PM,
Right now I want to land so I'll file a bug...
Avi
On Thu, Oct 1, 2009 at 2:34 PM, Ojan Vafai o...@chromium.org wrote:
They are marked WONTFIX. We run them to ensure they don't crash. This looks
like a bug in run_webkit_tests to me. For tests that are WONTFIX, we
shouldn't care if the
With help from the Google Sites team, this is now fixed. Sorry for the
inconvenience.
-Ian
2009/10/1 Ian Fette i...@chromium.org:
In preparation for a re-organization, I added a second mapping for the
google sites page that dev.chromium.org points to. Somehow, this seems
to have broken the
Ojan,
As you know, run_webkit_tests doesn't have the concept of it's okay
that there are no expected results.
Several other people have also mentioned to me that it would be nice
if it did, but I don't feel strongly about it one way or another. I
don't know that I would consider tests marked
On Thu, Oct 1, 2009 at 10:11 AM, Erik Kay erik...@chromium.org wrote:
On Thu, Oct 1, 2009 at 8:49 AM, Mike Belshe mbel...@google.com wrote:
see about:tcmalloc (credit to sgk) - which dumps the *browser* stats. We
need to plumb other processes.
This is really cool. My question of cost to
On Thu, Oct 1, 2009 at 11:32 AM, Mike Belshe mbel...@google.com wrote:
On Thu, Oct 1, 2009 at 11:27 AM, Scott Hess sh...@chromium.org wrote:
Could we set jemalloc on selected renderer processes? I realize that
wouldn't necessarily only impact the target domains, but it might be
better than
On Thu, Oct 1, 2009 at 12:38 PM, Scott Hess sh...@chromium.org wrote:
On Thu, Oct 1, 2009 at 11:32 AM, Mike Belshe mbel...@google.com wrote:
On Thu, Oct 1, 2009 at 11:27 AM, Scott Hess sh...@chromium.org wrote:
Could we set jemalloc on selected renderer processes? I realize that
wouldn't
+chromium-dev
-chromium-extensions
(This is more of a question of hacking on the chromium code than in
writing extensions.)
On Thu, Oct 1, 2009 at 10:51 AM, Jeff Timanus jeff.tima...@gmail.com wrote:
Hi Erik Extension Developers
I'm attempting to add some of the pop-up API functions that take
Detailed error message:
1-- Build started: Project: js2c, Configuration: Debug Win32
--
1js2c
2-- Build started: Project: cygwin, Configuration: Debug Win32
--
2setup_mount
1 30 [main] bash 8980 _cygtls::handle_exceptions: Exception:
STATUS_ACCESS_VIOLATION
1 3645 [main]
I've never done this, but I'm happy to learn. I got an intro to how to do it
a few weeks back re:some extensions APIs.
Where do I send the email? I'll send out a draft here beforehand.
-Nick
On Thu, Oct 1, 2009 at 2:41 PM, Brad Green (大面包) b...@google.com wrote:
API: How does the page know
A bit of fall cleaning. In order to clean-up the issue tracker labels a bit
and make some of the feature areas a bit more clear, I've made the following
changes:
- Type-Task, Type-Review, and Type-Other have been removed
- Mstone-1.0 and Mstone-2.0 have been retired
- Area-Compat has
You should talk with the open web leads (darin, ifette, dglazkov,
slightlyoff) for help on floating this out there.
On Thu, Oct 1, 2009 at 1:12 PM, Nick Baum nickb...@chromium.org wrote:
I've never done this, but I'm happy to learn. I got an intro to how to do
it a few weeks back re:some
On Thu, Oct 1, 2009 at 1:22 PM, Anthony LaForge lafo...@google.com wrote:
A bit of fall cleaning. In order to clean-up the issue tracker labels a
bit and make some of the feature areas a bit more clear, I've made the
following changes:
- Type-Task, Type-Review, and Type-Other have been
On Tue, Sep 29, 2009 at 7:58 PM, Bradley Nelson bradnel...@google.comwrote:
Sadly to my knowledge no-one has such a script.
I've written a script for converting (basic, un-complicated) .sln and
.vcproj files to .gyp:
http://code.google.com/p/gyp/issues/detail?id=82
-BradN
On Mon, Sep 28,
You can use the form issue project:bugid in bug descriptions to
autolink to bugs in other code.google.com projects like v8, skia, googleurl,
etc.
As of today, this form is supported for Duplicate and Blocked on. So, for
example, I marked V8's http://code.google.com/p/v8/issues/detail?id=19 as a
Windows 7 64bit works fine here (using the default settings from
dev.chromium.org) Make sure you have access to the folder your writing to.
Some folders require admin mode.
-Mohamed
On Thu, Oct 1, 2009 at 4:10 PM, vha14 vuh...@gmail.com wrote:
Detailed error message:
1-- Build
Hi Mohamed, can you run bash.exe from cmd? I get the following error:
E:\chromium\home\chrome-svn\tarball\chromium\src\third_party\cygwin
\binbash
9 [main] bash 8384 _cygtls::handle_exceptions: Exception:
STATUS_ACCESS_VIOLATION
9964 [main] bash 8384 open_stackdumpfile: Dumping stack
I'm working on some code that uses the gyp build system. I find that
there are cases where I want to aggregate several libraries into a
single library target so other clients can depend on one public
library target instead of having to reference a bunch of individual
library targets. For instance
This has been fixed (not by me), the NaCl build files will now find
Python from third_party.
I have a pending change to fix the same issue in chrome_frame/chrome_frame.gyp.
Cheers,
Jói
On Thu, Oct 1, 2009 at 1:46 AM, Roland Steiner rolandstei...@google.com wrote:
FWIW, I had similar troubles
Thanks Darin, Mike, and Jim for the quick response. Sounds like we'll have
this in the trunk for a couple days at least if not longer, so I updated the
XP perf expectation. The builder should stay green for now.
On Thu, Oct 1, 2009 at 7:58 AM, Chase Phillips ch...@chromium.org wrote:
Hey
I run Cygwin Bash Shell not from Command Prompt:
moha...@mohamed-pc ~$ bash
-Mohamed
On Thu, Oct 1, 2009 at 5:32 PM, vha14 vuh...@gmail.com wrote:
Hi Mohamed, can you run bash.exe from cmd? I get the following error:
E:\chromium\home\chrome-svn\tarball\chromium\src\third_party\cygwin
On Tue, Sep 29, 2009 at 12:44 PM, Daniel mpc...@gmail.com wrote:
I'm trying to cross compile chromium to ARM, but I'm getting errors in
the native client code.
./native_client/src/include/elf.h:68:3: error: #error
NACL_TARGET_SUBARCH must be defined to be 32 or 64
It looks like I have to
So it looks like I need to install Cygwin separately before I can
build Chrome? If so this should be added to the Windows build
instruction page.
On Oct 1, 2:59 pm, Mohamed Mansour m...@chromium.org wrote:
I run Cygwin Bash Shell not from Command Prompt:
moha...@mohamed-pc ~$ bash
-Mohamed
It's not supposed to be that way... maybe we need to check in a new cygwin.
On Thu, Oct 1, 2009 at 4:03 PM, vha14 vuh...@gmail.com wrote:
So it looks like I need to install Cygwin separately before I can
build Chrome? If so this should be added to the Windows build
instruction page.
On Oct
I built using the instructions on Windows 7 64 bit without installing
another cygwin.
On Thu, Oct 1, 2009 at 4:03 PM, vha14 vuh...@gmail.com wrote:
So it looks like I need to install Cygwin separately before I can
build Chrome? If so this should be added to the Windows build
instruction
Ok, got this one fixed. The problem is that in my enlistment, sh.exe
and bash.exe both crashed. I installed cygwin (1.5.25-15) and then
copied these shells from the cygwin installation over to src
\third_party\cygwin\bin. So maybe it's a good idea to check in this
version of cygwin.
On Oct 1,
Ok, I fixed the problem by installing Cygwin (1.5.25-15), copying sh.exe
and bash.exe over to src\third_party\cygwin\bin.
So it may be a good idea to check in this Cygwin version.
On Oct 1, 2009 4:43pm, John Abd-El-Malek j...@chromium.org wrote:
I built using the instructions on Windows 7 64
Hi,
The failure is in a unittest and only fails like this on linux. The windows
trybot is happy. The test uses HTTPTestServer (which talks to
testserver.py).
Can someone tell me what os_error of -7 means on linux?
Thanks,
Jenn
--~--~-~--~~~---~--~~
Chromium
Chrome's cygwin installation is hermetic. It works for a number of Google
devs on Windows 7/64 bit so I don't think it's a simple case of the cygwin
installation being broken. What do you mean the binaries crash, did they
not resolve any dependent dlls? Are you sure your gclient sync finished
I get the same behavior on the mac trybot too. Anyone seen this before?
On Thu, Oct 1, 2009 at 4:58 PM, Jenn Braithwaite (胡慧鋒) je...@google.comwrote:
Hi,
The failure is in a unittest and only fails like this on linux. The
windows trybot is happy. The test uses HTTPTestServer (which talks
Yes, my unittests fail consistently on both linux and mac trybots. The CL
link is:
http://codereview.chromium.org/201070
Here's a link to one of the linux try job failures:
http://build.chromium.org/buildbot/try-server/builders/linux/builds/1309
Given that this happens consistently on both
I think those are defined in net_error_list.h and that means timed out?
I would have said maybe it was a zombie python process from the test server
was lingering around and causing it to fail on subsequent runs, I've seen
that happen before. But you have several machines failing with this now...
The log output shows ssl_test_util.cc messages indicating the testserver was
started successfully.
Also, the net_unittests pass, and they use HTTPTestServer. Those run after
test_shell_tests.
On Thu, Oct 1, 2009 at 5:44 PM, Tim Steele t...@chromium.org wrote:
I think those are defined in
[bcc: chromium-dev]
As I said in my previous email (which was blocked by the ML) you
should have just replied to the email and saved 1600+ people time.
That what is written on the try job status email for a reason.
I'll send a follow up email with more information.
M-A
On Thu, Oct 1, 2009 at
Hi,
I need to be able to compile and run chrome in order to use it in
debug mode to test a relatively unrelated problem I am having with a
DirectX source filter that I wrote.
I downloaded the tarball, ran the commands to generate the chrome.sln
file. The packages appear to load correctly into
The first thing I thought of when I read this was that you might not have
all the prerequisites for building...
Have you gone through this document and verified that?
http://dev.chromium.org/developers/how-tos/build-instructions-windows
As a data point I can tell you that most of the code
Specifically, double-check that you have the right Platform SDK installed.
On Thu, Oct 1, 2009 at 19:43, Finnur Thorarinsson fin...@chromium.orgwrote:
The first thing I thought of when I read this was that you might not have
all the prerequisites for building...
Have you gone through this
I've added this to my list for review by the group.-Darin
On Thu, Oct 1, 2009 at 1:36 PM, Brian Rakowski br...@chromium.org wrote:
You should talk with the open web leads (darin, ifette, dglazkov,
slightlyoff) for help on floating this out there.
On Thu, Oct 1, 2009 at 1:12 PM, Nick Baum
69 matches
Mail list logo
