[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

2009-10-21 Thread John Grabowski
I sent mail to the nacl team and got reassurances(at 1138AM)  that they will
hit it asap.  I didn't cc chromium-dev because I used the internal nacl
mailing list.
jrg


On Tue, Oct 20, 2009 at 12:15 PM, Scott Violet s...@chromium.org wrote:


 I want to say this bug has existed for around a week now. Is anyone
 working on making it so that we don't need to explicitly set
 GYP_DEFINES for the build to work again?

  -Scott

 On Tue, Oct 20, 2009 at 10:29 AM, Evan Martin e...@chromium.org wrote:
 
  (Since I've been contacted by a bunch people independently about this
  problem already, here's one mail to hopefully point others who have
  the same problem.)
 
  Though we auto-detect your system architecture when we build, for
  reasons opaque to me this doesn't work with nacl.  I imagine someone
  is working on fixing it, but for now builds are broken.
 
  If you're getting errors like
   /usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
  and you're on a 64-bit system then you need to do one of
   1) export GYP_DEFINES='target_arch=x64'
   2) export GYP_DEFINES='disable_nacl=1'
 
  And then re-run gyp.
 
  
 

 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] chrome build problem on Ubuntu

2009-10-21 Thread webinfinite

Hi,

I am building Chromium on my Ubuntu box but have the following errors:


/usr/bin/ld: skipping incompatible /home/yezhang/chrome/chromium_zhang/
src/sconsbuild/Debug/lib/libnpGoogleNaClPluginChrome.a when searching
for -lnpGoogleNaClPluginChrome
/usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
collect2: ld returned 1 exit status
scons: *** [/home/yezhang/chrome/chromium_zhang/src/sconsbuild/Debug/
chrome] Error 1
scons: building terminated because of errors.


Please advise. Thanks for the help.

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: chrome build problem on Ubuntu

2009-10-21 Thread Evan Martin

http://groups.google.com/group/chromium-dev/browse_thread/thread/130391aa1809e41e

Also: I am glad you mailed chromium-dev rather than me.

On Tue, Oct 20, 2009 at 5:47 PM, webinfinite webinfin...@gmail.com wrote:

 Hi,

 I am building Chromium on my Ubuntu box but have the following errors:


 /usr/bin/ld: skipping incompatible /home/yezhang/chrome/chromium_zhang/
 src/sconsbuild/Debug/lib/libnpGoogleNaClPluginChrome.a when searching
 for -lnpGoogleNaClPluginChrome
 /usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
 collect2: ld returned 1 exit status
 scons: *** [/home/yezhang/chrome/chromium_zhang/src/sconsbuild/Debug/
 chrome] Error 1
 scons: building terminated because of errors.


 Please advise. Thanks for the help.

 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: chrome build problem on Ubuntu

2009-10-21 Thread Jacob Mandelson

On Tue, Oct 20, 2009 at 05:47:08PM -0700, webinfinite wrote:
 I am building Chromium on my Ubuntu box but have the following errors:
 
 
 /usr/bin/ld: skipping incompatible /home/yezhang/chrome/chromium_zhang/
 src/sconsbuild/Debug/lib/libnpGoogleNaClPluginChrome.a when searching
 for -lnpGoogleNaClPluginChrome
 /usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
 collect2: ld returned 1 exit status
 scons: *** [/home/yezhang/chrome/chromium_zhang/src/sconsbuild/Debug/
 chrome] Error 1
 scons: building terminated because of errors.

You're on x86_64, right?  There's a build bug on that arch where
chrome proper and nacl pick different build architectures or something
like that.  You can work around it by setting the envvar GYP_DEFINES
to target_arch=ia32 or target_arch=x64 so they don't try to pick an
arch themselves.  You'll have to run gclient runhooks to rebuild the
scons files from gyp.

 -- Jacob

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

2009-10-21 Thread Jeremy Orlow
Why did you use the internal nacl mailing list?  This is an issue that
affects all of Chromium.  The NaCl team members are on chromium-dev, right?
 If not, they should have been the day that our fates became intertwined.
J

On Tue, Oct 20, 2009 at 12:17 PM, John Grabowski j...@chromium.org wrote:

 I sent mail to the nacl team and got reassurances(at 1138AM)  that they
 will hit it asap.  I didn't cc chromium-dev because I used the internal nacl
 mailing list.
 jrg


  On Tue, Oct 20, 2009 at 12:15 PM, Scott Violet s...@chromium.org wrote:


 I want to say this bug has existed for around a week now. Is anyone
 working on making it so that we don't need to explicitly set
 GYP_DEFINES for the build to work again?

  -Scott

 On Tue, Oct 20, 2009 at 10:29 AM, Evan Martin e...@chromium.org wrote:
 
  (Since I've been contacted by a bunch people independently about this
  problem already, here's one mail to hopefully point others who have
  the same problem.)
 
  Though we auto-detect your system architecture when we build, for
  reasons opaque to me this doesn't work with nacl.  I imagine someone
  is working on fixing it, but for now builds are broken.
 
  If you're getting errors like
   /usr/bin/ld: cannot find -lnpGoogleNaClPluginChrome
  and you're on a 64-bit system then you need to do one of
   1) export GYP_DEFINES='target_arch=x64'
   2) export GYP_DEFINES='disable_nacl=1'
 
  And then re-run gyp.
 
  
 




 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

2009-10-21 Thread John Grabowski
On Wed, Oct 21, 2009 at 11:37 AM, Jeremy Orlow jor...@chromium.org wrote:

 Why did you use the internal nacl mailing list?


To keep things unambiguous and try for immediate action for a build-ish
break.  Only members can view list members for the public lists.  I didn't
want to join those lists just to confirm my mail would get sent to the right
people.


 This is an issue that affects all of Chromium.  The NaCl team members are
 on chromium-dev, right?  If not, they should have been the day that our
 fates became intertwined.


I have no idea if nacl members are on chromium-dev.  I didn't want to assume
and have the problem drop on the floor.

jrg

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

2009-10-21 Thread Jeremy Orlow
I'll follow up with the NaCl team to make sure they are.

On Wed, Oct 21, 2009 at 11:57 AM, John Grabowski j...@chromium.org wrote:



 On Wed, Oct 21, 2009 at 11:37 AM, Jeremy Orlow jor...@chromium.orgwrote:

 Why did you use the internal nacl mailing list?


 To keep things unambiguous and try for immediate action for a build-ish
 break.  Only members can view list members for the public lists.  I didn't
 want to join those lists just to confirm my mail would get sent to the right
 people.


 This is an issue that affects all of Chromium.  The NaCl team members are
 on chromium-dev, right?  If not, they should have been the day that our
 fates became intertwined.


 I have no idea if nacl members are on chromium-dev.  I didn't want to
 assume and have the problem drop on the floor.

 jrg


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

2009-10-21 Thread Michael Moss

To update, the issue will probably be resolved in gyp. Nacl has a bit
of an unusual build configuration,  but it should probably be
supported. There is a discussion on the gyp developers list looking
into the best way to accommodate it.

Michael

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

2009-10-21 Thread Bradley Nelson
Michael,
The variables handling in gyp definitely needs to be settled, but to get
people going with this, I've sent you a change that should resolve this
particular case (though it is moderately redundant).

-BradN

On Wed, Oct 21, 2009 at 12:58 PM, Michael Moss mm...@chromium.org wrote:


 To update, the issue will probably be resolved in gyp. Nacl has a bit
 of an unusual build configuration,  but it should probably be
 supported. There is a discussion on the gyp developers list looking
 into the best way to accommodate it.

 Michael

 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: [linux] how to work around nacl errors in 64-bit build

2009-10-21 Thread Bradley Nelson
That's http://codereview.chromium.org/295044 for reference.

On Wed, Oct 21, 2009 at 1:06 PM, Bradley Nelson bradnel...@google.comwrote:

 Michael,
 The variables handling in gyp definitely needs to be settled, but to get
 people going with this, I've sent you a change that should resolve this
 particular case (though it is moderately redundant).

 -BradN


 On Wed, Oct 21, 2009 at 12:58 PM, Michael Moss mm...@chromium.org wrote:


 To update, the issue will probably be resolved in gyp. Nacl has a bit
 of an unusual build configuration,  but it should probably be
 supported. There is a discussion on the gyp developers list looking
 into the best way to accommodate it.

 Michael

 



--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] WebKit gardening and media layout tests

2009-10-21 Thread Andrew Scherkus
If you roll WebKit DEPS and media layout tests start failing, don't fret!
Mark them as PASS FAIL and assign them to bug 13907.  Don't worry about
specifying the operating system or release/debug -- our code is mostly
platform agnostic so if it flakily fails on one bot, it's only a matter of
time before it shows up on a different build.
Thanks!
Andrew

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Survey: Please read and respond!

2009-10-21 Thread Peter Kasting
Update:  So far I have 26 responses.  Google Groups tells me these two
groups combined have as many as 4789 members (although there is probably a
lot of overlap between the two so that number is lower), so that's about an
0.5% response rate.  If you don't respond, we can't make any changes to make
your life better!  I'd love to see at least a couple hundred responses.
PK

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] A tale of two (or more) syncing extensions, and a proposal

2009-10-21 Thread Tim Steele
[re-sending from correct email account]

Hi,

I wrote up a document that discusses some interesting unintentional
relationships that can exist between independent extensions, and how this
general problem also currently affects the browser sync engine.  This issue
was discovered from trying to explain the primary symptom of unusually high
syncing traffic generated by Chrome clients.  Please find it here:

A Tale of Two (or more) Sync
Engineshttp://docs.google.com/Doc?docid=0Aa_pnb1d4_gnZDUzOWp4bV8wZHNzdHdnczIhl=en

You should read that before continuing!

This led to me thinking about what we do long term, short term, or basically
before Chrome Sync and extensions are running in parallel in a beta channel
environment. You'll see a bit of this at the end of the first document, but
after posing the problem as an extensions problem I ended up at a random
idea that I think makes at least a little sense, though I admit I was having
fun thinking and writing about it so maybe I missed some major roadblocks
along the way.  There are downsides, mainly revolving around the added
hand-holding we would impose on extensions.  Please read! Hoping for
comments and feedback. Extensions API
quotaserverhttp://docs.google.com/Doc?docid=0Aa_pnb1d4_gnZDUzOWp4bV8xZnhqaHJmZjMhl=en

In addition to that, Colin and Todd (cc'ed) brought up some sync specific
ideas they have (I mention it a bit at the end of the first doc).  We'll try
to get a separate thread going about this soon!

Thanks!
Tim

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: A tale of two (or more) syncing extensions, and a proposal

2009-10-21 Thread Aaron Boodman

Have not read all of it yet, but am in favor in general of having some
sort of quota for extension api calls to protect from meltdown.

We have a very convenient chokepoint to implement this in our system,
so it would just be a matter of a more detailed design of the
heuristics to use for each API type.

- a

On Wed, Oct 21, 2009 at 5:08 PM, Tim Steele t...@chromium.org wrote:
 [re-sending from correct email account]
 Hi,
 I wrote up a document that discusses some interesting unintentional
 relationships that can exist between independent extensions, and how this
 general problem also currently affects the browser sync engine.  This issue
 was discovered from trying to explain the primary symptom of unusually high
 syncing traffic generated by Chrome clients.  Please find it here:
 A Tale of Two (or more) Sync Engines
 You should read that before continuing!
 This led to me thinking about what we do long term, short term, or basically
 before Chrome Sync and extensions are running in parallel in a beta channel
 environment. You'll see a bit of this at the end of the first document, but
 after posing the problem as an extensions problem I ended up at a random
 idea that I think makes at least a little sense, though I admit I was having
 fun thinking and writing about it so maybe I missed some major roadblocks
 along the way.  There are downsides, mainly revolving around the added
 hand-holding we would impose on extensions.  Please read! Hoping for
 comments and feedback. Extensions API quotaserver
 In addition to that, Colin and Todd (cc'ed) brought up some sync specific
 ideas they have (I mention it a bit at the end of the first doc).  We'll try
 to get a separate thread going about this soon!
 Thanks!
 Tim
 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Linux/Stability - Remember to check the return value from GTK functions.

2009-10-21 Thread Lei Zhang

Hi Linux folks,

This is a kind reminder to check the return values from GTK functions.
Every time you put the unchecked result from, say,
gtk_file_chooser_get_filename() into a FilePath or std::string, you
risk a browser process crash if the result is NULL.

I just triaged several crashes of this type. There's probably more...

http://code.google.com/p/chromium/issues/detail?id=25490
http://code.google.com/p/chromium/issues/detail?id=25491
http://code.google.com/p/chromium/issues/detail?id=25493
http://code.google.com/p/chromium/issues/detail?id=25494

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---