Thanks! I will submit my two patches tomorrow when it works again.
On Sat, Apr 25, 2009 at 11:24 PM, Finnur Thorarinsson
wrote:
> I saw some internal thread about a problem with the codereview site -- It
> indicated that it is actively being looked at. I don't know anything more
> than that, unf
I saw some internal thread about a problem with the codereview site -- It
indicated that it is actively being looked at. I don't know anything more
than that, unfortunately, but hopefully it will be resolved soon.
Sorry about the interruption.
-F
On Sat, Apr 25, 2009 at 20:16, Mohamed Mansour wrot
Hello,
Codereview has been down, up, down, up many times today, making it difficult
to submit patches. Can anyone take a look at it please.
Loaded authentication cookies from C:\Documents and Settings\Mohamed
Mansour/.codereview_upload_cookies
Traceback (most recent call last):
File "C:\bin\depo
What if a user starts chrome twice in quick succession? Process A
starts, looks for the pid file. Next process B starts and does the
same. Both don't see a file, so they both create one. One overwrites
the file created by the other. Now there are two "main" processes,
only one of which can be foun
If you don't have a 172 branch checked out, you can stop reading.
I updated the V8 dependency to use branches/1.1 instead of trunk. You need
to delete src/v8 and gclient sync to get your working copy to switch to the
branch.
--Mark
--~--~-~--~~~---~--~~
Chromium De
On 25 апр, 05:09, Peter Kasting wrote:
> On Thu, Apr 23, 2009 at 1:35 PM, Nikita Ofitserov wrote:
> > I suggest:
> > Don't try to get pid dynamically, but create on startup in datadir
> > file 'ChromePid' or something like that with pid.
>
> Creating files during startup would slow startup too m
On Fri, Apr 24, 2009 at 11:29 PM, Ben Goodger (Google)
wrote:
> chrome/common/clipboard_service.h
I don't see the point of this class. Let's just kill it, finally.
> chrome/common/scoped_vector.h
This file really wants to be in base.
Adam
--~--~-~--~~~---~--~---
